From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.devel Subject: Re: MPS: weak hash tables Date: Wed, 03 Jul 2024 10:41:46 +0000 Message-ID: References: <1VNw6cPSIpKfxNRqQBpVleX2BDbQuUqwLQzo-C8N-_PRvNNLG3BnhbcWpUJkiJYnOogBvqRTcLApebjqdZel7CgXVx9T0CnPn6_go_AugDA=@protonmail.com> <-plQctKgNkvp-LJ9ov2QAiXQKxd9V-hI0yz_opRGxQtbknubCjH4rH2-ymgbw_Qr1ZhB1rtlmiEW8XtuIVNr7nR_Yj20AH6WkH6kUGp68g0=@protonmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36871"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Helmut Eller , Eli Zaretskii , Emacs Devel To: =?utf-8?Q?Gerd_M=C3=B6llmann?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jul 03 12:53:29 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sOxc8-0009Kq-Jm for ged-emacs-devel@m.gmane-mx.org; Wed, 03 Jul 2024 12:53:28 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sOxbI-0002ci-44; Wed, 03 Jul 2024 06:52:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sOxR5-0007vd-7E for emacs-devel@gnu.org; Wed, 03 Jul 2024 06:42:03 -0400 Original-Received: from mail-4316.protonmail.ch ([185.70.43.16]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sOxQx-0002TU-Ac; Wed, 03 Jul 2024 06:42:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1720003312; x=1720262512; bh=zw8C9ETjAdxMlcZoVGdf7a5EvpJyEYuSrQ4Q9QoBwu8=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=EYTnEyEZFy41d1/craD9+y4dmOPYlx8aoS6ozDO8qPWDYAZuR3qGgJcng5Pfzs9vs I67LrPTjiQws2mLILvNqPyD6tM1dEy/RBD/K8rlcLFeQKfnotpbX580nKH5wYX9wOf d3AbortJ41q55Ry+3F8dpZc7P2wChr45cnEZkXwW9ExKy3lzPxmNb9XdZ3Y9ciDLM8 OhRVygPQf6Q14avTVXRes18KXgkGOnj/m0wMhj4Ww/Aj4VOMcyVZhh37O0md3djn8E lYUAMFwfgJEKhCvU73byFgxDB9/kozUD3q2KPELR9kEvdTI3YcYnggCrMFKpHdUnlY FjKw93WmwGL/A== In-Reply-To: Feedback-ID: 112775352:user:proton X-Pm-Message-ID: bce90196414f61ab6b080689582d1cce8a1039a3 Received-SPF: pass client-ip=185.70.43.16; envelope-from=pipcet@protonmail.com; helo=mail-4316.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 03 Jul 2024 06:52:28 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321244 Archived-At: On Wednesday, July 3rd, 2024 at 10:22, Gerd M=C3=B6llmann wrote: >=20 >=20 > Pip Cet pipcet@protonmail.com writes: >=20 > > On Wednesday, July 3rd, 2024 at 08:26, Gerd M=C3=B6llmann gerd.moellman= n@gmail.com wrote: > >=20 > > > The PVEC_FREE lead to an abort, which I think I fixed. Please pull. > >=20 > > Thanks, sorry for missing that! >=20 >=20 > Move fast and break things. Normal. >=20 > > So I've implemented Helmut's idea, but it's turned out uglier than I > > thought it would... >=20 >=20 > It meets my expections. >=20 > > And of course the same needs to be done for the marker vector, right? >=20 >=20 > Yep :-(. What's somewhat irritating is how hard it is to actually make it produce an= error. Only single-byte offset-mov is emulated, not mov without an offset,= but that's what gcc -O0 produces... On existing mps, we could just force AWLSegSALimit to 0 and AWLHaveSegSALim= it to true, which would avoid the issue :-/ We can always go back to my weak-hash-table-for-BUF_MARKERS idea, that woul= d reduce code duplication a little. Let me know if you'd prefer that. Pip