bug#41221: Add some ediff faces to misterioso theme to improve readability

bug#41221: Add some ediff faces to misterioso theme to improve readability

[Simon Lang]

[-- Attachment #1: Type: text/plain, Size: 108 bytes --]

This fix adds ediff faces for 

ediff-even-diff-A
ediff-even-diff-B
ediff-odd-diff-A
ediff-odd-diff-B

[-- Attachment #2: 0001-Improve-ediff-readability-in-misterioso-theme.patch --]
[-- Type: application/octet-stream, Size: 1153 bytes --]

From 34b3bba8b919fc4e513c6202444d1287765de64e Mon Sep 17 00:00:00 2001
From: Simon Lang <simon.lang@outlook.com>
Date: Tue, 12 May 2020 22:54:52 +0100
Subject: [PATCH] Improve ediff readability in misterioso theme

* etc/themes/misterioso-theme.el: Add ediff faces
---
 etc/themes/misterioso-theme.el | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/etc/themes/misterioso-theme.el b/etc/themes/misterioso-theme.el
index 8161dbd9e9..030cb3dd75 100644
--- a/etc/themes/misterioso-theme.el
+++ b/etc/themes/misterioso-theme.el
@@ -63,6 +63,11 @@
    `(button ((,class (:underline t))))
    `(link ((,class (:foreground "#59e9ff" :underline t))))
    `(link-visited ((,class (:foreground "#ed74cd" :underline t))))
+   ;; Ediff
+   `(ediff-even-diff-A ((,class (:background "#1d2430"))))
+   `(ediff-even-diff-B ((,class (:background "#1d2430"))))
+   `(ediff-odd-diff-A ((,class (:background "#415160"))))
+   `(ediff-odd-diff-B ((,class (:background "#415160"))))
    ;; Gnus faces
    `(gnus-group-news-1 ((,class (:foreground "#ff4242" :weight bold))))
    `(gnus-group-news-1-low ((,class (:foreground "#ff4242"))))
-- 
2.21.0 (Apple Git-122)

bug#41221: Add some ediff faces to misterioso theme to improve readability

[Stefan Kangas]

Simon Lang <simon.lang@outlook.com> writes:

> This fix adds ediff faces for
>
> ediff-even-diff-A
> ediff-even-diff-B
> ediff-odd-diff-A
> ediff-odd-diff-B

Thank you for your contribution.

This is obviously broken in the theme as is, since you can't read the
changed text in ediff.  I tested it, and your change looks good to me.

Eli, is the below acceptable for emacs-27?

> diff --git a/etc/themes/misterioso-theme.el b/etc/themes/misterioso-theme.el
> index 8161dbd9e9..030cb3dd75 100644
> --- a/etc/themes/misterioso-theme.el
> +++ b/etc/themes/misterioso-theme.el
> @@ -63,6 +63,11 @@
>     `(button ((,class (:underline t))))
>     `(link ((,class (:foreground "#59e9ff" :underline t))))
>     `(link-visited ((,class (:foreground "#ed74cd" :underline t))))
> +   ;; Ediff
> +   `(ediff-even-diff-A ((,class (:background "#1d2430"))))
> +   `(ediff-even-diff-B ((,class (:background "#1d2430"))))
> +   `(ediff-odd-diff-A ((,class (:background "#415160"))))
> +   `(ediff-odd-diff-B ((,class (:background "#415160"))))

Best regards,
Stefan Kangas

bug#41221: Add some ediff faces to misterioso theme to improve readability

[Simon Lang]

[-- Attachment #1: Type: text/plain, Size: 1520 bytes --]

Hi,

sorry, I relaized that I forgot about 

ediff-even-diff-C
ediff-odd-diff-C

I added these now (trivial change, same faces as the others).

Thank you!!

________________________________________
From: Stefan Kangas <stefankangas@gmail.com>
Sent: 13 May 2020 02:16
To: Simon Lang; 41221@debbugs.gnu.org
Cc: Eli Zaretskii
Subject: Re: bug#41221: Add some ediff faces to misterioso theme to improve readability

Simon Lang <simon.lang@outlook.com> writes:

> This fix adds ediff faces for
>
> ediff-even-diff-A
> ediff-even-diff-B
> ediff-odd-diff-A
> ediff-odd-diff-B

Thank you for your contribution.

This is obviously broken in the theme as is, since you can't read the
changed text in ediff.  I tested it, and your change looks good to me.

Eli, is the below acceptable for emacs-27?

> diff --git a/etc/themes/misterioso-theme.el b/etc/themes/misterioso-theme.el
> index 8161dbd9e9..030cb3dd75 100644
> --- a/etc/themes/misterioso-theme.el
> +++ b/etc/themes/misterioso-theme.el
> @@ -63,6 +63,11 @@
>     `(button ((,class (:underline t))))
>     `(link ((,class (:foreground "#59e9ff" :underline t))))
>     `(link-visited ((,class (:foreground "#ed74cd" :underline t))))
> +   ;; Ediff
> +   `(ediff-even-diff-A ((,class (:background "#1d2430"))))
> +   `(ediff-even-diff-B ((,class (:background "#1d2430"))))
> +   `(ediff-odd-diff-A ((,class (:background "#415160"))))
> +   `(ediff-odd-diff-B ((,class (:background "#415160"))))

Best regards,
Stefan Kangas

[-- Attachment #2: 0001-Improve-ediff-readability-in-misterioso-theme.patch --]
[-- Type: application/octet-stream, Size: 1274 bytes --]

From bdd582487a02275d82bfda01ebb6d0605c0349d0 Mon Sep 17 00:00:00 2001
From: Simon Lang <simon.lang@outlook.com>
Date: Tue, 12 May 2020 22:54:52 +0100
Subject: [PATCH] Improve ediff readability in misterioso theme

* etc/themes/misterioso-theme.el: Add ediff faces
---
 etc/themes/misterioso-theme.el | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/etc/themes/misterioso-theme.el b/etc/themes/misterioso-theme.el
index 8161dbd9e9..ff9af0c744 100644
--- a/etc/themes/misterioso-theme.el
+++ b/etc/themes/misterioso-theme.el
@@ -63,6 +63,13 @@
    `(button ((,class (:underline t))))
    `(link ((,class (:foreground "#59e9ff" :underline t))))
    `(link-visited ((,class (:foreground "#ed74cd" :underline t))))
+   ;; Ediff
+   `(ediff-even-diff-A ((,class (:background "#1d2430"))))
+   `(ediff-even-diff-B ((,class (:background "#1d2430"))))
+   `(ediff-even-diff-C ((,class (:background "#1d2430"))))
+   `(ediff-odd-diff-A ((,class (:background "#415160"))))
+   `(ediff-odd-diff-B ((,class (:background "#415160"))))
+   `(ediff-odd-diff-C ((,class (:background "#415160"))))
    ;; Gnus faces
    `(gnus-group-news-1 ((,class (:foreground "#ff4242" :weight bold))))
    `(gnus-group-news-1-low ((,class (:foreground "#ff4242"))))
-- 
2.21.0 (Apple Git-122)

bug#41221: Add some ediff faces to misterioso theme to improve readability

[Eli Zaretskii]

> From: Stefan Kangas <stefankangas@gmail.com>
> Date: Tue, 12 May 2020 18:16:55 -0700
> Cc: Eli Zaretskii <eliz@gnu.org>
> 
> Eli, is the below acceptable for emacs-27?

Yes, thanks.

bug#41221: Add some ediff faces to misterioso theme to improve readability

[Stefan Kangas]

close 41221 27.1
thanks

Hi Simon,

Simon Lang <Simon.lang@outlook.com> writes:

> I added these now (trivial change, same faces as the others).

Great, looks good to me.

Thanks again for your contribution, which I have now pushed to emacs-27
as commit 747e0a2523.  It will be part of the upcoming Emacs 27.1.

Best regards,
Stefan Kangas