From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Arthur Miller Newsgroups: gmane.emacs.devel Subject: Re: empty-directory predicate, native implementation Date: Sat, 17 Oct 2020 01:31:53 +0200 Message-ID: References: <83y2ka18t7.fsf@gnu.org> <87y2kaj799.fsf@gmx.de> <83blh60wgr.fsf@gnu.org> <87h7qxjh7g.fsf@gmx.de> <878sc8kgy8.fsf@gmx.de> <87imbcls71.fsf@gmx.de> <83eem0zt0b.fsf@gnu.org> <87k0vsrd6m.fsf@gmx.de> <83a6wozs7h.fsf@gnu.org> <87sgafq2e2.fsf@gmx.de> <87h7qvptm3.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38531"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Oct 17 01:33:10 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kTZDh-0009wK-Kx for ged-emacs-devel@m.gmane-mx.org; Sat, 17 Oct 2020 01:33:09 +0200 Original-Received: from localhost ([::1]:43074 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kTZDg-00027d-NT for ged-emacs-devel@m.gmane-mx.org; Fri, 16 Oct 2020 19:33:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35542) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kTZCd-0001eZ-Up for emacs-devel@gnu.org; Fri, 16 Oct 2020 19:32:03 -0400 Original-Received: from mail-vi1eur06olkn2077.outbound.protection.outlook.com ([40.92.17.77]:13431 helo=EUR06-VI1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kTZCb-0005fh-9r; Fri, 16 Oct 2020 19:32:03 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Mr+uD9J+ccOjyrqF7Cf31P1KYo8e8FOaAj9SMhTX3ll4gb9xtXqP04XwgOv8qXW7oSpGfftps4kDOHDfb2tFTO4cI62Yw8XrWsX0pygDeaoBQE9TAoaxykh7qMRx3sAmLSwvSv5xWzSMQl+pzKRkQHe/GX2a8BN0dH9S+g1rBboURZo1PfqJR7R4P/ZAk5Qq4QB5dajDCEjbAksxUlqKhjJuQPq5T2f72J2N+McMzXi6YZ210eTzf3i+MINq1NSWKI+BYOQ9x6Lg1hgIiDRXFbasM3LT7QUhCuxZ0rR0dmhCZxKlCK+k5NW5rhp6amiHG9xL1znjIoTocWAYTtmnmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fTHq6jrb1IJQjdgTEsA2tlff35mvMhSvNpb6uz7WtfY=; b=E8VKg8cK7v1QdutZc/ftGzAlil9MAuCEFwSUxqTq8NzS4M/6UkuXJvXJW91nNF9FAu7scI1l0xG1Fs1uBdGQlbo3FWWDQXMWnWvXFa01kJk/ZxeNDR6DaR1FIW0z3JkvxPaLNBCzXu+baPtH/9FTm3I+wBmIRUf7HO29qhJquctgQIvIEh6A40ZjskU1OLft/eDYCvpewx63ssw2NzzHoAcFLHBIxujocE9W+C35cKwzD5PeQByV7nAO6muDrnjFjgdzYvc3aSUoML4rqMowAxbBmxxM9r9ZqdXMej6F/NXmlryaTrNOciVv72Juzj+yvWIQxkYJKZXI/HKfUiJbTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fTHq6jrb1IJQjdgTEsA2tlff35mvMhSvNpb6uz7WtfY=; b=CTWwpc2Yb2ce2sdm/VRixNcsYwX5SHrBwZJLnMOp2cElkkgbDnsHQhnpTSU4SGciX6fK+7D0irTpp0u2JCwAbVN+nA4e6jSe0CCoKpRqIOC3P3oC2I2hNEsAPUYN+uJvHHKsu5yzd9D0Zqyx4nyy1UiCOOehu4BskcTdRGu60lwrhcQTr+smGJ9hPkqjzFRrhJymlXtxF19NXyiMHtBAA47wjCJUWz3CqCkjCczkucdwDb7nH/kXCGdrDY/U6Zibzr6fgQ3vr2ns1ia15yN3WVBxmZ2dd+XUJ73XgJ/tfsZRtLbjmeYK4VTA5sFFKvtClaPjjbZ/Q77XNK3L4CM0hw== Original-Received: from AM7EUR06FT009.eop-eur06.prod.protection.outlook.com (2a01:111:e400:fc36::4f) by AM7EUR06HT022.eop-eur06.prod.protection.outlook.com (2a01:111:e400:fc36::262) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.21; Fri, 16 Oct 2020 23:31:57 +0000 Original-Received: from VI1PR06MB4526.eurprd06.prod.outlook.com (2a01:111:e400:fc36::4f) by AM7EUR06FT009.mail.protection.outlook.com (2a01:111:e400:fc36::288) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.21 via Frontend Transport; Fri, 16 Oct 2020 23:31:57 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:BD11464B0A4525B96467AE405D4A66D2A38178CB41EB90DF8C747017931B9EBD; UpperCasedChecksum:C35C11F6F4C837121BB1265561DF6BB46FDC8B4440CDACA24E44F825E506848A; SizeAsReceived:8193; Count:46 Original-Received: from VI1PR06MB4526.eurprd06.prod.outlook.com ([fe80::187b:196a:cb2d:adf1]) by VI1PR06MB4526.eurprd06.prod.outlook.com ([fe80::187b:196a:cb2d:adf1%5]) with mapi id 15.20.3477.023; Fri, 16 Oct 2020 23:31:57 +0000 In-Reply-To: <87h7qvptm3.fsf@gmx.de> (Michael Albinus's message of "Thu, 15 Oct 2020 14:21:40 +0200") X-TMN: [VXfQTlSjOBOrKFwYOIf0LsHlZC4cp8hk] X-ClientProxiedBy: AM5PR0602CA0020.eurprd06.prod.outlook.com (2603:10a6:203:a3::30) To VI1PR06MB4526.eurprd06.prod.outlook.com (2603:10a6:803:ac::17) X-Microsoft-Original-Message-ID: <87y2k5sq6u.fsf@live.com> X-MS-Exchange-MessageSentRepresentingType: 1 Original-Received: from pascal.homepc (90.230.29.56) by AM5PR0602CA0020.eurprd06.prod.outlook.com (2603:10a6:203:a3::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.22 via Frontend Transport; Fri, 16 Oct 2020 23:31:54 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 46 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: dffa0dda-0646-46a6-a624-08d8722baab2 X-MS-TrafficTypeDiagnostic: AM7EUR06HT022: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yc140itGghFo2WWiLsyJqY6t2ys5vgtmFOTjEx16VHbq4qwD80l/I+TX7ZMLH+VlymJXoD+9HkTikzPnOKOVYJP1XXXNXWHYRoA2FxXb8twMTgNDAdgUJU/N25GkgAY7+YJXVYzetoTmHoc7H+0jb7QMhYzcG4EfPk/sVFZEFB+LrgusCkTQW8KI9jJjEdodIVVrqLnXh1kVnBa3sJpoWvC6iUdQbLdRftcasyLv+sCzhdpjFFGF13N1eMy1BaOF X-MS-Exchange-AntiSpam-MessageData: YEwwdUCx1knyuPoI0zb7fPnuQSc9H9J+FeXNe0eTVlhNehlL2VfjvnOC6jbd0jg3UkmMh2vcN0yuKcORuToMSydGbzb9bfF2dqV0VFOr8B2GmM9B4vakrZTfHXmWef5lnGicVHu3Y7rSd6JtTn3X7g== X-OriginatorOrg: live.com X-MS-Exchange-CrossTenant-Network-Message-Id: dffa0dda-0646-46a6-a624-08d8722baab2 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2020 23:31:57.0106 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: AM7EUR06FT009.eop-eur06.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7EUR06HT022 Received-SPF: pass client-ip=40.92.17.77; envelope-from=arthur.miller@live.com; helo=EUR06-VI1-obe.outbound.protection.outlook.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/16 19:31:57 X-ACL-Warn: Detected OS = Windows NT kernel [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:257887 Archived-At: Michael Albinus writes: > Arthur Miller writes: > > Hi Arthur, > >>> Thanks for this. I haven't seen your name on the FSF file; I guess your >>> legal papers are on the way? >> They are not, but they can be if someone send me link. I've been looking >> at this page: >> >> https://www.gnu.org/prep/maintain/html_node/Copyright-Papers.html#Copyright-Papers >> >> but I am not really sure where do I send request. > > Sorry, I should have asked. I'll send you the template off-list. > >>> - Adapt the file name handlers. These are ange-ftp-directory-files, >>> ange-ftp-directory-files-and-attributes, tramp-handle-directory-files, >>> tramp-handle-directory-files-and-attributes, >>> tramp-adb-handle-directory-files-and-attributes, >>> tramp-crypt-handle-directory-files, >>> tramp-rclone-handle-directory-files, >>> tramp-sh-handle-directory-files-and-attributes, >>> tramp-smb-handle-directory-files. >> >> Aha, so it is how it works; didn't have time to look into tramp yet. >> Ok, I'll do; I'll sent in patch(es) when I am done. Probably not today >> though but during the weekend of beginning of the next week. > > There's no rush. Doing the legal work will take a week or so. > >> So many changes just for one signature :-). > > In order to enjoy you: Tramp is backward compatible back to Emacs > 25. This must also be taken into account :-) > > But don't worry, I'll make the needed changes after your commit. > >>> - Adapt resp extend ERT tests. These are tramp-test16-directory-files, >>> tramp-test19-directory-files-and-attributes, >>> tramp-archive-test16-directory-files and >>> tramp-archive-test19-directory-files-and-attributes. >>> >>> - Optionally (but much appreciated), write new ERT tests for >>> directory-files and directory-files-and-attributes. >> >> Will have to look at ERT, I suppose it is not too complicated, >> opportunity to learn it. > > A look at the ert manual might help. (info "(ert)") > >> I mainly try to be clear "what I intent" for some future reader; since >> previous code uses lisp.h macros, I used same. I thought that one extra >> 'if' is not that much of a penalty, I'll gladly shortcircut with !last. > > In case you feel the need, you could also provide a comment. > > Best regards, Michael. I have patched handlers; which version should I make patches against: current master or latest stable? How would you like patches; each in own file? I will look at ert tests too.