From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Mauger Newsgroups: gmane.emacs.bugs Subject: bug#31446: 26.1; sql-interactive-mode buffer naming is broken Date: Sat, 02 Jun 2018 19:47:17 -0400 Message-ID: References: <83fu2jej5t.fsf@gnu.org> <834liphz6n.fsf@gnu.org> Reply-To: Michael Mauger NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1527983168 11054 195.159.176.226 (2 Jun 2018 23:46:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 2 Jun 2018 23:46:08 +0000 (UTC) To: Eli Zaretskii , "psainty@orcon.net.nz" , "31446@debbugs.gnu.org" <31446@debbugs.gnu.org>, "fgunbin@fastmail.fm" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 03 01:46:03 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fPGDi-0002m8-Cn for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Jun 2018 01:46:02 +0200 Original-Received: from localhost ([::1]:33077 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fPGFp-0001V7-CH for geb-bug-gnu-emacs@m.gmane.org; Sat, 02 Jun 2018 19:48:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57587) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fPGFh-0001Uo-B6 for bug-gnu-emacs@gnu.org; Sat, 02 Jun 2018 19:48:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fPGFe-00089J-7q for bug-gnu-emacs@gnu.org; Sat, 02 Jun 2018 19:48:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51756) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fPGFe-000892-3U for bug-gnu-emacs@gnu.org; Sat, 02 Jun 2018 19:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fPGFd-0001Ku-Jy for bug-gnu-emacs@gnu.org; Sat, 02 Jun 2018 19:48:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Mauger Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Jun 2018 23:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31446 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31446-submit@debbugs.gnu.org id=B31446.15279832615099 (code B ref 31446); Sat, 02 Jun 2018 23:48:01 +0000 Original-Received: (at 31446) by debbugs.gnu.org; 2 Jun 2018 23:47:41 +0000 Original-Received: from localhost ([127.0.0.1]:59653 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fPGFI-0001KB-Vt for submit@debbugs.gnu.org; Sat, 02 Jun 2018 19:47:41 -0400 Original-Received: from mail2.protonmail.ch ([185.70.40.22]:53661) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fPGFG-0001K2-LV for 31446@debbugs.gnu.org; Sat, 02 Jun 2018 19:47:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=default; t=1527983244; bh=SQcGqBaPts8aT2JUx7G6Ss5gtJhzEWt7H35GKHn3pe0=; h=Date:To:From:Reply-To:Subject:In-Reply-To:References:Feedback-ID: From; b=YRoCvXLTFLLQvshtQzVrWCtCFRU1HNh8Tz+s1qS3GFcgwyMy555BxnUFhViWkyocK luI6H43Au+f4TOFkurzBZ/P/S1gShyt5eyzkI/1vVtorvQORcOft/H9zUedtyZQjLb YsSnuDOUDzyNDdnryUDOMbu/oUd1ZSZbvw2TS3nw= In-Reply-To: <834liphz6n.fsf@gnu.org> Feedback-ID: b6CpL0MxcIA6fpHRkn3ZHzWS0Hoqxbtv_SrHfEzC9D85cLvnRsVk4rKaAOJUw48iy20W0W1VX4whjBYFluIX0w==:Ext:ProtonMail X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:146884 Archived-At: =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 Original Me= ssage =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 On May 30, 2018 12:43 PM, Eli Zaretskii wrote: > > Date: Tue, 29 May 2018 22:51:35 -0400 > > From: Michael Mauger mmauger@protonmail.com > >=20 > > I expect to make an initial commit to master in a couple of days of sql= .el. > > > > That will be followed up with a commit of improved DOCSTRINGs, tests, > > and possibly an Info file. > >=20 >=20 > Thanks. I have made a commit that fixes the buffer name handling. This code was=20 intended for 26.1 but obviously missed that. Please review it and let me know what you find. Outstanding work: * There is a bug around locating sql-interactive buffers from a sql buffer;= I=20 know how to fix it, just need to further test the code. * Rewrite the DOCSTRINGs to reflect the improved logic * Add code tests to limit regressions like this in the future * Add a Info file documenting sql-mode and the intended behavior. Thanks and sorry for the bug. =E2=80=8B-- MICHAEL@MAUGER.COM // FSF and EFF member // GNU Emacs sql.el maintainer= =E2=80=8B