From: Pip Cet <pipcet@protonmail.com>
To: Gerd Moellmann <gerd@gnu.org>
Cc: Emacs Devel <emacs-devel@gnu.org>
Subject: Re: scratch/igc 50f3a9309d8 1/3: scan_stack with __builtin_unwind_init
Date: Sat, 20 Jul 2024 08:06:43 +0000 [thread overview]
Message-ID: <TrtQ8omnzoxmdrTo59zK2LHh6ED3cKs8jl9rPdnfCeXjpbIpbP0h2IGtn0ksbIVNwZQAFvVTvhaBh-oik_-lsvU78vGQTEQ-3zfWIvoSk0o=@protonmail.com> (raw)
In-Reply-To: <20240720074130.5C19DC1FB72@vcs2.savannah.gnu.org>
On Saturday, July 20th, 2024 at 07:41, Gerd Moellmann <gerd@gnu.org> wrote:
> branch: scratch/igc
> commit 50f3a9309d80c46c4d0b0b362ad65ef509c4d8ad
> Author: Gerd Möllmann gerd@gnu.org
>
> Commit: Gerd Möllmann gerd@gnu.org
>
>
> scan_stack with __builtin_unwind_init
> ---
> src/igc.c | 20 +++++++++++++++++++-
> 1 file changed, 19 insertions(+), 1 deletion(-)
>
> diff --git a/src/igc.c b/src/igc.c
> index 9298cae66db..e63b796997a 100644
> --- a/src/igc.c
> +++ b/src/igc.c
> @@ -1356,6 +1356,24 @@ scan_ambig (mps_ss_t ss, void *start, void *end, void *closure)
> return MPS_RES_OK;
> }
>
> +static mps_res_t
> +scan_stack (mps_ss_t ss, void *start, void *end, void *closure)
> +{
> + MPS_SCAN_BEGIN (ss)
> + {
> +#ifdef HAVE___BUILTIN_UNWIND_INIT
> + __builtin_unwind_init ();
> + asm ("");
> + void *p;
> + start = min (start, (void *) &p);
> + end = max (end, (void *) &p);
That assumes we're scanning the current thread, right? It appears to break
(make-thread (lambda () (igc-collect)))
here...
By the way, I'm seeing weird errors when I compile with clang and -flto for Android. Can you check whether Apple clang maybe enables -flto for -O?
Pip
next parent reply other threads:[~2024-07-20 8:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <172146128986.990.283901147449966365@vcs2.savannah.gnu.org>
[not found] ` <20240720074130.5C19DC1FB72@vcs2.savannah.gnu.org>
2024-07-20 8:06 ` Pip Cet [this message]
2024-07-20 8:46 ` scratch/igc 50f3a9309d8 1/3: scan_stack with __builtin_unwind_init Gerd Möllmann
2024-07-20 8:54 ` Gerd Möllmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='TrtQ8omnzoxmdrTo59zK2LHh6ED3cKs8jl9rPdnfCeXjpbIpbP0h2IGtn0ksbIVNwZQAFvVTvhaBh-oik_-lsvU78vGQTEQ-3zfWIvoSk0o=@protonmail.com' \
--to=pipcet@protonmail.com \
--cc=emacs-devel@gnu.org \
--cc=gerd@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.