all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Benjamin Leis via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Theodor Thornhill <theo@thornhill.no>
Cc: Yuan Fu <casouri@gmail.com>,
	"70614@debbugs.gnu.org" <70614@debbugs.gnu.org>
Subject: bug#70614: Wrong simple imenu definition for java
Date: Tue, 30 Apr 2024 20:55:15 +0000	[thread overview]
Message-ID: <SN6PR08MB532688C0428A4193A37143B78B1A2@SN6PR08MB5326.namprd08.prod.outlook.com> (raw)
In-Reply-To: <87ikzywvnw.fsf@thornhill.no>

[-- Attachment #1: Type: text/plain, Size: 1551 bytes --]

I don’t know if our legal department will clear this or not but I’m reaching out to them. I can prepare a patch for the basic changes in the meantime.  You can see the basic code changes from that reddit post. I’ll rename the functions to match in java-ts-mode.el , look into the sparse tree function and if there is anything else stylistically, you’d like I could do that as well.

Smaller point, ,y preference is to expose records rather than enums and/or make the set configurable in a list.
Ben

From: Theodor Thornhill <theo@thornhill.no>
Date: Tuesday, April 30, 2024 at 11:30 AM
To: Benjamin Leis <benjamin.leis@servicenow.com>
Cc: Yuan Fu <casouri@gmail.com>, 70614@debbugs.gnu.org <70614@debbugs.gnu.org>
Subject: Re: bug#70614: Wrong simple imenu definition for java
[External Email]

Benjamin Leis <benjamin.leis@servicenow.com> writes:

> Hi Yuan
>
> Yes it was me that posted on reddit. I’ll look into the sparse tree
> method – that looks promising.  I’d be happy to add into the tree.
> What would the process be for that?
>
> Ben

If you just extend the current implementation and wrap it nicely in a
patch and send it as a reply to this email, I'd be happy to review and
merge. Remember that for some "significant" contribution an assignment
to the FSF is needed. You can ask for a form to start that process here,
and someone will send it to you off list.

That can take some time, so if you're willing to do that I'd suggest you
get started on that sooner rather than later :-)

Theo

[-- Attachment #2: Type: text/html, Size: 3809 bytes --]

  reply	other threads:[~2024-04-30 20:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-27 18:45 bug#70614: Wrong simple imenu definition for java Benjamin Leis via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-30  5:06 ` Yuan Fu
2024-04-30 16:34   ` Benjamin Leis via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-30 18:30     ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-30 20:55       ` Benjamin Leis via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-05-01  1:10       ` Yuan Fu
2024-05-01 12:00         ` Eli Zaretskii
2024-04-30 18:27   ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN6PR08MB532688C0428A4193A37143B78B1A2@SN6PR08MB5326.namprd08.prod.outlook.com \
    --to=bug-gnu-emacs@gnu.org \
    --cc=70614@debbugs.gnu.org \
    --cc=benjamin.leis@servicenow.com \
    --cc=casouri@gmail.com \
    --cc=theo@thornhill.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.