From: "andrés ramírez" <rrandresf@hotmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 61432@debbugs.gnu.org
Subject: bug#61432: 28.2; [PATCH] viper-init: disable face support
Date: Sun, 12 Feb 2023 18:53:05 +0000 [thread overview]
Message-ID: <SJ1PR12MB6363402226C2186472F16E91A6DC9@SJ1PR12MB6363.namprd12.prod.outlook.com> (raw)
In-Reply-To: <83357ahh39.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 577 bytes --]
Hi. Eli.
>>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:
[...]
Eli> Then make all those faces be the same: default.
There would be more than oneline. And There is no guarantee it should
work. I have tried several variations and have not gotten the default
faces showed when launching 'emacs -Q'
Eli> You are suggesting a new user option? That might be okay, but then the patch should
Eli> include a suitable defcustom.
Yes. I am suggesting a new user option. For not changing minibuffer
faces when using viper.
Attached the new version of the patch.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: mypatch --]
[-- Type: text/x-patch, Size: 995 bytes --]
diff -u /tmp/viper/viper-cmd.el.bak /tmp/viper/viper-cmd.el
--- /tmp/viper/viper-cmd.el.bak 2023-02-12 17:45:05.775987386 +0000
+++ /tmp/viper/viper-cmd.el 2023-02-12 18:48:17.986368416 +0000
@@ -564,7 +564,7 @@
))
;; minibuffer faces
- (if (viper-has-face-support-p)
+ (if (and (viper-has-face-support-p) (not (and (boundp 'viper-disable-minibuffer-faces) viper-disable-minibuffer-faces)))
(setq viper-minibuffer-current-face
(cond ((eq state 'emacs-state) viper-minibuffer-emacs-face)
((eq state 'vi-state) viper-minibuffer-vi-face)
@@ -1923,6 +1923,12 @@
:group 'viper-misc)
+(defcustom viper-disable-minibuffer-faces nil
+ "If non-nil, viper does change the minibuffer faces."
+ :type 'boolean
+ :group 'viper-misc)
+
+
;; Try to add a suitable suffix to files whose name ends with a `.'
;; Useful when the user hits RET on a non-completed file name.
;; Used as a minibuffer exit hook in read-file-name
Diff finished. Sun Feb 12 18:48:25 2023
[-- Attachment #3: Type: text/plain, Size: 14 bytes --]
Best Regards
next prev parent reply other threads:[~2023-02-12 18:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-11 14:22 bug#61432: 28.2; [PATCH] viper-init: disable face support Andrés Ramírez
2023-02-11 15:38 ` Eli Zaretskii
2023-02-11 16:10 ` andrés ramírez
2023-02-11 16:30 ` Eli Zaretskii
2023-02-11 18:32 ` andrés ramírez
2023-02-11 18:48 ` Eli Zaretskii
2023-02-12 17:54 ` andrés ramírez
2023-02-12 18:30 ` Eli Zaretskii
2023-02-12 18:53 ` andrés ramírez [this message]
2023-02-13 14:00 ` Robert Pluim
2023-02-13 15:02 ` andrés ramírez
2023-02-13 17:02 ` Robert Pluim
2023-02-18 17:01 ` Eli Zaretskii
2023-02-18 17:01 ` Eli Zaretskii
[not found] ` <SJ1PR12MB63635DCA5881078AB2D3ED0BA6AB9@SJ1PR12MB6363.namprd12.prod.outlook.com>
2023-02-23 15:09 ` Robert Pluim
2023-02-23 15:24 ` andrés ramírez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ1PR12MB6363402226C2186472F16E91A6DC9@SJ1PR12MB6363.namprd12.prod.outlook.com \
--to=rrandresf@hotmail.com \
--cc=61432@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.