From: Drew Adams <drew.adams@oracle.com>
To: Eli Zaretskii <eliz@gnu.org>, Lars Ingebrigtsen <larsi@gnus.org>
Cc: "damien@cassou.me" <damien@cassou.me>,
"54156@debbugs.gnu.org" <54156@debbugs.gnu.org>
Subject: bug#54156: [External] : bug#54156: 28.0.91; set-face-attribute with a nil FRAME doesn't change the default
Date: Fri, 25 Feb 2022 15:42:58 +0000 [thread overview]
Message-ID: <SJ0PR10MB5488FE222E7E6C3A9FE192D4F33E9@SJ0PR10MB5488.namprd10.prod.outlook.com> (raw)
In-Reply-To: <838rtzqdt4.fsf@gnu.org>
> The default attributes for faces that are used when creating new
> frames are stored in face--new-frame-defaults. When a frame is
> created, those attributes are merged with what the face's spec (from
> defface) says. Thus, having 'unspecified' in face--new-frame-defaults
> for an attribute has no effect: the definition of the attribute in
> defface will override it.
>
> So we need a special trick to override defface with 'unspecified',
> and that trick is this call:
> (set-face-attribute 'region t :background 'unspecified)
> This is handled specially in internal-set-lisp-face-attribute to
> do what Damien wants.
This is likely all documented. However, it's a
bit tricky to absorb, and perhaps to explain.
Consider taking another look at the doc for this,
and see if you think you could improve it to make
this a bit clearer.
(Just a suggestion. Pretty much any text can be
improved, and rereading is the way to begin.)
next prev parent reply other threads:[~2022-02-25 15:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 10:21 bug#54156: 28.0.91; set-face-attribute with a nil FRAME doesn't change the default Damien Cassou
2022-02-25 12:15 ` Lars Ingebrigtsen
2022-02-25 12:26 ` Eli Zaretskii
2022-02-25 12:30 ` Lars Ingebrigtsen
2022-02-25 13:03 ` Eli Zaretskii
2022-02-25 13:12 ` Lars Ingebrigtsen
2022-02-25 13:24 ` Eli Zaretskii
2022-02-25 15:42 ` Drew Adams [this message]
2022-02-26 15:04 ` Lars Ingebrigtsen
2022-02-26 15:24 ` Eli Zaretskii
2022-02-26 16:17 ` bug#54156: [External] : " Drew Adams
2022-02-26 16:35 ` Eli Zaretskii
2022-02-26 17:23 ` Drew Adams
2022-02-26 17:50 ` Eli Zaretskii
2022-02-26 22:47 ` Drew Adams
2022-02-27 7:04 ` Eli Zaretskii
2022-02-27 15:49 ` Drew Adams
2022-02-27 13:02 ` Lars Ingebrigtsen
2022-02-27 16:13 ` bug#54156: [External] : " Drew Adams
2022-02-25 12:16 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR10MB5488FE222E7E6C3A9FE192D4F33E9@SJ0PR10MB5488.namprd10.prod.outlook.com \
--to=drew.adams@oracle.com \
--cc=54156@debbugs.gnu.org \
--cc=damien@cassou.me \
--cc=eliz@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.