From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#59559: 28.1; `minibuffer-with-setup-hook' with :append Date: Mon, 23 Jan 2023 16:38:53 +0000 Message-ID: References: <87pmbmnvdd.fsf@web.de> <87358iuqsj.fsf@web.de> <87edro6jl7.fsf@web.de> <837cxflm9c.fsf@gnu.org> <875ycz7hvt.fsf@web.de> <835yczkt4k.fsf@gnu.org> <87h6wip0ly.fsf@web.de> <87bkmppchf.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32729"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , "59559@debbugs.gnu.org" <59559@debbugs.gnu.org> To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 23 17:39:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pJzqq-00083S-SX for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 23 Jan 2023 17:39:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pJzqa-0007g4-ER; Mon, 23 Jan 2023 11:39:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJzqY-0007f0-Vj for bug-gnu-emacs@gnu.org; Mon, 23 Jan 2023 11:39:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pJzqY-0005vw-Nm for bug-gnu-emacs@gnu.org; Mon, 23 Jan 2023 11:39:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pJzqY-000682-7i for bug-gnu-emacs@gnu.org; Mon, 23 Jan 2023 11:39:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 23 Jan 2023 16:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59559 X-GNU-PR-Package: emacs Original-Received: via spool by 59559-submit@debbugs.gnu.org id=B59559.167449193923550 (code B ref 59559); Mon, 23 Jan 2023 16:39:02 +0000 Original-Received: (at 59559) by debbugs.gnu.org; 23 Jan 2023 16:38:59 +0000 Original-Received: from localhost ([127.0.0.1]:55178 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJzqU-00067l-Mt for submit@debbugs.gnu.org; Mon, 23 Jan 2023 11:38:58 -0500 Original-Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:32728) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJzqT-00067b-4T for 59559@debbugs.gnu.org; Mon, 23 Jan 2023 11:38:58 -0500 Original-Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30NEhd6g015666; Mon, 23 Jan 2023 16:38:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=8E/Bd88uqPkW+huOe99VshCYGFjnJCKI2w/TyGMcYpU=; b=iXiiaDraboBSEuLTzC/4JB3/SUmqYrBB+z+6YN156owEe7NJGpEc9vZ+zl4nSduSe6WU g1gTXtg3M0yB2X0WWX1pkZPrgi6sobpIkJ8i7/19Fp3PInuElXCGzi5zjD3Qy9AQvdD1 UQC89MRG13Aw3Z1j/bThbjskfqfit7toBgm0qUFZqCHo/yrB9UDyE5Vm0OM32TD5hzPE dj5Wtkgvj3+0xRrcy5DcKc8JE6+h6O0ZC+D9PFqlfZEpdQq2QefVR5DRi6fce+V3Dz8E YNMg7/k5VG0NK3mMWJ3bRLWgYeLHj9RNee4w4Z1+fw3fsIfIAAIM0Es6d+dz/BHstwJ7 Qw== Original-Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3n86u2u8wv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 23 Jan 2023 16:38:56 +0000 Original-Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 30NG3KjD001139; Mon, 23 Jan 2023 16:38:55 GMT Original-Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2168.outbound.protection.outlook.com [104.47.58.168]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3n86ga1aqj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 23 Jan 2023 16:38:55 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BNsCP2PL3o3CYrHFjtFkB78YMb4rz5bagvBNLXFn3wQB3LMeFDlhvA/ayZbh+Rz9OBMiMC8N96L+C4wOqHXPbiStdQl4Z2V7MB32WajkdqbcIDo94raaaq7ki4JIKut+2k5nUmvrx2xauZYvTzhqd6khQ0OVVmMg/TxWnNbI1F+9LRXlmkdIve6BPhcW1MnQYReX9kRSiXtYobZDiLQiL+G6dhlpBCrT842xDQuPWTqHw0M9aEYsIH3XIHn7sJJ/8H7gY09WLcH+UzW4PNpsfE0PaImztv33am0h6P/FTlHKwctYziKoSktCOE2vcyPkxYtvkIHl9H9g68aMqk0L8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8E/Bd88uqPkW+huOe99VshCYGFjnJCKI2w/TyGMcYpU=; b=AY4QUcpq9gkF1a/PIaYvIhzv4/UMVJoiw6ozHD3wCRRg66L3ilo3n0euQgmphqkj45H/CGT+eGRjHsvSPHvUimEAXeIxiNQLMRHtnqjsw3ZtmLBHpm1PVj8+POCGo0/lsZ2hOZMylB872SeWAFgwHj7Ln2L57qt7Tiz/sM1WRTqjfBiAZgJd/kuAgsikkIu71yb9MPDuAcg/u2XJ+mmgA0SYC400RPv+1qqBafRZiemB+Ijy76XrvXD4E/xFOYEla8sZtIEZrpAPpONVENrCK+UK3p2BuUv8k6XBSKnOmvYm7nh38neO7WyQU+5TIeDtxUsb4LA5nSzZfCd1BTxRwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8E/Bd88uqPkW+huOe99VshCYGFjnJCKI2w/TyGMcYpU=; b=slAm2qGuNFBLwMDfNhP7oO3BvslW739P0CsLhPaKFr/h18wTJFHASxGNNvuFiLit9wXcTuqfvW6cqN7PERALzH0ROmNIWVMX75TlBHJMpWd25tkNkrfh6PjJEdaEpYpKDxFBMtTGmFV2/5zqOpEkkmJwxoxEp5LjdsrJeR3rBFY= Original-Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by DM6PR10MB4233.namprd10.prod.outlook.com (2603:10b6:5:213::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.14; Mon, 23 Jan 2023 16:38:53 +0000 Original-Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::7c3c:e53d:5276:ef29]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::7c3c:e53d:5276:ef29%8]) with mapi id 15.20.6043.016; Mon, 23 Jan 2023 16:38:53 +0000 Thread-Topic: [External] : Re: bug#59559: 28.1; `minibuffer-with-setup-hook' with :append Thread-Index: AQHZLzSZe0hO63hDyU6x/T2jvoSoya6sLj4A In-Reply-To: <87bkmppchf.fsf@web.de> Accept-Language: en-US Content-Language: en-US x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR10MB5488:EE_|DM6PR10MB4233:EE_ x-ms-office365-filtering-correlation-id: 7dacb4ad-abef-4d9c-e113-08dafd605097 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: M3cQRl83MnpEZBhOBDlLvD9uK/zmDWv6N1+L/coMaTNnm2d0yhmwE/RveenSN7N6jqKF1F7UD3CKvgXDaIMcu1KGQ2qeRR5qWNR1fqpMp3yI9DTMCXS8KnnzK+hWzAP5av1fsnYHhGfcC/KT4rjiNr9AMQ80JreZL5MTEXguv5he5K84N4Kwm6pBPNBnT5ZMqak9IZD6vgs7e+bUZcPem1j7ZNbZfktNWqKyxW1yWdef8I8rQjjDXN7M6DKIP+I9L5XolvbmSfQiRdo/UTpCjao3gQJCHgKNEcjgy9/VJADTxuW6plcyxzNVJA3f/R27OF/cr0fieKSMtjPVzBn1bwD6zgoa7k8KcHfyjp+xzsefJsUr8THrahDVtJ0s03hq6sEb+A9cvZlmF/U5g6I8yj8lZKiptZXXfswjK9MRFc4A9r0xD5Qk2JspdhF99tU87aJyoadUHW/bPuIkJ6AIrP7kpyHQoRp4wD6/LBo+cRTu2vrLRTpMF9qX44uPnqczNRmrwlMIltwv10lPO05mfYqNIltvBYgKVog45ihgTospaaBRoxKKkmKQQTJjGs5M+5YpdeTswiJWgxVdXm2cHi9Tg8hEtjts6WbOaT+DZR6nB3dx8Lv0nx0hs/4Ai/izzs4XueMSuczm//IzxWel5zMRvxbd8OauNXx2XiCj8AR95Pc/18rG9SzmQ4LQi9YzRdgD8zPSSLzI71inYuQIyR9rhkUiyc967HHG/G79RXY= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(39860400002)(136003)(376002)(346002)(396003)(451199015)(86362001)(66899015)(26005)(6506007)(9686003)(478600001)(186003)(7696005)(71200400001)(55016003)(2906002)(38070700005)(54906003)(316002)(38100700002)(66556008)(66946007)(6916009)(4326008)(8676002)(64756008)(66476007)(66446008)(44832011)(41300700001)(33656002)(122000001)(52536014)(8936002)(76116006)(5660300002)(81973001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: Q3aD+JBgXQMcVq9SH4w7gxhDYCH2hUVV9naJjYmpqIWK84Oc/8OoDscf7WmmhrJulvDGwHFR9aQqdPuJsq7pywaWXhN6MuUeF40UfSYyTMbi4cOarC1vneiI8SF5bJxRJGw1yPUcSGlhTRVzU1iqTS0MoWqDMXXYF04UCE94vToqkEqsJ0jjYuF67zmWdMr7tzMsHMeMVlDSJNdO9IqqGTOZaDZrW/qbdBKqv38bhlTYfJRFTuT/SWAttV6NxlrLiXbsbYHXK8m3rf6uxwvmxPsGvYQsHawNuQ4exrIEFt2FnP6M1cccD1hkTmrX4q8mWmR8YIFIJFhha49WPM+lopo8Wr39WdpauuxHakO40ppQsGzbYFncTlmeQ9redbAvkKh1I+JGXy9u9X7BeVq65H1OcibAdzWYAnH8e8wVzZlJmN218ZHFLt/0GAL95RvM/YQ8I4ctjLP7pOSgygN8iaaWGNtZiSIWTJ5jeyVTixi6kshwXB2zS20/sG2NKJLw1h+fLp6ZTkcAkaSxrzfqnxI4UnMgcYKgDinmvT+u+sqdy/b4E2N16ITUYkVDTOui9Tq3MwoqlP+Xu4w54SrEAeK8iEddDwHK6+oP+gJLxp/PcojiIV9skTkrdLzty+Cgv71l7Kc8Z8Vpyjnod7ENC00tWbPAfD1JiFlZ+BFOzyCTC/du/3b9jlm2nfqio6iC4RVFhWt/z/U2esInSaQyHkPnKriLNz+JbmmveKC+WPqNWX2/4fiN2r2nOF JLE3+q9LFHmJyiGW5CQTtuFqj9JLMBBGspEOeiHVAnUmxh677lxL+xF8t/Xnb/LTo/viwNDQ80+9n8EXevfEfajYGRh8svftEo X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: KgZEuJRAHjXOcc7DeXgvlKGa9RsO8L5EcAD44pPnOmHnKG5fDXRAJqwmJ8PMGLa7MTey5N1Ql+Z8M2a5fC9mUC31HCkWW8bTszJAh3YnFj+UI5xVEtk/5s4xWRAbHp0NdLIEMswYGDVGcqYv18cdNs1qByI41rHKK2kVroHFu4VTvFuKkQZlv+bxvMk+9Gg+xwMhUgpiSsPBNas1v7Sm52HenOp8xsvftvqetlDIgoK/enVIkCjRc0+dOJbSDaihupjihLmskvu60FrnZXX0nv3z/x3SF5by+3Uz5u9KgezPXXWcvJDvURGP6l7S8FziNiGAFqOANj1XgZkWulfiBMAqWVA3rn88qbkD3nW1072TLym3sbBCgLIQzxx07ImroCbmK842vlS6YFADBdSn9W8gVKx4II02zz3ZzicoXiQTsELItUDenu5U/e+oij8vdQuf4KNSYqdyeYChxxcGgEDTF5vsUA5kZaVVod3InafaxSMCxukbx2A4GXHPO0wa2eLr5wpqWURlwqA7CdP2hLPkGD7ShLnrZoasPU9GCcgQUvCBSZnLykjRsWXSzhbzB3FZuD5iMqqqtSb4jJPGmKhLFx4MU3Pb0XYoQWwMnTfwN4059Az1MCJTyTTN5ovk8T4PHWPQKXM2X/7UnrHUriSJ0WvWepWbbKy4PiAMDm0RZZjOobumYdw3HVoTNEo5KfDjn8mo5pSdQRVxiRFQVa+GW8o0XLjbRzkDO1pN/CNGF9 32jSQifem3V9bgQa4F9jW4ZJJkyPzArYtKHKhpAk71FGH2M810XbwgVTDB3QE= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7dacb4ad-abef-4d9c-e113-08dafd605097 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jan 2023 16:38:53.7008 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gwxF7Jrgr6eys8T7EA4hK8HqQR0xnmCeTQjU0fx2SmZ0YrIJaeOIZkl1pQwq6oNmWJPDRsUyYjJEbdABTnNXtg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB4233 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-01-23_12,2023-01-23_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0 mlxlogscore=289 adultscore=0 mlxscore=0 suspectscore=0 spamscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301230159 X-Proofpoint-GUID: 0EQSIYEgTAowMrMk6UrhScnIMRSkad4m X-Proofpoint-ORIG-GUID: 0EQSIYEgTAowMrMk6UrhScnIMRSkad4m X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254013 Archived-At: > Drew, thanks for your elaborations. You're welcome. Thanks for working on this. > I don't have a strong opinion. I can follow your thoughts, but I'm also > not really convinced that writing that all out in the docstring is > necessary. >=20 > So I would like to leave it up to you two to find a final agreement. Eli has now decided - apparently it's "won't fix". FWIW, I think this kind of interface is inherently problematic (for the reasons I gave). It's not similar to, say, `add-hook', where APPEND can be an optional arg. (Nor is it like CL keyword args.) No one has any trouble understanding that a macro like `with-current-buffer' evals its first arg, so no special need for the doc to point that out. If this case were like that (and others, similar) I wouldn't have filed the bug report. It's the use by `minibuffer-with-setup-hook' of the same arg with two forms, and with evaluation not always of that arg but sometimes of just part of it -- that's what makes it problematic for the doc to just talk about FUN being a function. IMO the doc does _need_ to talk about how the arg is handled (evaluated). FWIW, I would have just had two macros, instead of fiddling with a special kind of arg: 1. `with-mbuf-setup-hook-add' (or `with-mbuf-setup-hook-prepend') 2. `with-mbuf-setup-hook-append' That also uses fewer chars: (with-mbuf-setup-hook-append #'toto ...) (minibuffer-with-setup-hook (:append #'toto) ...) Even if "minibuffer" is spelled out it's shorter: (with-minibuffer-setup-hook-append #'toto ...) And starting with "with-" fits what we do with other, similar macros.