From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#59745: 26.3; Rename `string-collate-lessp' to respect the convention Date: Thu, 1 Dec 2022 16:19:31 +0000 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8133"; mail-complaints-to="usenet@ciao.gmane.io" To: 59745@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 01 17:20:20 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p0mIN-0001vq-Id for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 01 Dec 2022 17:20:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p0mI9-0008HY-5O; Thu, 01 Dec 2022 11:20:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0mI6-0008HN-Sz for bug-gnu-emacs@gnu.org; Thu, 01 Dec 2022 11:20:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p0mI6-0004a6-IM for bug-gnu-emacs@gnu.org; Thu, 01 Dec 2022 11:20:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p0mI6-00036J-3O for bug-gnu-emacs@gnu.org; Thu, 01 Dec 2022 11:20:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Dec 2022 16:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 59745 X-GNU-PR-Package: emacs X-Debbugs-Original-To: "bug-gnu-emacs@gnu.org" Original-Received: via spool by submit@debbugs.gnu.org id=B.166991160011907 (code B ref -1); Thu, 01 Dec 2022 16:20:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 1 Dec 2022 16:20:00 +0000 Original-Received: from localhost ([127.0.0.1]:40620 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0mI4-00035z-8V for submit@debbugs.gnu.org; Thu, 01 Dec 2022 11:20:00 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:54502) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0mHz-00035s-EU for submit@debbugs.gnu.org; Thu, 01 Dec 2022 11:19:58 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0mHp-0008Ex-5q for bug-gnu-emacs@gnu.org; Thu, 01 Dec 2022 11:19:53 -0500 Original-Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0mHl-0004Wq-4W for bug-gnu-emacs@gnu.org; Thu, 01 Dec 2022 11:19:44 -0500 Original-Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2B1FBlO7026344 for ; Thu, 1 Dec 2022 16:19:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : subject : date : message-id : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=2wC1FwEDz07McONxgFl55G/kMVIl4vjcHkSmVjagM98=; b=DlpjsxJzlrKzTP9HKNRTS5BEq79Jfzp9SZJKUI+/Ik4X3Nm/0Rr22QwkYtctvxaFTKse CAlACCHdWb4v3svV1pkpjw3EjQ4lf8M0Bgl8fjGEN0oB3d4vdI58V7bQChVjmsvRKBV9 05+uiPG1BDWTobUBfKS7xONuhqSCD0WRSokKc02zMu8o6KGZC5w+iVJP14yop9tovwT6 U3V1NxIgtIRCROOZrEaVCuehVDvyYTGO4vOLqm3HA7W/j5HF9EWPNBW0iO85oXzbEKjo JoGtL5YToVZRFyCsIL72ueJK/fhCMvV0PsRIj0oMBrMJJ8i+z21he6SOwam23H3kIpBX ZA== Original-Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3m3adte2wq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 01 Dec 2022 16:19:35 +0000 Original-Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 2B1F3pXa036630 for ; Thu, 1 Dec 2022 16:19:34 GMT Original-Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2048.outbound.protection.outlook.com [104.47.66.48]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3m3c20eyc5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 01 Dec 2022 16:19:34 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bIbnxJqU66fcA2nPJSilKM57ZP6SLGxOQSks4w/Gk3ZT4G56Gv3HskpY5TsMnBN9eFqljnWMG17QUgRYN/rXa2SqYSBPL7HN3S1KNKNYQGGnyd/YlRhCqjcml1Atfg/vFMpINyvrOYOcqSEEocbJTeDLHttASF1hJVCknE6cCnoazEPz6Qnqkt7TsurKajfUwqYXDDv1I8k+nxrNapsWSSQDJQo6YVGHZ6BCgffm7BoVo5lc4r2elf7W35NnEtJgb7tSStgkXmUcFgTXfOVugMkaOHOjm4RYdKnfeKPK/zth2Xb9OxUalN5PEy+Tlqi8n+vf8H1h60zXjjpcsuS4mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2wC1FwEDz07McONxgFl55G/kMVIl4vjcHkSmVjagM98=; b=Wbh9gVCJAlNMVi5mxtzkMu9M+aHnUPOYiO0JP+VNUItqGbaT3XX7nc9LCZRLwfpyOJY+A8O8fhZBvHDEJ5VX/R5vASxkPK/1s7wbqzK61aS1UxCFJa55ZfuoJd6v2QJuYt2Ft8fC+oXwTd1tEevX6oc++aTTT1Kzl+RddaUkRw9X5IbEiUnn/q++fxoBKQXgHs6a0QjM2w9gHI9v0Y6o5tMzfJJIrRf9mcd+DVedl1cJuakPpu/JhLvPRS3GXSO0AW7k3OtaQhc7a1j+yy4vcCbDEgUBGPLr76chyKC7gdxs7Z+cEzY+7fuRlvwWtdWUrFqOtapZaDvnYpVWjgSDwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2wC1FwEDz07McONxgFl55G/kMVIl4vjcHkSmVjagM98=; b=JxbwZSewJXYd13h/GFk/kbzSyTpr+/fULSANuXRxj6aPJoPOMUXsxD3/q/mG4AhjLUCnExUu0uI1SfiG7Djm1iQoD1X+N505Yd9RFKMZ6MEHsU8Y4euCuKsE1lacUY5zVbp61qbIvPYGfMQeaOgfcMOYq2ic2Kji7O1QxkdHC10= Original-Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by CO6PR10MB5652.namprd10.prod.outlook.com (2603:10b6:303:135::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.8; Thu, 1 Dec 2022 16:19:32 +0000 Original-Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::6951:297b:f3d5:2588]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::6951:297b:f3d5:2588%9]) with mapi id 15.20.5880.008; Thu, 1 Dec 2022 16:19:32 +0000 Thread-Topic: 26.3; Rename `string-collate-lessp' to respect the convention Thread-Index: AdkFoIpOfNAAJF1fSwa2qamvVI1mVw== Accept-Language: en-US Content-Language: en-US x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR10MB5488:EE_|CO6PR10MB5652:EE_ x-ms-office365-filtering-correlation-id: e9bb031c-d994-470a-d0d7-08dad3b7d445 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OCQ/2rYusi9b+upFCSAN1qEZym5nX/0Lu7P7jR8wYztXByWcU9HqBTpjOk5/nin9rQYeNDrIJ1Qao78vFazQeqQIYZlOSnhK5d+q8DLWZvDC1s9tU514RkfY6EBbOrFuVXEVVXPSDNkUrnJJ8OJoY6EeeVXuinVURSIZejKT9zwl2FJTg8Zg1nRghzIslTc+QtBynUJtkwUK5y6lbTGNjJXsuHeyGKEJOkl9+AK8ZxGgdrh/9WHHnkBSqQO8PhWbfnDbJERgAtdpzhOFChuh7PljiHMq8ltEyHqhhp4fhLeRTSqxceKJA7RhjzUQsKQXwkkFh2fK1kMv4/p1phyduEk/lHbq4g1zeo/Ye3cEIKetfsm4nMAKDVBvAVjynhLRiPfqQY3eBskaRU8i/7LgzZgC9vb2y4lYO/myHBG7uumL9Q5bo4IYJ1HcnVxBmqnTcxetjanPi52NtAmpZ2RXH156atgmQQ9B0AoQNSYGOXc/Kn2craRg43dcaS0ah398EoBGO6tZuQo+4qTP6LQ1GR5S/xdNfmeQI4VTJLAvytby0VUPh1J8Gvp8YXG4EIAZNp8CySZHC9jVEKTeQzeXU6dUP6n17bH2NVs1ufQGSpKwL3JmrkLBcIh/I1S5TwQeKQt7flZXNzHnpNXA9/OxBdtDlwA3QfP80Fj1Q4ERmWApbz2Ws/I1QOmLh9VbJxsDKDzSbCVyK7bvuBNb5YptwO5gFlPnmlpBNQomjzfBC88= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(346002)(366004)(39860400002)(396003)(136003)(376002)(451199015)(33656002)(316002)(6916009)(55016003)(86362001)(38070700005)(122000001)(38100700002)(7696005)(6506007)(26005)(186003)(9686003)(2906002)(44832011)(4744005)(71200400001)(45080400002)(8936002)(66446008)(5660300002)(76116006)(66476007)(52536014)(66556008)(64756008)(41300700001)(66946007)(8676002)(478600001)(81973001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: bJ0xMQd4LYev0V0qDGAKnQ5B/Ga60d5PfBkuWKjSmOgFMPwiwcAUCEy+bU/5L+HY33DkoldhpV12QRTXHgsgz4ifMh0gPOC82Jbm2GQXIM8gFrLkVbv1gjXDHnB9ExlMREIkD57AuUa4bhxthwwaug2QHTKP24BbdXmALc1HxYQPk//ADY6jCy/voE3aE52Yd1Fjij0AOdcvurDvKcV3TBqd8hHDveXK5gVWpv6YjzmM8ARqWbXY7lZ2JxgYFdQiwd4oCUUyNDjGPV2zKDkyRTTh/JR/rtS+dMOZm/hkLOJmeU6wR50UPbE3QVIsvffe4p1MEJu2HhwwXXSfJ72oBzN4u1gyH4h2+l22qCIOyBCQbv4ZZrjg5K+XjKxAaDyufNhdYvIcRP5HVToGeuAodTV8exsY2lyGj4EZF0h5L6W3ogGeHK2dUiSOlNOwyG7G1Xg2iMMMg4TCqMRr/7Xn01hTMW8T7Sbl66fJmEjmARmWugQu7hM2dhHKNQDFAUUT8VFrbKhqGuu+/f8suK77bz+fJcJDKzhpfbiszC7vR5/bnK3rAC2Ncsl8xDIJ18ZQtaUn7N8vCUW2p0xu9zbUZLcWRMp8W4Hzs2ZFLUXy1FssmTqAgYhT17FaiV67ff5nrpgYXvtLyCsI/b3ZTOdo89rcqIjtsQgLCE0hC6neL/WswnFI/o/DpnBotTD9jSbmtdB3bCLN1Z9s5/+tmyuIcbXx788xAITBpDD3Y/fneCCpycHH/XThuVkmuF DrW3960MNO3bnQm4Kl61tzksQ4ni5Xl8LoKNB1sHyTIXDakwvuXZWz7WPzK71jvsGGdt092eF6c9XNyDmfRYZ5IxiJNeGWrDJE X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: MzZGYUHI1+SytvfV0o5QtnaZCf4hwpoYy+x/KbcDnzcPlu6Z8OBrh+wJmPNh+mreG0iIcJVE+3jShZgZu6mC56ZUXLvDcBRUf6vpnq3TpuWwdxJq2qT1SwU+zvn67axVCp9TFkQ70JgeqZsK+uPPGtaad9tItfcUGKWS7svrbrd7lCdOj/XfTzXu3gQY27Wt9ygmsdNltmLT/FY7e1sGoXyyJ3OloYFskX8cZnBWTSz0W/43HTnGTYHk6euKjQiiYep1X4Kzu0uIGprDnnRPenEZB7ttY3ORjWTMc5Ai8GOAvpBI9IHVqwJXMEW7KTUnbMiwFnc/vpYvWVHOVDOWwZUxvD52Y9W0mJoAf5UogWQYepnO3S45ivTtmkuv84fQXM6v2bE6QDgNvlzGVJJVnRQrtHYGOpS3O2mxbpT5+6YUG1s6rmJNsJwVZ1nqCDRKVVegmNJiI+BSFboVzMQuNn+oWxccQLlu/eKXmTVLWoLQrkjWLWTSGInU0gAu1PIQuvj1B7jgJhym4xsQ1U2A7z2250qH0mquFzU/gt9k04/WTLYHZpr60TpabTXj3nBPH2VGE+QrwP8c50SFv7V0TrHViyGj5O6PSlh8G47dEakE9Wz7YhJV0FnbJzqKFlBwcVOg1VXqwd7UfABVoUDIf8YbZ9VatAObu+dDkkMS0IsZYLQhQGlx+76cSICaBGlKqsLx+ke2L+fJPtBby44nRerzG09wztZrKAo5/P8mRofPwm 4WREt81zq/jNnZQL03 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e9bb031c-d994-470a-d0d7-08dad3b7d445 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Dec 2022 16:19:32.0011 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 95wtt7vvRwIhJ5ZM8r/4BlPqMmfaiyPhAng6B/l2UdDfLnfsaRTpff3r9sRGBhqoRyXrDb3dNUDCvCs+eRWcSQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR10MB5652 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-01_11,2022-12-01_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 suspectscore=0 bulkscore=0 adultscore=0 mlxlogscore=900 malwarescore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2212010120 X-Proofpoint-ORIG-GUID: XRYXPyMU-T3HHeGkrWlfDomV5I_5x5MS X-Proofpoint-GUID: XRYXPyMU-T3HHeGkrWlfDomV5I_5x5MS Received-SPF: pass client-ip=205.220.177.32; envelope-from=drew.adams@oracle.com; helo=mx0b-00069f02.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249649 Archived-At: (elisp) `Coding Conventions' tells us: If the purpose of a function is to tell you whether a certain condition is true or false, give the function a name that ends in 'p' (which stands for "predicate"). If the name is one word, add just 'p'; if the name is multiple words, add '-p'. Examples are 'framep' and 'frame-live-p'. `string-collate-lessp' should, according to convention, be renamed to `string-collate-less-p', no? Every such misnaming encourages others, as people tend to base new names on names they see for existing things. In GNU Emacs 26.3 (build 1, x86_64-w64-mingw32) of 2019-08-29 Repository revision: 96dd0196c28bc36779584e47fffcca433c9309cd Windowing system distributor `Microsoft Corp.', version 10.0.19044 Configured using: `configure --without-dbus --host=3Dx86_64-w64-mingw32 --without-compress-install 'CFLAGS=3D-O2 -static -g3''