From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#67053: 29.1; Doc string of variable `dired-use-ls-dired' Date: Sat, 11 Nov 2023 05:53:51 +0000 Message-ID: References: <87sf5c7v4s.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31894"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "67053@debbugs.gnu.org" <67053@debbugs.gnu.org> To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 11 06:54:50 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r1gxG-00083I-4P for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 11 Nov 2023 06:54:50 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r1gwq-0003JV-33; Sat, 11 Nov 2023 00:54:24 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r1gwo-0003JH-Pf for bug-gnu-emacs@gnu.org; Sat, 11 Nov 2023 00:54:22 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r1gwo-000461-HO for bug-gnu-emacs@gnu.org; Sat, 11 Nov 2023 00:54:22 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r1gxS-00057M-B2 for bug-gnu-emacs@gnu.org; Sat, 11 Nov 2023 00:55:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 11 Nov 2023 05:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67053 X-GNU-PR-Package: emacs Original-Received: via spool by 67053-submit@debbugs.gnu.org id=B67053.169968208119635 (code B ref 67053); Sat, 11 Nov 2023 05:55:02 +0000 Original-Received: (at 67053) by debbugs.gnu.org; 11 Nov 2023 05:54:41 +0000 Original-Received: from localhost ([127.0.0.1]:51343 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r1gx6-00056d-J0 for submit@debbugs.gnu.org; Sat, 11 Nov 2023 00:54:40 -0500 Original-Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]:31524) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r1gx3-00056U-Lt for 67053@debbugs.gnu.org; Sat, 11 Nov 2023 00:54:38 -0500 Original-Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3AB54E4Y005196; Sat, 11 Nov 2023 05:53:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-03-30; bh=SLRpesWnMayRVcf5R2YHBs1zlBbckW+Y3YIDpj4YFMk=; b=S4R0ueROqBhkcUjecockfwD8kIR6FbRy/DQSGopE+dNYll/54IafVOAT8O7HWtDmuXWD vGz/WcXbaYLD9x9sTQT+qQfw8DMULgKY+/ZoCNcBo/jI7Lrudcr8CfwB5uiUmnVV+S2y 1b5iFxn6eW+5CmPHqqSjZpUGKWNX+7FC9MKm9jnuE6jhpYqYXPJbg3VoF/Tn8uorY0Tm EQ2DK8EF5J2KeHev8ohCIPwjE7CURdiXgQ/PIW/rjfkqvZ8AHXuNPR9dWoLP9uooRN7K 4SRDlItE34kwOHkRZM+tnaA0WUK7tld1dYI5dzYAV3WKDBoyGI5Dtl021eIpmC9M2TYT iQ== Original-Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3ua2m2819j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 11 Nov 2023 05:53:56 +0000 Original-Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 3AB4IXEJ017590; Sat, 11 Nov 2023 05:53:55 GMT Original-Received: from nam02-bn1-obe.outbound.protection.outlook.com (mail-bn1nam02lp2041.outbound.protection.outlook.com [104.47.51.41]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3ua022cjvc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 11 Nov 2023 05:53:55 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=alE3s/m3mVGhUtf43QDeNYRLVoOCAy4dtUt9moRgww6NZn/bOVuGiMEpIhCz2FVv3C1fZzQumSWOocM9/KvZpMHXacB+TZqDrAFPWgaGdHaSkbDISVV/La1EDsx/RVGiWTrcp3KeBbydAIjVEUNYQYzHFdsBfRxFKUWA6vV4KGCcgNAvflDx1zn9q8McdVGhbmjcwYT/nFPjCoeO3o8XCiOduo1Xfi+sFeG5YFHgQewO6iQjXAkqEqKx+UM62COEqOED7tysR0CWCnAOkThAHjqyazdgdIyZEKEFpxxaGcefaaeB+9s/oa0vlvKLUauoD5Rx8NkXv1t7lEsMrvdvQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SLRpesWnMayRVcf5R2YHBs1zlBbckW+Y3YIDpj4YFMk=; b=WLlBLedVsZJ8bfPZAqzopbxB1rxKcJQE6f4kh+8pF8ly94AFfMfA8xZ8f82e7lkITQAEXEewIjPojk7OPFp+UO/xxC/Ax6bVXbsrwYUlzdeq7KkWR9EGjoy/P8aZsycP81R9b4i7ZIpBUQmmYDuzcr0AuGw1oB5RTvlm6OM2rBU9aEKPeh1s0Y/++WHMTOlx7hhXDnOEOlfVkYz0dUrF8fnEn3upMZg0lOq0opdvWv/We5W6y1CcF2gYwVe0rIteBhxSS13nmjmyiNq5hgxIOdSrWTfalH49Ud26Rsn+bZTB1Pnj3NQJwVdrYkZJfmHx8rJEfCpry1gJGCldw7gQCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SLRpesWnMayRVcf5R2YHBs1zlBbckW+Y3YIDpj4YFMk=; b=S+ukQKs8ha9MTF8a48keH8ITt5RAbyq+Zpl5kJr1yVnrVhy4FphXFwEUZjeLl7RWHgqWfPE8sswhDmX8wzS41OMoOA6J8f6Cuj70CQTFURq3Nd3ItPelSQAO58HsC7M1V44/YvMfg6SJ330MrrgbxcEPE2nihh2M06ytxmZRo48= Original-Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by SA1PR10MB6663.namprd10.prod.outlook.com (2603:10b6:806:2ba::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.28; Sat, 11 Nov 2023 05:53:52 +0000 Original-Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::3b4c:a669:c229:47b4]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::3b4c:a669:c229:47b4%6]) with mapi id 15.20.6977.019; Sat, 11 Nov 2023 05:53:52 +0000 Thread-Topic: [External] : Re: bug#67053: 29.1; Doc string of variable `dired-use-ls-dired' Thread-Index: AdoUFcw1fjQHwBBzQDaFxUcSDtefYAARIxIUAABSTOA= In-Reply-To: <87sf5c7v4s.fsf@web.de> Accept-Language: en-US Content-Language: en-US x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR10MB5488:EE_|SA1PR10MB6663:EE_ x-ms-office365-filtering-correlation-id: a0293d94-5f92-4106-7bb6-08dbe27a9534 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ze9p8ZuYhVE3Fq3WElGCybjDTr7OlLofKd3OST+1dtM6TgbqXtnJihobixjIzXXU6thEcgTKwVXxQWxW8tR3PBdP4dnS96xzCKdy7AZKMQWYwL290tej4O4+5YL2vMXsW3RWl9WDqC4Oy35Xx79QyuEeyQFU2Pdo/6KmuUJjOM3rxvjkyhMTiKZZ2Zgs6ZXoLdUbtm7yagkjVky/mvKSoRRpbXVNBQ96lmlRCkkb3kOx+LGAgrOMHs/PZ9eIpW9TVrjrgMPwEuwKcsgjtAX5/H79LPoF2hU24Wr5dqRKwQKkxClXM6Dio0w73PXjzrw/oMVah2r7gmXxIMQMiYW1TL7apBhLhsHwRE1LgTFtWuAWHnqgguWxmrodcuzM44d94V5vZl0wn6oSeVyoJmt8CG09OTUVB1w2IhLnQoXD41ZJeNAP4Sd75+Jc8ZJ3hdIzqWOSKaqd/8ttZKiQR24uA8lP03Hj1//G1e0ldQK7BQRbqUh1P1fz/m53OaazRUI0ciuwSUdplEHZ+Cgma/Dhp8pW0aYVmGcuyyH08FusmOmgN3Z7cRwlZSCk844wn17B+6pEJhNNxQasAx48RRZWz/C534D5ZoxKUYtl6FovkB5fO/qjnwSaAgXbbqUOj+j2XCa9ZMxDUnGomCraRUG6ag== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(346002)(366004)(396003)(376002)(39860400002)(230922051799003)(64100799003)(451199024)(1800799009)(186009)(55016003)(52536014)(8936002)(4326008)(38070700009)(44832011)(8676002)(41300700001)(86362001)(316002)(33656002)(2906002)(76116006)(7696005)(6506007)(38100700002)(66446008)(478600001)(122000001)(6916009)(66556008)(71200400001)(5660300002)(9686003)(26005)(64756008)(66946007)(66476007)(81973001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: Rpa14jev7KShk/OQRfqDV4Pbrx0Is16bhPz5UkIUWRuTlR8r04pzljClMgcCWAzpdKEfcb5VRYWZ8UN98PPO9ta9ABpkZMso1kX46StoerxiwCsbcr6CwCw76NMe8QI3dF5FVNYP76p6xvXpEWM3NMN8dQQp0NigiLDiAXa/yZpYR9Gi7XNNj1JrORJVGuOmuxQtyRwRInDC5jl1MHG7Fg6fVRj++s2bJtCitXGEhsbwGKVzwE+bzj/RchOw0TneFWLNqmHX3GYIndY1IQueHJhgFM7mkGi9O9/locNjMDSUhT4gwiBhajnetcBWfTYIxvosOuCTRIvzolGk0r/ND4phj2PjHBhbCBnb1U09RD4mVng4nlSCpe9ijdgEXmDYy9IjDK4KwD67TnRRQHPrFHU4YhwvoBCrNqg1bXVbKFbFzmJ7/M3qopwNr02sluYkaGW3zNmF1/aUTBP/1T3OQqivxVLRzi8LixuVLnsBQMRrwdSSNpNXV1U+/86FAoGZOD99+12BZyPQCpNLIHZjSTByEJajopZ60goIs7wlpCDn+AiNyJMT3Lj6qBOmtS8f0R4/59EtuhMbb1SezRsQZmNptYLxTgh/UAnQ2S141ZRpn4AWy2RMZRkHKSZAejoEKEidFbs0kuoDHJA+pBlSY2YfjcCCv1hcaAEtlY7UGcLq/+VZ+UnO6FtAmuqeY9BwgbJ05JKPfmyWOTE/PDZfN1kytwFy3PJmoIVR2QdUgKevbXzgtX6Tq7uwKP 5x7P7WT1GNPxgHOnRbnl/LMAE6t4FSCaUj9w7W6C+5poBu3QVCzK1kBHF6mI82DnkRSIa8G/bPVt2UwfoZwdPM8XtpcSZsCTqw X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: mmGEG2GoeOaVGURCQ8VH26msIIccEjXEmTRUEtysvssJDdju96u5qPL2EGknCn2aYdEg3IXP1CLKBiliUlchoAFUeNa3ehTjOe9QeqgZo/1SVWepJKXmaacA2jPB3vL3CtYAOaXUQoYFl/Qt8H31aGUhOg0HNxQf5B9kQkLqYOk59rNDBCnyZ0PqhmRtIK/6157rLkMsmTvtFX1sMBPWsc0G/IYb3P35oN6CJMYk71OL3Gx81vVkqZ163cFmJVxZ9v8H8VQcHjvU7XrWTFwlIiZVSFX4EQ4hU8VfpDh6C+zpy7IhjIxhTG0/QglC3gbRHvkNSXW2dRvyrsKL1xD8CESntEp4oxiQr2s4g8yO/3S8YAkJMlFW70AkPZTi/zk+S9jnanIJe1Mnljp1+BKa9Oa736dBckyQf8o49jn/JaO7Jjjh7adH8XJviOu3DmvXlQmHMaPirt5zDWHnezaeWuup5LPIH4zIYFqgqtxL64IWwnzMToN5nWdodEpDbDFDTA0s6rPPt8ZWWYClzUJvEy4haLrPmhFdAI7JSoSY5evrRw5apykHG/8l8yC+O1lKhwSK87m6W6ZJVHnYPjoP0w9vFcTedCq6OC3siybJBV6aYpLE71mrJ3DdGey5vd9VWdMdt/uo3H2RlIoMhQAjpM+0z8UmD1/1UuHpAJwcVKkicEf+geS9678M74EpKi2u4heTyUtLGZS8t8ig7ZT4CZnhzi5v1UK9OF8DOV2Z7f0kJg cd3f+fAGNl3Y1tYuHvFYY8djdJ2EfnIbiRztGf6iAJ66ofY4s7vBFV4MSxPLM= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a0293d94-5f92-4106-7bb6-08dbe27a9534 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Nov 2023 05:53:51.9974 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vlIXhX7/+3zd4Bhb9N0NorjMDvVp5B0bKfAyh8ion6gq1ActJpQS/R0OxSZYRRxdmFSbuOBP10w6Su2zYFJ9Ww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB6663 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-11_03,2023-11-09_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0 mlxscore=0 adultscore=0 malwarescore=0 suspectscore=0 spamscore=0 mlxlogscore=235 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311110047 X-Proofpoint-GUID: wX3GG7xDQbgUd-1KIsBYlegPO15Hm-kJ X-Proofpoint-ORIG-GUID: wX3GG7xDQbgUd-1KIsBYlegPO15Hm-kJ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274134 Archived-At: > > Perhaps I'm misunderstanding something? If so, please make the doc > > string clearer to avoid such misunderstanding. >=20 > AFAIU in your case this check is never performed (because > `ls-lisp-use-insert-directory-program' defaults to nil in your case). Yes. > The doc is not really wrong because "This is performed the first time > `dired-insert-directory' is invoked." is just never for you. 1. I don't see that the check never being performed makes that doc, as written, any clearer, or that understanding that doc depends on the check being performed or on function `dired-insert-directory' being invoked. Understanding the actual behavior on MS Windows does depend on the check (not) being performed, but that's the code, not the doc. 2. (a) Yes, `ls-lisp-use-insert-directory-program' is nil in my case, but (b) `dired-insert-directory' _is_ invoked. Debugger entered--entering a function: * dired-insert-directory("z:/foo/bar/toto/bbbbb/" "-al" nil nil t) ^^^^^^^^^^^^^^^^^^^^^^ dired-readin-insert() #f(compiled-function () #)() combine-change-calls-1(1 1 #f(compiled-function ...)) dired-readin() dired-internal-noselect("z:/foo/bar/toto/bbbbb/" nil) dired-noselect("~/toto/bbbbb" nil) #f(compiled-function (dirname &optional switches) ... ls-lisp--dired(#f(compiled-function ... apply(ls-lisp--dired #f(compiled-function ... dired("~/toto/bbbbb" nil) funcall-interactively(dired "~/toto/bbbbb" nil) command-execute(dired) The _check of `dired-use-ls-dired'_ is never done by `dired-insert-directory', because this test is nil: (not (and (featurep 'ls-lisp) (null ls-lisp-use-insert-directory-program))) This doesn't clarify that doc, IMO. It does, however, mean that the part you quoted is incorrect - the doc _is_ really wrong. When `ls-lisp-use-insert-directory-program' is nil, not only does the check not occur the first time `dired-insert-directory' is invoked, but it's _never_ performed. In short, `dired-use-ls-dired' isn't used if option `ls-lisp-use-insert-directory-program' is nil; it's irrelevant in that case. The doc should say that.