From: Drew Adams <drew.adams@oracle.com>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: "67053@debbugs.gnu.org" <67053@debbugs.gnu.org>
Subject: bug#67053: 29.1; Doc string of variable `dired-use-ls-dired'
Date: Sat, 11 Nov 2023 05:53:51 +0000 [thread overview]
Message-ID: <SJ0PR10MB5488D4ABB9C8508B69409D14F3ADA@SJ0PR10MB5488.namprd10.prod.outlook.com> (raw)
In-Reply-To: <87sf5c7v4s.fsf@web.de>
> > Perhaps I'm misunderstanding something? If so, please make the doc
> > string clearer to avoid such misunderstanding.
>
> AFAIU in your case this check is never performed (because
> `ls-lisp-use-insert-directory-program' defaults to nil in your case).
Yes.
> The doc is not really wrong because "This is performed the first time
> `dired-insert-directory' is invoked." is just never for you.
1. I don't see that the check never being performed
makes that doc, as written, any clearer, or that
understanding that doc depends on the check being
performed or on function `dired-insert-directory'
being invoked.
Understanding the actual behavior on MS Windows does
depend on the check (not) being performed, but that's
the code, not the doc.
2. (a) Yes, `ls-lisp-use-insert-directory-program'
is nil in my case, but (b) `dired-insert-directory'
_is_ invoked.
Debugger entered--entering a function:
* dired-insert-directory("z:/foo/bar/toto/bbbbb/" "-al" nil nil t)
^^^^^^^^^^^^^^^^^^^^^^
dired-readin-insert()
#f(compiled-function () #<bytecode -0xc727057c68a81bd>)()
combine-change-calls-1(1 1 #f(compiled-function ...))
dired-readin()
dired-internal-noselect("z:/foo/bar/toto/bbbbb/" nil)
dired-noselect("~/toto/bbbbb" nil)
#f(compiled-function (dirname &optional switches) ...
ls-lisp--dired(#f(compiled-function ...
apply(ls-lisp--dired #f(compiled-function ...
dired("~/toto/bbbbb" nil)
funcall-interactively(dired "~/toto/bbbbb" nil)
command-execute(dired)
The _check of `dired-use-ls-dired'_ is never done by
`dired-insert-directory', because this test is nil:
(not (and (featurep 'ls-lisp)
(null ls-lisp-use-insert-directory-program)))
This doesn't clarify that doc, IMO. It does, however,
mean that the part you quoted is incorrect - the doc
_is_ really wrong.
When `ls-lisp-use-insert-directory-program' is nil,
not only does the check not occur the first time
`dired-insert-directory' is invoked, but it's _never_
performed.
In short, `dired-use-ls-dired' isn't used if option
`ls-lisp-use-insert-directory-program' is nil; it's
irrelevant in that case. The doc should say that.
next prev parent reply other threads:[~2023-11-11 5:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-10 20:41 bug#67053: 29.1; Doc string of variable `dired-use-ls-dired' Drew Adams
2023-11-10 21:38 ` Jeremy Bryant via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-10 23:40 ` Drew Adams
2023-11-11 7:14 ` Eli Zaretskii
2023-11-11 4:48 ` Michael Heerdegen
2023-11-11 5:53 ` Drew Adams [this message]
2023-11-11 6:43 ` Michael Heerdegen
2023-11-11 8:04 ` Eli Zaretskii
2023-11-11 6:49 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR10MB5488D4ABB9C8508B69409D14F3ADA@SJ0PR10MB5488.namprd10.prod.outlook.com \
--to=drew.adams@oracle.com \
--cc=67053@debbugs.gnu.org \
--cc=michael_heerdegen@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.