all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Howard Melman <hmelman@gmail.com>,
	"55086@debbugs.gnu.org" <55086@debbugs.gnu.org>
Subject: bug#55086: 28.1; Improve doc of set-fontset-font
Date: Sat, 23 Apr 2022 22:07:38 +0000	[thread overview]
Message-ID: <SJ0PR10MB5488C7DB5D659AB771666FB9F3F69@SJ0PR10MB5488.namprd10.prod.outlook.com> (raw)
In-Reply-To: <6AB2E8A8-06E9-497D-8204-C4D2BDEA06A4@gmail.com>

> The eldoc string for set-fontset-font in Emacs 28 is
> 
>     (NAME TARGET FONT-SPEC &optional FRAME ADD)
> 
> I found NAME and TARGET to be unhelpfully generic.  The
> docstring does say that name is the name of a fontset and
> that TARGET is about characters.
> 
> The elisp manual names the params as:
> 
>  set-fontset-font name character font-spec &optional frame add
> 
> character is an improvement but it should be plural.
> 
> I think they should be the same in both places and
> this would be clearer:
> 
>     (FONTSET CHARACTERS FONT-SPEC &optional FRAME ADD)

+1 for that renaming.  (It's also OK to use just CHARS.)

The first doc line also doesn't really respect the
convention of describing args in order.  (Not a biggee,
IMO.)  That could maybe be remedied also - perhaps
something like this (67 chars):

 Modify FONTSET for use on CHARACTERS so that it respects FONT-SPEC.





  reply	other threads:[~2022-04-23 22:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-23 21:51 bug#55086: 28.1; Improve doc of set-fontset-font Howard Melman
2022-04-23 22:07 ` Drew Adams [this message]
2022-04-24  6:57 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SJ0PR10MB5488C7DB5D659AB771666FB9F3F69@SJ0PR10MB5488.namprd10.prod.outlook.com \
    --to=drew.adams@oracle.com \
    --cc=55086@debbugs.gnu.org \
    --cc=hmelman@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.