From: Drew Adams <drew.adams@oracle.com>
To: Constantin Kulikov <zxnotdead@gmail.com>,
emacs-devel <emacs-devel@gnu.org>
Subject: RE: [External] : Re: [PATCH] Make rectangle-select able to skip lines(empty one, for example)
Date: Tue, 31 Jan 2023 16:18:46 +0000 [thread overview]
Message-ID: <SJ0PR10MB5488B9F1D8689665AEBE1F9EF3D09@SJ0PR10MB5488.namprd10.prod.outlook.com> (raw)
In-Reply-To: <CAFkz2ypzSD5_g_anhfd35SfiX-HLUp_isN4R_kWVXNEkAkej=w@mail.gmail.com>
> Treat lines with whitespaces only as 'empty'.
>
>(defvar *rectangle-skip-lines* nil
> "If `t' -- skip empty lines, if `function' -- skip line when it returns `nil'.
>The function gets all arguments of `apply-on-rectangle' as input.")
My opinion doesn't matter, but in case it helps:
1. Lose the *...* earmuffs. Elisp doesn't
embrace that CL convention for defvars.
2. The var's doc should say what it means by
"skip". Apparently it means (only) that
function `apply-on-rectangle' doesn't apply
its FUNCTION arg to empty lines. I think it's
important to say that the var affects (only)
that function's behavior.
next prev parent reply other threads:[~2023-01-31 16:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 13:47 [PATCH] Make rectangle-select able to skip lines(empty one, for example) Constantin Kulikov
2023-01-30 14:36 ` Constantin Kulikov
2023-01-31 15:05 ` Constantin Kulikov
2023-01-31 16:18 ` Drew Adams [this message]
2023-02-02 18:26 ` [External] : " Constantin Kulikov
2023-02-02 19:53 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR10MB5488B9F1D8689665AEBE1F9EF3D09@SJ0PR10MB5488.namprd10.prod.outlook.com \
--to=drew.adams@oracle.com \
--cc=emacs-devel@gnu.org \
--cc=zxnotdead@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.