From: Drew Adams <drew.adams@oracle.com>
To: Stefan Kangas <stefan@marxist.se>,
Stefan Monnier <monnier@iro.umontreal.ca>
Cc: "8951@debbugs.gnu.org" <8951@debbugs.gnu.org>
Subject: bug#8951: [External] : Re: bug#8951: 24.0.50; [PATCH] enhancement request: buttonize key names
Date: Mon, 25 Oct 2021 01:32:53 +0000 [thread overview]
Message-ID: <SJ0PR10MB5488867C8A032BC683A07D74F3839@SJ0PR10MB5488.namprd10.prod.outlook.com> (raw)
In-Reply-To: <CADwFkmmyoLyNPPLD1fvrn7n2mxjFU5ZYbrp4nPRzJ_ycdz+mbA@mail.gmail.com>
> > Grep even just the vanilla Emacs-Lisp sources for
> > `substitute-command-keys'. It's not used only for
> > *Help*. And then think about uses by other code,
> > besides vanilla Emacs.
>
> I only see a lot of places where we want whatever the user
> has configured, none where we need an optional argument.
>
> > What's the reason you prefer not to? I don't
> > understand. Maybe you have a good reason, but
> > I don't think you gave any (?).
>
> I'm repeating myself here:
Actually, though you may be repeating, you still
haven't given a reason for your preference. It's
OK with me if you have no reason - just wanted to
understand, in case I was missing something.
> I'm actually happy to add it, if we have a
> use-case. How about we try this for a start,
> and once users start using
> this in the wild, they'll come back to us and say: hey I really want an
> optional parameter here. Then we think about if that makes sense for
> their use-case, maybe it will, maybe it won't. But at least we know
> what we are trying to do.
>
> The alternative is that we add stuff just because "maybe someone will
> need it". That leads to feature creep, bloat, and is just not a good
> way to develop software.
An alternative is to not add a user option for
this just because maybe some user will need it.
You know - feature creep, bloat...
And to give users who write Lisp code the
ability to buttonize or not, wherever they use
`substitute-command-keys'.
___
That's what I did in help-fns+.el. Never had
anyone request a user option to not have the
links. Since 2011 - ten years in the wild.
Of course, I'd have had nothing against adding
an option for that, if users came back to me
and said: hey I really want a option for it.
In general, I'm not one who's particularly
opposed to dynamic global variables, or even to
binding them to affect behavior. But in this
case I thought an arg was sufficient.
___
FWIW, you'll notice that there are several uses
of the original, vanilla `substitute-command-keys'
in help-fns+.el. I don't recall the details, but
no doubt I thought those occurrences should not
buttonize key descriptions.
next prev parent reply other threads:[~2021-10-25 1:32 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 19:13 bug#44909: Hyperlinks gone for first story of two-storied *Help* buffers 積丹尼 Dan Jacobson
2020-11-28 7:39 ` Eli Zaretskii
2020-11-28 7:56 ` Stefan Kangas
2011-06-28 16:38 ` bug#8951: 24.0.50; [PATCH] enhancement request: buttonize key names Drew Adams
2011-07-04 20:28 ` Stefan Monnier
2011-07-04 21:08 ` Drew Adams
2011-07-06 18:49 ` Stefan Monnier
2011-07-06 19:55 ` Drew Adams
2011-07-08 19:07 ` Stefan Monnier
2011-07-08 19:20 ` Drew Adams
2019-06-27 16:35 ` Lars Ingebrigtsen
2021-10-23 0:46 ` Stefan Kangas
2021-10-24 13:36 ` Lars Ingebrigtsen
2021-10-24 13:54 ` Stefan Kangas
2021-10-24 14:15 ` Lars Ingebrigtsen
2021-10-24 14:56 ` Stefan Kangas
2021-10-24 21:07 ` bug#8951: [External] : " Drew Adams
2021-10-24 21:37 ` Stefan Kangas
2021-10-24 22:05 ` Drew Adams
2021-10-24 22:24 ` Stefan Kangas
2021-10-24 22:47 ` Drew Adams
2021-10-24 23:15 ` Stefan Kangas
2021-10-25 1:32 ` Drew Adams [this message]
2021-10-25 2:37 ` Stefan Kangas
2020-11-28 20:45 ` bug#8951: bug#44909: Hyperlinks gone for first story of two-storied *Help* buffers 積丹尼 Dan Jacobson
2020-11-29 10:25 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR10MB5488867C8A032BC683A07D74F3839@SJ0PR10MB5488.namprd10.prod.outlook.com \
--to=drew.adams@oracle.com \
--cc=8951@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.