all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Text properties gone from edit menu
       [not found] <878rut9y8n.fsf.ref@yahoo.com>
@ 2022-02-02 13:47 ` Po Lu
  2022-02-02 14:20   ` Stefan Kangas
                     ` (2 more replies)
  0 siblings, 3 replies; 10+ messages in thread
From: Po Lu @ 2022-02-02 13:47 UTC (permalink / raw)
  To: emacs-devel

The removal of the M-o prefix for facemenu commands seems to have had an
unintended side effect: the Text Properties submenu has disappeared from
the Edit menu.

Will anyone mind if I fix that?  And should I do that on the release
branch, since it's a regression from 27.2?

Thanks in advance.



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: Text properties gone from edit menu
  2022-02-02 13:47 ` Text properties gone from edit menu Po Lu
@ 2022-02-02 14:20   ` Stefan Kangas
  2022-02-02 14:48   ` Eli Zaretskii
  2022-02-02 15:51   ` [External] : " Drew Adams
  2 siblings, 0 replies; 10+ messages in thread
From: Stefan Kangas @ 2022-02-02 14:20 UTC (permalink / raw)
  To: Po Lu; +Cc: Emacs developers

Po Lu <luangruo@yahoo.com> writes:

> The removal of the M-o prefix for facemenu commands seems to have had an
> unintended side effect: the Text Properties submenu has disappeared from
> the Edit menu.
>
> Will anyone mind if I fix that?  And should I do that on the release
> branch, since it's a regression from 27.2?

IIUC, the global binding was removed because the command was only
useful in one specialized mode (enriched-mode).  So why should we keep
the global menu entry?  It seems to me that it belongs in the
'enriched-mode' specific menu instead.



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: Text properties gone from edit menu
  2022-02-02 13:47 ` Text properties gone from edit menu Po Lu
  2022-02-02 14:20   ` Stefan Kangas
@ 2022-02-02 14:48   ` Eli Zaretskii
  2022-02-02 17:08     ` Eli Zaretskii
  2022-02-03  1:06     ` Po Lu
  2022-02-02 15:51   ` [External] : " Drew Adams
  2 siblings, 2 replies; 10+ messages in thread
From: Eli Zaretskii @ 2022-02-02 14:48 UTC (permalink / raw)
  To: Po Lu; +Cc: emacs-devel

> From: Po Lu <luangruo@yahoo.com>
> Date: Wed, 02 Feb 2022 21:47:20 +0800
> 
> The removal of the M-o prefix for facemenu commands seems to have had an
> unintended side effect: the Text Properties submenu has disappeared from
> the Edit menu.

Just "Mix load-library RET facemenu RET", and it re-appears.

> Will anyone mind if I fix that?  And should I do that on the release
> branch, since it's a regression from 27.2?

What would that menu say?  All of its items aren't actionable until
facemenu is loaded.

This is not a regression, this is a deliberate removal of
functionality that was deemed not important enough.  It took us a lot
of heated discussions to get there, and I wouldn't want to restart
those discussions.

If you don't like the removal and its side effects, just add this to
your init file:

  (when (>= emacs-major-version 28)
    (require 'facemenu)
    (define-key global-map "\M-o" 'facemenu-keymap)
    (define-key facemenu-keymap "\es" 'center-line)
    (define-key facemenu-keymap "\eS" 'center-paragraph))

That's what I did.



^ permalink raw reply	[flat|nested] 10+ messages in thread

* RE: [External] : Text properties gone from edit menu
  2022-02-02 13:47 ` Text properties gone from edit menu Po Lu
  2022-02-02 14:20   ` Stefan Kangas
  2022-02-02 14:48   ` Eli Zaretskii
@ 2022-02-02 15:51   ` Drew Adams
  2 siblings, 0 replies; 10+ messages in thread
From: Drew Adams @ 2022-02-02 15:51 UTC (permalink / raw)
  To: Po Lu, emacs-devel@gnu.org

> The removal of the M-o prefix for facemenu commands seems to have had an
> unintended side effect: the Text Properties submenu has disappeared from
> the Edit menu.

Not sure it was unintended.
IMO, it was misguided, however.

> Will anyone mind if I fix that?  And should I do that on the release
> branch, since it's a regression from 27.2?

Indeed.

It was wrong to think that facemenu
is only about `M-o', or is only about
enriched-mode, or its commands don't
belong on the menu.

https://lists.gnu.org/archive/html/emacs-devel/2021-05/msg00461.html

https://lists.gnu.org/archive/html/emacs-devel/2021-03/msg01258.html




^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: Text properties gone from edit menu
  2022-02-02 14:48   ` Eli Zaretskii
@ 2022-02-02 17:08     ` Eli Zaretskii
  2022-02-03  1:06     ` Po Lu
  1 sibling, 0 replies; 10+ messages in thread
From: Eli Zaretskii @ 2022-02-02 17:08 UTC (permalink / raw)
  To: luangruo; +Cc: emacs-devel

> Date: Wed, 02 Feb 2022 16:48:50 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: emacs-devel@gnu.org
> 
> > From: Po Lu <luangruo@yahoo.com>
> > Date: Wed, 02 Feb 2022 21:47:20 +0800
> > 
> > The removal of the M-o prefix for facemenu commands seems to have had an
> > unintended side effect: the Text Properties submenu has disappeared from
> > the Edit menu.
> 
> Just "Mix load-library RET facemenu RET", and it re-appears.
        ^^^
I  mean "M-x", of course.  Sorry.



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: Text properties gone from edit menu
  2022-02-02 14:48   ` Eli Zaretskii
  2022-02-02 17:08     ` Eli Zaretskii
@ 2022-02-03  1:06     ` Po Lu
  2022-02-03  7:32       ` Eli Zaretskii
  1 sibling, 1 reply; 10+ messages in thread
From: Po Lu @ 2022-02-03  1:06 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: emacs-devel

Eli Zaretskii <eliz@gnu.org> writes:

> This is not a regression, this is a deliberate removal of
> functionality that was deemed not important enough.  It took us a lot
> of heated discussions to get there, and I wouldn't want to restart
> those discussions.

I thought it was only agreed to free up `M-o' as a prefix for ELPA
packages, not to remove the text properties menu from the menu bar as
well.

Thanks.



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: Text properties gone from edit menu
  2022-02-03  1:06     ` Po Lu
@ 2022-02-03  7:32       ` Eli Zaretskii
  2022-02-03  7:52         ` Po Lu
  0 siblings, 1 reply; 10+ messages in thread
From: Eli Zaretskii @ 2022-02-03  7:32 UTC (permalink / raw)
  To: Po Lu; +Cc: emacs-devel

> From: Po Lu <luangruo@yahoo.com>
> Cc: emacs-devel@gnu.org
> Date: Thu, 03 Feb 2022 09:06:09 +0800
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > This is not a regression, this is a deliberate removal of
> > functionality that was deemed not important enough.  It took us a lot
> > of heated discussions to get there, and I wouldn't want to restart
> > those discussions.
> 
> I thought it was only agreed to free up `M-o' as a prefix for ELPA
> packages, not to remove the text properties menu from the menu bar as
> well.

The "Text Properties" menu item makes no sense without facemenu being
available.



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: Text properties gone from edit menu
  2022-02-03  7:32       ` Eli Zaretskii
@ 2022-02-03  7:52         ` Po Lu
  2022-02-03  7:59           ` Eli Zaretskii
  0 siblings, 1 reply; 10+ messages in thread
From: Po Lu @ 2022-02-03  7:52 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: emacs-devel

Eli Zaretskii <eliz@gnu.org> writes:

>> I thought it was only agreed to free up `M-o' as a prefix for ELPA
>> packages, not to remove the text properties menu from the menu bar as
>> well.

> The "Text Properties" menu item makes no sense without facemenu being
> available.

But removing the facemenu map from `M-o' doesn't equate to facemenu not
"being available", right?

Thanks.



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: Text properties gone from edit menu
  2022-02-03  7:52         ` Po Lu
@ 2022-02-03  7:59           ` Eli Zaretskii
  2022-02-03 10:04             ` Po Lu
  0 siblings, 1 reply; 10+ messages in thread
From: Eli Zaretskii @ 2022-02-03  7:59 UTC (permalink / raw)
  To: Po Lu; +Cc: emacs-devel

> From: Po Lu <luangruo@yahoo.com>
> Cc: emacs-devel@gnu.org
> Date: Thu, 03 Feb 2022 15:52:47 +0800
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> I thought it was only agreed to free up `M-o' as a prefix for ELPA
> >> packages, not to remove the text properties menu from the menu bar as
> >> well.
> 
> > The "Text Properties" menu item makes no sense without facemenu being
> > available.
> 
> But removing the facemenu map from `M-o' doesn't equate to facemenu not
> "being available", right?

The decision was that this entire feature is not useful enough to have
bindings and menu items by default.  It started with M-o, but ended
with much more (as happens frequently in our discussions, where the
tail not only wags the dog, but eventually kills it as well).



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: Text properties gone from edit menu
  2022-02-03  7:59           ` Eli Zaretskii
@ 2022-02-03 10:04             ` Po Lu
  0 siblings, 0 replies; 10+ messages in thread
From: Po Lu @ 2022-02-03 10:04 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: emacs-devel

Eli Zaretskii <eliz@gnu.org> writes:

> The decision was that this entire feature is not useful enough to have
> bindings and menu items by default.  It started with M-o, but ended
> with much more (as happens frequently in our discussions, where the
> tail not only wags the dog, but eventually kills it as well).

Okay then.  But I remember that menu item existing all the way back to
Emacs 19.34 (when there was no M-o binding at all), so maybe the
decision about that particular non-intrusive item in the Edit menu could
be revisited at some time in the future.

Thanks.



^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2022-02-03 10:04 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <878rut9y8n.fsf.ref@yahoo.com>
2022-02-02 13:47 ` Text properties gone from edit menu Po Lu
2022-02-02 14:20   ` Stefan Kangas
2022-02-02 14:48   ` Eli Zaretskii
2022-02-02 17:08     ` Eli Zaretskii
2022-02-03  1:06     ` Po Lu
2022-02-03  7:32       ` Eli Zaretskii
2022-02-03  7:52         ` Po Lu
2022-02-03  7:59           ` Eli Zaretskii
2022-02-03 10:04             ` Po Lu
2022-02-02 15:51   ` [External] : " Drew Adams

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.