From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#49534: [External] : bug#49534: 26.3; Isearch should support using filter predicates with empty search hits Date: Tue, 13 Jul 2021 21:42:00 +0000 Message-ID: References: <87czrmrxfv.fsf@gnus.org> <87zguq6mof.fsf@mail.linkov.net> <874kcy6k4l.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21155"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "49534@debbugs.gnu.org" <49534@debbugs.gnu.org> To: Juri Linkov , Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jul 13 23:43:18 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m3QBR-0005KX-Tg for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 13 Jul 2021 23:43:18 +0200 Original-Received: from localhost ([::1]:38780 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m3QBQ-0007Lq-SM for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 13 Jul 2021 17:43:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49418) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m3QBC-00074v-77 for bug-gnu-emacs@gnu.org; Tue, 13 Jul 2021 17:43:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58926) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m3QBB-0005qs-Tq for bug-gnu-emacs@gnu.org; Tue, 13 Jul 2021 17:43:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m3QBB-0001o4-MP for bug-gnu-emacs@gnu.org; Tue, 13 Jul 2021 17:43:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Jul 2021 21:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 49534-submit@debbugs.gnu.org id=B49534.16262125296886 (code B ref 49534); Tue, 13 Jul 2021 21:43:01 +0000 Original-Received: (at 49534) by debbugs.gnu.org; 13 Jul 2021 21:42:09 +0000 Original-Received: from localhost ([127.0.0.1]:42239 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3QAK-0001n0-MX for submit@debbugs.gnu.org; Tue, 13 Jul 2021 17:42:08 -0400 Original-Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]:60076) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3QAI-0001mq-E6 for 49534@debbugs.gnu.org; Tue, 13 Jul 2021 17:42:07 -0400 Original-Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16DLfUkf028120; Tue, 13 Jul 2021 21:42:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=h3pwBaVAhUHxV4OUUcvaadOSxw6hVee1iFQz+I2VbbE=; b=A71YjdhopiLjxgi4TuZUkdTd8QPi3E6Vwmqop+T0sve2gZZEDnF+qNdtDuEkdmv1rWso B+h805AxG7vIZUqPu8Pi1RuK/RPSdLqBIR5k0BDwTqhpHSBugYvgoTYud0/F8fFqOf8S b4gMfm8xObOqdwT7kbQhy1XiBxtsIVqEdWfDmTDbG7kAXrJPCgbjFrpm/4PMHsILJDFh d1K3B1gAPnENA0sskon5UjBuzMWAV3vJ5FC/qSjMgLdLAD07huH/AI9EFvveKgUdu3Cn CEBcZxsAslUCgCIWaSmIi9tvV+QdBU8qpg//orDUHttFfdawfNRpMWL9kMVN4Ug8sasm Vw== Original-Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by mx0b-00069f02.pphosted.com with ESMTP id 39sbtuh2sh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 13 Jul 2021 21:42:05 +0000 Original-Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 16DLeVdA192764; Tue, 13 Jul 2021 21:42:03 GMT Original-Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2041.outbound.protection.outlook.com [104.47.66.41]) by userp3030.oracle.com with ESMTP id 39q0p5w7yg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 13 Jul 2021 21:42:03 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NouYbvGZ9nt4kHB68QlaZJC7kxPWbVz37BsUtb3Hw7MiopSj8MI3BdsYshRM4WG18kcR0tCAtb2OObGcSXY1LrCG/ugSPre9b4JK0Hh2DcvWN06GESi9ZSh5H/xXCPc493ZJpD1H+twHgmH1bTWRZ/VY3O73oSk1/fam6/zBTYx2K5p5wSvG08gUGaejSkzagFl847uK605m0xVyTM/DnQSIzHCtwhqIlW33JG+ewxFBlLHGUSjjI7TOrRLXkqt3W+wE//McN1G6TLJ9I4pPQqB4t28eunb087C2LG9CDV0/is2TUGYvQKTGQg01e25v+YnIqJ5SZ7uRWHZNFRXeBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h3pwBaVAhUHxV4OUUcvaadOSxw6hVee1iFQz+I2VbbE=; b=Xst9Te6NwFyYjYJ5uhnLEUWiuHBqt3yHuwbz10a2ld5NcdOUmaevojvILKd0StvY6AMmH5cf5YPYpuORJEOVmFTTXH/qP1a9JZonZR8QPw3mSfFfdQ0bDBdWd8jCcRQmYKQz1YWAuY2cGA1XOUw40wKfCpidwdtuOPIf31KTGx3ssvlJGIlcOe7Yz3svULz29UHztrkBZx/oOOl8w2iZf7FZ3aehgIE1eKHGXLykKeZmTsEkEyEI1AGfSfChmNkPc2WKfK2ZtoF71XM9wdO4VRRq1nal5drrRD6E3tqfL+wQSaaFZ2/wpiCvuQapOARqthmERl+dM63fZ2T4pJx0MA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h3pwBaVAhUHxV4OUUcvaadOSxw6hVee1iFQz+I2VbbE=; b=QFYXUoFt+5/4HLq4JTa5cFzaguMaynR84cbAG8gaVX4Z0oCU+pBND0VLstgEYu7OuAfT2gEHy20eo2kAIyLUww4GlACTO/HkwVXaxtFoL4dPNTdeuyyuzDnJrzuu+CxSbJUjxTR3/4r5iMoENtsKf7lqpudLfxC9lpbSvQH6ZTM= Original-Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by BY5PR10MB4146.namprd10.prod.outlook.com (2603:10b6:a03:20d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.19; Tue, 13 Jul 2021 21:42:01 +0000 Original-Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::1d3c:d31b:8add:1958]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::1d3c:d31b:8add:1958%5]) with mapi id 15.20.4308.027; Tue, 13 Jul 2021 21:42:01 +0000 Thread-Topic: [External] : bug#49534: 26.3; Isearch should support using filter predicates with empty search hits Thread-Index: Add3KtHOVbhX4iMwQf2riJuDn1/IigA+e/+IAABkQAA= In-Reply-To: <874kcy6k4l.fsf@mail.linkov.net> Accept-Language: en-US Content-Language: en-US authentication-results: linkov.net; dkim=none (message not signed) header.d=none;linkov.net; dmarc=none action=none header.from=oracle.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 65fc5cb3-9dec-42ac-789f-08d946470c32 x-ms-traffictypediagnostic: BY5PR10MB4146: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dHxVMI/ZUexSjHOb0XZpiyKrYKc9Xk6P00niNKk7i5O63Y1DGaZ65JGNMP4PPEnmd36eEkzqSggppwK7acARhoe8kArRrtqNxNqJuIOXLX9K25y4I8v1KLdjjjCZ49O+RW8Dpb3ZTEgwIkQ7ojQNwQnlfelv00mntOcurlWgPKzH6DzTSSwFH/MDclGCEPgJTXt/HHXdmVc3Z/R0oblKop0lsJiNNsG8FCdbKMYdl0s43dmKkRYrqswK8e/4tmIGt2f2AbSAdjwR2DiTaS6AeG8XeBe7aV388ACqrO7HQW7g46kRiSkIanG9YVsWuTZlmeH1Cv2ghNUxVUE0eOa8e3IJ+XGbFF7gR16iG/wguNXxmJWSf8Wcv/szBD4EPKdlBHrzMcmRekhHGYp9LppE8hOsjGXmPZUzTEiYZ+tn5GEsE/fqpY3eB3GK7vMMNSIFcB69aE740JvaGFrWE2YQ35kBi03PfhyQly4i9Wm0f6jCohOyxkVQlT7ln51dvhJcDG4ysbNdN56eBZ0muaZetgyWF9N2hb3jBugh6xdq7eLMRy9lqJHVWUC4t/3bGBsZQM5bX8X9AeeQ4wSUz5qF29WgbIyWkvYD0Azj5RGsPQQX5qDTtJ+RjamcnGBBzohXNaYgHFDQiiaYgKSLGQdwUg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(376002)(39860400002)(346002)(396003)(136003)(186003)(66946007)(52536014)(2906002)(4326008)(76116006)(38100700002)(8676002)(9686003)(55016002)(8936002)(4744005)(33656002)(122000001)(66446008)(110136005)(66476007)(64756008)(66556008)(26005)(71200400001)(5660300002)(44832011)(86362001)(316002)(478600001)(6506007)(7696005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: tn7H+kW5o7VFZxjHFQ9oHYxxnfQRFCQKGAukpgWn3bKyWYQhquybbJtd9NvqTP1s5G+t2OesucsRy7IgsJQaeMgGm+tB0E2a9Qy7fvd9eEBPQg24m1vx20AwnnlsydeLdG5/Sn/ZS3R8hGD8KXmGF2YnKt28/vRrOoQZqQ5wgja8gAH+vhwOgIYmGx0ifC1E6XXSCtarCbyOcqfB1bZ6+FWf4K4Dqlb39VfEwcVemdtuilMTkE2nLdqgsOgxicKDulSCD1FzPZOZiUPxBUgfG4smzSLsWiDRHUiy+/GoO9EHYtAfVpnDLxhTQM9aPOzTkUssTy7bL3UpaG94XwpQFx3yz2Qjhe/D1hBEACsIHHOC7VfBnNDwNsYRo6PYrxjuImPtg1kcvsR9TTP8NES4o341MrOLnGPo/uwDCVhaGsg+AL4B0EIG3f1T71UCf4Hxi5eaGIHXRnG4PoUh8eKTyXZZn61zxXaZgTm1kY/fcaIStkwRceOfaKEg39IJB9DrOOaSjab0dif4N+SRBwdLQEM7Q9kKoVuq0TV4Vwu/xFX6ZmC5wz1nhT1X0ZjvRbzqSFNFhItddqJ9dzj5iu7QdnjB3bUkVcFEFm9+snpa7zUtbNq4SJeY72oUeztMlFf4i1Bqba6+CS0737lpmPMH7SlBfPrHk74uUjGEns5iB5RGY3+/d1Q4QlZwhpfYfhscyY9ezYI7gTm3laWXcVKYV9AAYaBakNznsRK/bc0TkavF9DdLTIu/cY04gq OXFCpjEoQ6eVVvL2UIUAlBas6N7iQ3Q7oFCvmfe5EuyXN2hg2nkCdPj13jOHG7J9/xiYEqj4mXp3netdyLZHAnz/E1Hxly6/uM x-ms-exchange-transport-forked: True X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 65fc5cb3-9dec-42ac-789f-08d946470c32 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jul 2021 21:42:00.9090 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cbn8W3Yz0oaFf8JtuTaev36DFoWWfCMzzRfj3o0tPD/HEriZzGwlCYasXge309vEJfSo8y/UhfpVY9YLRe0mAw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4146 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10044 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 adultscore=0 phishscore=0 spamscore=0 bulkscore=0 mlxlogscore=999 mlxscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2107130133 X-Proofpoint-GUID: hg37s2mHq-eRW8KZ_MjFl2wgCyN4yCzQ X-Proofpoint-ORIG-GUID: hg37s2mHq-eRW8KZ_MjFl2wgCyN4yCzQ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:209885 Archived-At: > (=3D (match-beginning 0) (match-end 0)) >=20 > was moved below after >=20 > (funcall isearch-filter-predicate > (match-beginning 0) (match-end 0)) >=20 > This means that if isearch-filter-predicate does own matching, > it will break later (=3D (match-beginning 0) (match-end 0)). >=20 > What would be better: to remember its result in a let-bound variable, > or to use save-match-data? Probably, save-match-data: Yes, that's probably the right thing; good catch. ___ [On the other hand, a filter predicate can really do more than just act as a predicate (it can perform useful side effects). There could presumably be reasons we'd want to let it change the match data. No, I don't have any concrete use case in mind; and yes, without some other changes, that could mess up code that follows using the predicate. I just wonder about further restricting the predicate. The point of this bug fix was to _remove_ an unnecessary restriction, but now we're adding another restriction. ;-)]