From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#59559: 28.1; `minibuffer-with-setup-hook' with :append Date: Sat, 21 Jan 2023 18:41:15 +0000 Message-ID: References: <87pmbmnvdd.fsf@web.de> <87358iuqsj.fsf@web.de> <87edro6jl7.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11464"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "59559@debbugs.gnu.org" <59559@debbugs.gnu.org> To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 21 20:17:44 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pJJN1-0002m2-PB for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 21 Jan 2023 20:17:44 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pJIoW-0007SK-ET; Sat, 21 Jan 2023 13:42:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJIoV-0007SC-1W for bug-gnu-emacs@gnu.org; Sat, 21 Jan 2023 13:42:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pJIoU-00007U-Nf for bug-gnu-emacs@gnu.org; Sat, 21 Jan 2023 13:42:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pJIoT-0002jM-Ii for bug-gnu-emacs@gnu.org; Sat, 21 Jan 2023 13:42:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Jan 2023 18:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59559 X-GNU-PR-Package: emacs Original-Received: via spool by 59559-submit@debbugs.gnu.org id=B59559.167432648210415 (code B ref 59559); Sat, 21 Jan 2023 18:42:01 +0000 Original-Received: (at 59559) by debbugs.gnu.org; 21 Jan 2023 18:41:22 +0000 Original-Received: from localhost ([127.0.0.1]:49743 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJInp-0002ht-MT for submit@debbugs.gnu.org; Sat, 21 Jan 2023 13:41:22 -0500 Original-Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]:36470) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJInn-0002hj-8C for 59559@debbugs.gnu.org; Sat, 21 Jan 2023 13:41:19 -0500 Original-Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30LE5xMo018284; Sat, 21 Jan 2023 18:41:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=aeDCF7HjEVpomJoCtonfUXG8O1GdBqvF0sCtrvpLRJU=; b=EShLrjDu6hnnKZnCRpCkMRgLut+ybYkZcKkTOSCjmIRkYFIsDz4xiufeksyE84JomoHx n51KfGFEyen3uWsYNNz6O05U1XFdNt0lzvdKwMCJ8EZ1BIOuXEI8fcJ2gr/uzc5X3Ehr eF8frYsJmizGfofTm41/7aHKXXhVZIi3XpTb3aBt3ceVFNWZTpAfRV53glZppdwTjGwk c3TBfsYX7znoIMGupCKoTgpq2XDOfSbHH8k6baHbpswHrKW9qv1jeOXJcNYiWTqWbR79 Czf8oo74EYdshhbCR43s7vRDDDs+GeEDdtMaFHAV1lC2ZgJ+2ZiLpkY/1ziNagWUCOEV Tg== Original-Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3n88ktrkdq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 21 Jan 2023 18:41:18 +0000 Original-Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 30LEDQNR034980; Sat, 21 Jan 2023 18:41:17 GMT Original-Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2103.outbound.protection.outlook.com [104.47.55.103]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3n86g1hde6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 21 Jan 2023 18:41:17 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XUZq9FhIBv8U6Aso+T2AjdxmqEvx1sw48HOlnaQdD+BZ6gjhnWEO+HoHbHqM6tfhDucNEuii2lL5tEuV5nDWxHDp1Ft+JM7qG7qKy9yAZVnj54HjE2zuo8yVkXNsfouwG9pECJQWFLPbg7swE9JqOQPqL4q9NjKwjHXK/4uEMfTc4/bceg382P+3FRxwkgebQF1SeAiA0dtmk8z/+2pd2qnqbat8BF8I7JpH0AtqXz4PZnUmlgwzqO4kFvw+rpggB6yN4OE3jK0MadB3lJPXCu9Whu29xDkAtuLXGNjoXV2ufYCXA2JRTdIiQHN2K1X3NZcWAkm2DIah13CcjLcBkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aeDCF7HjEVpomJoCtonfUXG8O1GdBqvF0sCtrvpLRJU=; b=ek1DcPAUiPGD+B0ZNUTKSgRutX33ZKC0Y5ze/T9gk+yQmX1JBB1u8ZrtX7fabIFESA0HZ6b7n66CUIq02ORpiro7RCPWPz1lYbTn7g5Wgjbxgb7qZI46CSOPdV/CKiraNWShhpZvANLLprKS0GmlhTCJps0EZJfXXBVTgMa/azfL6BmHC0vzPmCw29lGKhLgoE7nHiD8knlc+2zkZSTofJWomrUzQHCnqRsmFgM0VgsUL9gxDW8Mu5LSN8eHeKNGYBU5MHZp2yYC7uhspHf+hGtqhU6G7M7UUioxTrhORogqJ9bteJOFYaOiXAReMKUYgTvvzF8Pp5hfMrE732QHPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aeDCF7HjEVpomJoCtonfUXG8O1GdBqvF0sCtrvpLRJU=; b=zQCfFkon4vqaJn9ySrew0PGPHMJ3DdtojnxP99y8ZIGADKPYcOIpumMDpQk8ksxG9qQokqVAoe9RjfVEAQo7Xa+Usjeq0N+Kr74nuq4cI70ABvAcFxpnBo87hn+iE0i1j8BZWCHTcnD33KhxzGlnolm8uw6HWRaJ6oW14bkRumQ= Original-Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by BY5PR10MB4257.namprd10.prod.outlook.com (2603:10b6:a03:211::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.9; Sat, 21 Jan 2023 18:41:16 +0000 Original-Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::7c3c:e53d:5276:ef29]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::7c3c:e53d:5276:ef29%7]) with mapi id 15.20.6043.009; Sat, 21 Jan 2023 18:41:15 +0000 Thread-Topic: [External] : Re: bug#59559: 28.1; `minibuffer-with-setup-hook' with :append Thread-Index: AQHZLaW1viHFXJJN9ESPlSaDzBb9cq6pLLFg In-Reply-To: <87edro6jl7.fsf@web.de> Accept-Language: en-US Content-Language: en-US x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR10MB5488:EE_|BY5PR10MB4257:EE_ x-ms-office365-filtering-correlation-id: 637c62c6-f92e-46b2-c530-08dafbdf13d7 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LlEMJvhIuyhRTJOXengP/0oLyalNF4iVRx8hINKJysX9vfiRWjy5DSz8graJwtwWH1Vd2W/l/0uJKBT/m4dsTmP/OOvirD2Riq8CNfMKdHLcaX7/GTDNHnEMRzGHRtjWbJB1cI91blHYZ356t5ISpfoKsp5GmIgNkIXFBY30XDLtQrBz1l2jbKzKPcX/B4mMxGmnQyXGsUBsUpLHF1dDjnKPfgewsYvVRlNtgO2gTd+6mU7yhn6XvQpsAnRQfJqt7jz45+TtxmaD7DqL6XABEsQKoOhOd4Ln5oiegAPan/S2QpiWJrdP/Ikjt/lFrr633o5IFBedixjGZrAzL3/D75kcaHH4Ko+sYLDSWjW902Q0NJ6qEmOzWs3leANVwDgu3glxXR8Fns22wSPUKSgxzupnYrGddS2hBKoRVUyBNXCoCkcAXy5ebVDRQt1kyXTnWAZQ4I2JXPe50zfglsBBgTXV52Mvh8nMH4Iyz6T2RWFjdE9blPWu0mlqedZRVotMJVEgwlUWtW6/v2VqYTy9Cr0PcuYP/ObZC/DMC7W4nmMcp+vEBQiP8nOOH1GqeiK2mXhLy9E+kXcnJGZsvpNHnWzWA06s8sDFMezGFMke0TXCjIPB6QbdDCfSjsaXwU0002RRv3jELtFYqLqAHNBwiZIOz9KxlqXiIMlhSUy0qNWiog2yaKfFZ9z+RsvS1jwUaOI3C1klppXqBUW1ZfZ4n4LhVX728YHe114P82ztnk4= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(39860400002)(366004)(136003)(376002)(396003)(346002)(451199015)(71200400001)(7696005)(478600001)(38100700002)(122000001)(33656002)(83380400001)(41300700001)(38070700005)(6506007)(316002)(5660300002)(66476007)(66446008)(8676002)(6916009)(4326008)(64756008)(44832011)(86362001)(9686003)(2906002)(26005)(186003)(55016003)(76116006)(66946007)(66556008)(8936002)(52536014)(81973001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: CDKN/R4By7yF14gr/XlTFdVYx+nnygMtI7TLVdrQg/mjeMz/3so/OFYobVT935PVlilQiNEwwHlIa/fIwq2qt47d1FCsEWfX/UY6CoTywzFICgzwZpfq2DwUyp79lqK+0Fg/GTFuTPbyKxkqIVS54+Lejvaprmf2g1kCUv6GmOJXtpIP+jCa9iWSw/oMGQK/lbh4Ieb7bDCp0o0krvbqGkajHJN5Mel08bG4Ccumfa4gOdEvQKA46g0mKvqeQserOYnYt2f/XJuajtU8AG81hQfPuXi7zL7F6gMr/9fZ8E+W5KzAS5jMa0AAYn7FCJnSYiAQVM8Imi0jrmaDAORPKOgoVf5RzIZ9GdOOo/POTWCmReP+abpBxIpWy6cMvgG8kDIXrd6NcdhrCzIjiPgdYQP7HyC0ueHzukFUIsU14EnujNq1y6z1Zq6OzXmPLThFIpWt2rzMTp8mcD89lmpHa0AWFMvopQAUu//L0zc4VN54GkJLQt/V37V4mQvpKwG0b+Z3zkx3dz8AMFtCgj3E4DEEwHvC+iMYHIW5Wp0HZnLb2OdfN1rHKUSOwxi5rz+k35FJGn0t6f9FSvOK8gwQXbpEBX5tFfEKAD5sX9p8RyQ+fGbk8QkCoEauT/PFM275pAoG6D/Q8KujA/nG7ZLWBGtrKGBUJg7hPh5NOddLBm67uFhhb4LIdHn9iaDLnz5BvmUcJcsh7WenT4XxDGHQIetK74rrSDXNyaYy/Kw/3Tx+6a27fTXdVYYCaQ qTM99ErRK/MBr3os5oNWzfyCkqK+27dRR1jhaAYDOIAU47rwMdOFhaTprdsm60zSEvDbuso4C0m0NsVIIY+UEP/s9cPvQPyC+O X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: tN23xjz3+WKKMmnbbXTGcW5klVYoMQssSK65s14bY04OLoRFyK8gp4B9BSrul87OX4ykQh/ODTdfb4nhyGObt8QIs7iYW9GY3gJr+8Qd1jPcaLJH2X05N1pi2qsKZx+oGWWORfpwextHmLO5r5zyzz2jp19UTdxAcYWGD/RgrJazBd1Wv+4Gcf1SUI8PGpTmz8hvbu8j6GjAPPMvjjzRAoM/GftFlQtB4A83niIMOHIZhZk7y8F8yFo2ISOrCVnvrGv0TxgAQVwmW++NoNmjTsjCIMFL5HsGCIvWtAbhG/q38vNNGp+7lC0cYV50b7L4MdsVqYeq0plDvBM1X1aot6ifSYmXu9ec1bH9Qfb4Nm+7JXdr44bj3UJX/cgE2mD/vSBETUZJAI76adr2ynXLx4mbhLjP3hNKlIIn01pU2nlTy/Fm9W0gj6KHzGouLVlMm4Jb8jyZO3SPgpNi1ro/vncT02ygPwBm/AoTmlYjX/Gxj/mxGJ3HKvrpwHuAYpeMjMqQs4A0DQBRrqI4d1ej9ew2LYb6BFZXCJRNWGQq5h414vijp2o9e14s07IkS5Dyea794h/iTMidFYEyYfflV4YhQw1PfL4NrxZXMt5R0JKjVhTxQK5f/GCkYMFL20kfzBBtoujKPOJvfs7RuJ86aAQLfrD+KgFAv6fpmfvYlYikcctzf1NT8ijb0hsCHDSjUApT0nnDXmuqyj1hRFjrglRoL018evW1smBkuOkYPm08ph MzkeJnwBgoFUtiHPK/M2Ia8MXLS5tXM6TobDNT2Q== X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 637c62c6-f92e-46b2-c530-08dafbdf13d7 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jan 2023 18:41:15.5064 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: i0XbnK3SFvvTkJQDgxaKYFe+KpkiLeFTm3RQ9Q0C1Sibt2jx3uC8Riwd8xRHtMy5DHKz4y53Ia/3OwuagTIp4A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4257 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-01-21_11,2023-01-20_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=384 malwarescore=0 mlxscore=0 bulkscore=0 adultscore=0 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301210180 X-Proofpoint-GUID: qMMdAYexOflL_S7K5h34hOPSjYvOfcI7 X-Proofpoint-ORIG-GUID: qMMdAYexOflL_S7K5h34hOPSjYvOfcI7 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253878 Archived-At: > > > I think clarifying that a bit would make sense. > > Yes. > I tried to do that: In the default case, FUN is an expression that should evaluate to a function, and the result will be prepended to `minibuffer-setup-hook'. If FUN is an unquoted list of the form `(:append FUN1)', the result of evaluating FUN1 will be appended to `minibuffer-setup-hook' instead of prepending it. Thx. I'd say (but Eli will likely disagree), that we need not and should not use future tense ("will be"), and we should avoid "should". But that's just a doc-style question. More importantly, I'd avoid talking about an unquoted list. It's not really about quotation, is it? It's about evaluation. It's about the first arg being a sexp that doesn't simply get evaluated. The important thing, I think, is to get across the (quite unusual) treatment of arg FUN: It's not just evaluated, and it's not just NOT evaluated. (IMO, this is a poor interface, but we are where we are.) I suggest something like this - somehow get across the fact that FUN _might_ be simply evaluated, and the result prepended, or it might be a sexp that's _not_ evaluated, but _part_ of it is, and in that case the result of that evaluation is appended. E.g.: Argument FUN is a sexp; it is not simply evaluated. Two cases: * If FUN has form (:append FUNCTION), evaluate FUNCTION and append the result to the hook. * Otherwise, evaluate FUN and prepend the result to the hook. Another possibility: If FUN is (without evaluating) a sexp (:append FUNCTION) then FUNCTION is evaluated and appended to the hook. Otherwise, FUN is evaluated and prepended to the hook. (Could say "list" instead of "sexp", but the latter stresses the connotation that it's not evaluated.) We might also change the name FUN. Maybe use FUN-SPEC or something - something that doesn't suggest that it _is_ a function but that it specifies a function that gets added to the hook. A question is whether what is said in the doc of `add-hook' is also true here: the function "is not added if already present." If so, I think the doc should say that. (It's kind of a shame that we can't just point to `add-hook'.)