all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: "46973@debbugs.gnu.org" <46973@debbugs.gnu.org>
Subject: bug#46973: [External] : Re: bug#46973: 26.3; (elisp) `Face Remapping'
Date: Wed, 23 Feb 2022 15:56:21 +0000	[thread overview]
Message-ID: <SJ0PR10MB54884E13B02F56DAE8FDD0D8F33C9@SJ0PR10MB5488.namprd10.prod.outlook.com> (raw)
In-Reply-To: <87v8x594yr.fsf@gnus.org>

> > (add-hook 'some-mode-hook
> >           (lambda ()
> >             (face-remap-set-base 'default 'variable-pitch)))
> >
> > I get an error saying that `variable-pitch' isn't a list.
> > (And trying '(variable-pitch) instead gives the same error.)
> 
> Looks like this regression was introduced by cece37cf09de9, which just
> wanted to simplify the specs list.  But then the test after that wasn't
> adjusted.  I've now fixed this in Emacs 29.

Thanks for fixing this.  I downloaded face-remap.el
from MASTER, and I see that you applied the fix I
suggested: (if (or (null specs) (eq specs face)).

I see from the commit log that the regression was
introduced in 2008.  Which Emacs release was that?

[And how do I find that release @ from the web
interface to the repo, here?
https://repo.or.cz/emacs.git/commit/cece37cf09de9]







  reply	other threads:[~2022-02-23 15:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-06 18:16 bug#46973: 26.3; (elisp) `Face Remapping' Drew Adams
2021-03-13 10:35 ` Eli Zaretskii
2021-03-15 16:36   ` bug#46973: [External] : " Drew Adams
2022-02-23 11:50 ` Lars Ingebrigtsen
2022-02-23 15:56   ` Drew Adams [this message]
2022-02-23 16:57     ` bug#46973: [External] : " Eli Zaretskii
2022-02-23 17:23       ` Drew Adams
2022-02-23 22:10     ` Mauro Aranda
2022-02-23 22:55       ` bug#46973: [External] : " Drew Adams
2022-02-24  6:49       ` Eli Zaretskii
2022-02-24 11:52         ` Mauro Aranda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SJ0PR10MB54884E13B02F56DAE8FDD0D8F33C9@SJ0PR10MB5488.namprd10.prod.outlook.com \
    --to=drew.adams@oracle.com \
    --cc=46973@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.