all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: "damien@cassou.me" <damien@cassou.me>,
	"larsi@gnus.org" <larsi@gnus.org>,
	"54156@debbugs.gnu.org" <54156@debbugs.gnu.org>
Subject: bug#54156: [External] : bug#54156: 28.0.91; set-face-attribute with a nil FRAME doesn't change the default
Date: Sun, 27 Feb 2022 15:49:43 +0000	[thread overview]
Message-ID: <SJ0PR10MB5488465BE36A421A2EC2400BF3009@SJ0PR10MB5488.namprd10.prod.outlook.com> (raw)
In-Reply-To: <8335k4pz7d.fsf@gnu.org>

> > You said to use both (separately).
> > My question was why to bother _also_
> > using `t'.
> 
> Because it's future-proof.  And because resetting a color attribute to
> 'unspecified' so that it overrides the defface is an unusual thing to
> do, and so it better stands out in the code, telling everyone that
> this is the intent.

Thank you for finally stating your reason.  And
for finally confirming that what I said I thought
was the behavior is in fact the behavior.
___

FWIW, I disagree (but at least now it's clear
why you have that opinion).  I think telling
people to use both only confuses.  They'll wonder
why, the same as I did - unless you also indicate
your reason somehow/somewhere.
___

Beyond that, what about the question of making
backward-support behavior known?  Why only
"silently support" the use of nil this way?
Support, yes, sure.  But why silently?

We usually try to also provide a warning message
when you use constructs deemed deprecated/obsolete.
This pitfall is easy to fall into, IMO, regardless
of whether you think the reasonable use case is
rare.

You haven't yet given your reasons for resisting
making this gotcha better known to users - e.g.
by displaying a warning message.

When you don't give reasons it just leads to more
back & forth and misunderstanding.  Please try to
be clear and explicit about this.  Thank you.
___

I also don't agree that a user or user code would
only _rarely_ want to reset a face attribute to
`unspecified'.  We provide checkboxes in Customize
for exactly that, no?  Is this different from
unchecking a checkbox?

After you uncheck the Background checkbox for
`M-x customize-face region' this sexp returns
`unspecified':

 (face-attribute 'region :background t)

What am I missing, here?  If this has the same
effect as setting it to `unspecified' in Lisp:

 (set-face-attribute 'region nil :background 'unspecified)

then why consider it and "unusual" and "rare"?





  reply	other threads:[~2022-02-27 15:49 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-25 10:21 bug#54156: 28.0.91; set-face-attribute with a nil FRAME doesn't change the default Damien Cassou
2022-02-25 12:15 ` Lars Ingebrigtsen
2022-02-25 12:26   ` Eli Zaretskii
2022-02-25 12:30     ` Lars Ingebrigtsen
2022-02-25 13:03       ` Eli Zaretskii
2022-02-25 13:12         ` Lars Ingebrigtsen
2022-02-25 13:24           ` Eli Zaretskii
2022-02-25 15:42             ` bug#54156: [External] : " Drew Adams
2022-02-26 15:04             ` Lars Ingebrigtsen
2022-02-26 15:24               ` Eli Zaretskii
2022-02-26 16:17                 ` bug#54156: [External] : " Drew Adams
2022-02-26 16:35                   ` Eli Zaretskii
2022-02-26 17:23                     ` Drew Adams
2022-02-26 17:50                       ` Eli Zaretskii
2022-02-26 22:47                         ` Drew Adams
2022-02-27  7:04                           ` Eli Zaretskii
2022-02-27 15:49                             ` Drew Adams [this message]
2022-02-27 13:02                 ` Lars Ingebrigtsen
2022-02-27 16:13                   ` bug#54156: [External] : " Drew Adams
2022-02-25 12:16 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SJ0PR10MB5488465BE36A421A2EC2400BF3009@SJ0PR10MB5488.namprd10.prod.outlook.com \
    --to=drew.adams@oracle.com \
    --cc=54156@debbugs.gnu.org \
    --cc=damien@cassou.me \
    --cc=eliz@gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.