From: Drew Adams <drew.adams@oracle.com>
To: 59937@debbugs.gnu.org
Subject: bug#59937: 28.2; Bad defcustom behavior
Date: Sat, 10 Dec 2022 05:06:56 +0000 [thread overview]
Message-ID: <SJ0PR10MB54882BEA866AC19E799D51FBF31F9@SJ0PR10MB5488.namprd10.prod.outlook.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 4448 bytes --]
These first four defcustoms behave as I expect.
The first has a default value of nil - empty alist. The second has a
default value of (("key1" :x ("a" "b") ("q"))). The third had a default
value of (("key1" :x () :w ("q"))) - one of the plist-entry values is
empty. The fourth has a default value of (("key1")) - empty plist.
The option should be an alist with elements that have a string key and a
plist value. Each plist element has a keyword key and a list of string
values. The alist can be empty, any plist can be empty, and any
plist-entry value can be empty.
;; OK
(defcustom myvar ()
"..."
:group 'emacs
:type '(alist :key-type (string :tag "Alist key (string):")
:value-type
(plist :key-type symbol
:options (:x :y :z)
:value-type (repeat string))))
;; OK
(defcustom myvar '(("key1" :x ("a" "b") :w ("q")))
"..."
:group 'emacs
:type '(alist :key-type (string :tag "Alist key (string):")
:value-type
(plist :key-type
(restricted-sexp :match-alternatives (keywordp)
:tag "Plist key (keyword)")
:options (:x :y :z)
:value-type (repeat string))))
;; OK
(defcustom myvar '(("key1" :x () :w ("q")))
"..."
:group 'emacs
:type '(alist :key-type (string :tag "Alist key (string):")
:value-type
(plist :key-type
(restricted-sexp :match-alternatives (keywordp)
:tag "Plist key (keyword)")
:options (:x :y :z)
:value-type (repeat string))))
;; OK
(defcustom myvar '(("key1"))
"..."
:group 'emacs
:type '(alist :key-type (string :tag "Alist key (string):")
:value-type
(plist :key-type
(restricted-sexp :match-alternatives (keywordp)
:tag "Plist key (keyword)")
:options (:x :y :z)
:value-type (repeat string))))
The first OK example specifies the type of the plist key as just symbol,
not as keywordp. But I want to constrain it to be a symbol that's a
keyword. The problem occurs when I try to do that AND I use a default
value of nil (see next).
This one is no good - that's the bug:
;; When click initial INS get prompted for a Lisp expression, get warnings,
;; and Customize buffer contents are changed to just INS DEL while prompting.
;;
(defcustom myvar ()
"..."
:group 'emacs
:type '(alist :key-type (string :tag "Alist key (string):")
:value-type
(plist :key-type
(restricted-sexp :match-alternatives (keywordp)
:tag "Plist key (keyword)")
:options (:x :y :z)
:value-type (repeat string))))
In this case the default value is nil, but the defcustom also specifies
the type of plist values as keywordp. I think this definition should
work fine. But when you click the sole INS button at the outset you're
prompted for a Lisp expression and you simultaneously get a warning that
a plist key is not of the right type. If you enter a Lisp expression
(e.g. just 42 or whatever) then the Customize buffer appears as it
should. I think (1) you shouldn't be prompted for anything and (2) you
shouln't get any warning of anything.
Warning (widget-bad-default-value):
A widget of type restricted-sexp has a bad default value.
value: nil
match function: widget-restricted-sexp-match
match-alternatives: (keywordp) Disable showing Disable logging
See attached screenshot, which shows the prompt as well as the
Customize buffer during prompting and the *Warnings* buffer.
In GNU Emacs 28.2 (build 2, x86_64-w64-mingw32)
of 2022-09-13 built on AVALON
Windowing system distributor 'Microsoft Corp.', version 10.0.19044
System Description: Microsoft Windows 10 Pro (v10.0.2009.19044.2251)
Configured using:
'configure --with-modules --without-dbus --with-native-compilation
--without-compress-install CFLAGS=-O2'
Configured features:
ACL GIF GMP GNUTLS HARFBUZZ JPEG JSON LCMS2 LIBXML2 MODULES NATIVE_COMP
NOTIFY W32NOTIFY PDUMPER PNG RSVG SOUND THREADS TIFF TOOLKIT_SCROLL_BARS
XPM ZLIB
(NATIVE_COMP present but libgccjit not available)
[-- Attachment #2: throw-emacs-defcustom-bug.png --]
[-- Type: image/png, Size: 35101 bytes --]
next reply other threads:[~2022-12-10 5:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-10 5:06 Drew Adams [this message]
2022-12-10 10:05 ` bug#59937: 28.2; Bad defcustom behavior Mauro Aranda
2022-12-10 22:05 ` Drew Adams
2022-12-11 11:08 ` Mauro Aranda
2022-12-13 22:10 ` Drew Adams
2022-12-13 22:50 ` Mauro Aranda
2022-12-14 1:51 ` Drew Adams
2022-12-14 12:40 ` Mauro Aranda
2022-12-14 18:53 ` Drew Adams
2022-12-14 22:20 ` Mauro Aranda
2022-12-14 22:42 ` Drew Adams
2023-01-04 16:07 ` Drew Adams
2023-01-04 22:31 ` Mauro Aranda
2023-01-04 22:47 ` Drew Adams
2023-07-16 23:00 ` Mauro Aranda
2023-07-17 15:30 ` Drew Adams
2023-07-17 16:21 ` Mauro Aranda
2023-07-22 12:56 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR10MB54882BEA866AC19E799D51FBF31F9@SJ0PR10MB5488.namprd10.prod.outlook.com \
--to=drew.adams@oracle.com \
--cc=59937@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.