all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: "59745@debbugs.gnu.org" <59745@debbugs.gnu.org>
Subject: bug#59745: 26.3; Rename `string-collate-lessp' to respect the convention
Date: Thu, 1 Dec 2022 17:54:43 +0000	[thread overview]
Message-ID: <SJ0PR10MB548824D2E5C4D351D1285B3DF3149@SJ0PR10MB5488.namprd10.prod.outlook.com> (raw)
In-Reply-To: <83r0xjgjaq.fsf@gnu.org>

> We also have bufferp, stringp etc., so -lessp
> is not so bad,  especially since it's modeled
> on string-lessp.
> 
> And anyway, it's too late now for renaming.
> Closing.

OK, it's too late.  Understood.
___

But what you say wrt `string-lessp' doesn't
correspond to what the convention is, as it's
documented now.  `bufferp' and `stringp' _do_
respect the convention.

If what you say is to be the _new_ convention,
or a correction to how the convention should be
specified, then please consider updating the doc
to reflect that.  Currently, what we say should
be done is (sometimes) not what we do.
___

Note that `string-lessp' itself doesn't respect
the current convention.

`buffer-live-p' does respect it - it should be
the model for a name with multiple parts/words
(per the current convention).

`string-lessp' in fact illustrates what I said:

  "Every such misnaming encourages others, as
   people tend to base new names on names they
   see for existing things."

Exactly that - you're now citing `string-lessp'
as a precedent.  It's an easy, slippery slope.

It's not because there've been some unfortunate
misnamings that we should create more, based on
those as precedent.





  reply	other threads:[~2022-12-01 17:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-01 16:19 bug#59745: 26.3; Rename `string-collate-lessp' to respect the convention Drew Adams
2022-12-01 16:50 ` Eli Zaretskii
2022-12-01 17:54   ` Drew Adams [this message]
2022-12-01 18:50     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SJ0PR10MB548824D2E5C4D351D1285B3DF3149@SJ0PR10MB5488.namprd10.prod.outlook.com \
    --to=drew.adams@oracle.com \
    --cc=59745@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.