From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#56754: 28.1; Please move general stuff from `ffap.el' to `files.el' Date: Sun, 24 Jul 2022 23:40:48 +0000 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37527"; mail-complaints-to="usenet@ciao.gmane.io" To: 56754@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 25 01:42:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oFlEm-0009ZP-1a for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 25 Jul 2022 01:42:16 +0200 Original-Received: from localhost ([::1]:36440 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oFlEj-0006qX-Q8 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 24 Jul 2022 19:42:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43790) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oFlEY-0006qL-8G for bug-gnu-emacs@gnu.org; Sun, 24 Jul 2022 19:42:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59184) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oFlEX-00060e-Vo for bug-gnu-emacs@gnu.org; Sun, 24 Jul 2022 19:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oFlEX-0005eN-PK for bug-gnu-emacs@gnu.org; Sun, 24 Jul 2022 19:42:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Jul 2022 23:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 56754 X-GNU-PR-Package: emacs X-Debbugs-Original-To: "bug-gnu-emacs@gnu.org" Original-Received: via spool by submit@debbugs.gnu.org id=B.165870606921651 (code B ref -1); Sun, 24 Jul 2022 23:42:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 24 Jul 2022 23:41:09 +0000 Original-Received: from localhost ([127.0.0.1]:48933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oFlDg-0005d8-E0 for submit@debbugs.gnu.org; Sun, 24 Jul 2022 19:41:08 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:51934) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oFlDa-0005cu-Rf for submit@debbugs.gnu.org; Sun, 24 Jul 2022 19:41:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43722) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oFlDa-0006m9-Ld for bug-gnu-emacs@gnu.org; Sun, 24 Jul 2022 19:41:02 -0400 Original-Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:13788) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oFlDU-0005ww-G0 for bug-gnu-emacs@gnu.org; Sun, 24 Jul 2022 19:41:02 -0400 Original-Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26OIPOSb031189 for ; Sun, 24 Jul 2022 23:40:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : subject : date : message-id : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=cgcQN6yFzfJM+XSM+kmV7AB5tv1MEGsd2Kalpkesw3I=; b=t+8Fi/ljTEs0AJLOgZA3Y0RlcuogP5tB+lwtWdFET29N6Igd97p5gM2HBmtJ4OjVK8K3 M3z/eOAPT3Y+LNtYjFKy8pK3nJ7s/7tjT1Aae1iosMBKnXT62quL9gKrgM5mZkiQYsaW EV9czkjx6epUQ5ccTqO/BfUMYF70FFnWOZimzvS/1RyJ84N9zo1YL6wxkH5zS+51gk+N Ec41NzMw+duG0CC3lW5gyelVGrGiCvudZ2UV31AxbWa/M90C1rA9x7SvudKAQEdrMBlI IPDXGweySOTuinbb8bf3OJpI7zMC/CJl0s9Yx1agBrr08Mu1FK2EXG6gtG15mzjqLD1z Nw== Original-Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3hg940hvj8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Sun, 24 Jul 2022 23:40:51 +0000 Original-Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 26ONKjd1006240 for ; Sun, 24 Jul 2022 23:40:50 GMT Original-Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2107.outbound.protection.outlook.com [104.47.70.107]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3hh659p2ag-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Sun, 24 Jul 2022 23:40:50 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Mked5oa8BlFkflpdxfZbtWteR2iiia+VZM8oKr2oIuzdWhJFNyN2B7t2cI3jS0f5Wa6ddka1BGlJsCsR/CvtGqadUeeRLfFnKrM9fAup2i6n0tEUfP0qK5+uyEuy7OcaWXOy3lYSa1kJgXEA7+lbSxLmcaD5yJrKah2cf7SK23iQNLiU5mFNGVaGuSF/S4ErAWSzMOvxONqdh5BfA7fatVn0VKmtJ7tFlnrvKKsFDj27l4Ql4o4E9EJsXh9l5C/RScqwJg8rS6U3zDxMaGiUWQkEw3JRQmLog4mnGBskfZFdfi1JfpoyZktDoZbxbkzR0jkHVcs69LeM6Cqk6daaPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cgcQN6yFzfJM+XSM+kmV7AB5tv1MEGsd2Kalpkesw3I=; b=MIjJFeib4TF5c6ID+MUZUat/kBCkYeNsmgkNi5HZZHFUi/TrwRWeBuhEB7Ae/uAamkvez8QUC4M0lkoAWQDXeJVfjCtIkmHjqQatOZlGgrV+BKroUHI9I097dY1mDRoYkpza54wY2DXBr8NaAvZBsjwZ8QCPqK30eYnUawmGouTdzp4xiEz2oKFOjTOYuoqgUYqJEdcUqlZDVcymCecovsP7lfF25xYcF+SJwOdSxhDEx+WUva6DABhUg7E/tlOXz22ZLqDmCO+xKdIjCOrcZoasz34W4DmlYJO5mFP3b0gWfiasUn/lTyboOILrac1cGW7tS1K3+IvAHNYCSdAUzA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cgcQN6yFzfJM+XSM+kmV7AB5tv1MEGsd2Kalpkesw3I=; b=OwXCkFXvCTRxlVJVkF3QshH3b1x4NQVjzm5sJgWFOhAOnWETrs109ngjzVyuCImmFPPdLzmcWRmCce3YzQ61MpVeqbWMI+rIKV0a68hZjjzgjN7Gy/L4vLYAU9i6Wl9+yg0SN0l2Zyg1IqBTFham5r6Ow27FJdWQyhwx/ndPUcM= Original-Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by BL0PR10MB2865.namprd10.prod.outlook.com (2603:10b6:208:72::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Sun, 24 Jul 2022 23:40:48 +0000 Original-Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::581b:ae2f:16b9:80fb]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::581b:ae2f:16b9:80fb%7]) with mapi id 15.20.5458.024; Sun, 24 Jul 2022 23:40:48 +0000 Thread-Topic: 28.1; Please move general stuff from `ffap.el' to `files.el' Thread-Index: AdiftsBr0niNzbowSmixwMeCjbAPsA== Accept-Language: en-US Content-Language: en-US x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2c919ae2-3243-46df-4ba2-08da6dcdef9b x-ms-traffictypediagnostic: BL0PR10MB2865:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: bKKgheAoELGCVHRXg4vBOW5DWGJ8YrTaA+lp3OxoF5FGY+DAJTODWoMQBoZwm/q44dx5rA6asZV4dcZZrp5Fy/2rgrVVBPhzEavIOGe3zMfFOHOZ0QHQ3aCSAjp6GYdoDgxKczqljzp8MaZd8Mr2EYH89y3RnbKe8c1ucMvb6mvkwZRn96m6/v2Z2dMgAq02tUIzQ3xfdxXgOzwq0NhQbcNS8QOybkrSq2HBJLq94VHAXdhryPIFQk5gcBk3ByRthaaSiMaHTsfiW5783tmkH3Hsm4T6VtmbALVk+qq/KD+5tO7vunhReqBQF7Ga4H7tGYSK6GhEknaQxCCPH+GwUKly5qi63+nyx3FvchxCNx7Kht+E9YsV2WZE079yh6yU96IaVgDUb8As2nget/9476zL8hv1XceKP7Vm7bv373/al2m9QYOzzngVDoSKCDVF5oZu6RsZraWGwRZi3Nr/O2xjoFZ7DVqF/50dEBfd2c55ZyQ78aNbI53/dFdWnW8CIbmCwYO1wulFYVD+hmWGIf62CJw2xS8V27XSVC0v1izY0G846ZXlMCCqYlmOfZiYN/KlsSLsyx2orqVYfwALWKVydBWBqfat6Lo2x1uuH6Kh5XcsXevY2muUjorqYRo9VgiV0SnbXKz4cHq9x7haSAmQ/KbDoW23st5M55h5yz4MlAVuSNbo213PQmFcCP3WOsRLaV6OS2J5RcSXyIoRL86pKNPpS3XkXj1BXbXsgfizYH7xXDCNuKXoG4rC2 iV7Bmj9YHqBHi3dX80ze9qvmMlfd8f8jO+WWRt+s2Goi6XE/Yx94+uYLXWTGHQSHGhunOqeOvzAf8exvYgghgrUHQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(136003)(346002)(39860400002)(396003)(366004)(376002)(186003)(55016003)(71200400001)(7696005)(6506007)(33656002)(83380400001)(52536014)(8936002)(2906002)(5660300002)(44832011)(478600001)(45080400002)(38100700002)(9686003)(122000001)(316002)(38070700005)(6916009)(66476007)(41300700001)(66556008)(76116006)(66946007)(86362001)(8676002)(26005)(64756008)(66446008)(81973001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: 4cdEhLaMCDnhx6c5TIKEN6/LbbgYaAL9TslJ9Ts9VMLiitEZszuG6tdv2x3v/EHLbyLciV0Bc0g3BFqNuaH/5eEQpwA+aM433uCCjYjbZj+ZXPp/rfbHH4NvHr8g5yJf5kNusc1EWyFebCwkbbdJJJuIMLhLURAjpXGMa3Qx1oT6fdsmt6YG53lSUidGTzsXe1TDDvzGpO/lrNXpCS3FkFbV05dXmqMUBQphgSuaM9RfxBXckgE7QObh2q5VeKO99Ax7AKfBXBpHHPNi501B7bCbwyI/MpJrL669RtOrbiZHjmgijFDDhcyXGxGvAfhd2Zr6jmV4T0DIKmhvJKVkdGTs2vDialYxtkaC8P2b0R2d/RioOAPW8y0mMx4Pa/PSRTdRUC67qjnnuDEo50wnLsyD2vK1uSXrLqP4IMx+lfbvpyH5xbz5bsOZzueE7gWUqF8tUMXJ7tNjQDJhd/3fFmvOARppy36YPeUZLHyFXA7LEkxc1Q+PEeGgg08nptmwVF4j4oLjJ/kz/Y8PJHf+gUQuq7UhexZ7aFzFYHV9gK9DXPu+KPLHAcnQg2Eqha769nTdQw+LjLQ9cljkECGIdwz9UUq9zuCKW94VRwR2pzkd05oOTlDRcc2QYRlR6Mp7ALtuHz9wSJmo7B5xOgv5GosVsO1ZqZXQ7D10PhVYeiSQI4LycsLPgjTdMioMqW60h53+pBqL5LEuIQrzgmTvagmQSpfwAr4YNScC64AZ8WZxn0UINInAsjK7Cx 4qQNFAGotvj2/qYiv/VrCcrAlRY83DWGJTbdYpnQ0FOGDdfv2jieLmDlvHzGEySRYckjHzwOhq16O1kunalYdpCecclGxFq+ZR X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2c919ae2-3243-46df-4ba2-08da6dcdef9b X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jul 2022 23:40:48.1689 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: U6ibNu4ugIsrPr/mOrfgN2f5v4PENS583XaQt6S4BVGZlokx13X1WURVeXsGWUODwHKqtCPFqQI1gW4GuFYswg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR10MB2865 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-23_02,2022-07-21_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 phishscore=0 spamscore=0 mlxlogscore=941 suspectscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207240104 X-Proofpoint-GUID: a5hPmNHn2JNzIEpWUDKCZ6e5XNLVcogM X-Proofpoint-ORIG-GUID: a5hPmNHn2JNzIEpWUDKCZ6e5XNLVcogM Received-SPF: pass client-ip=205.220.177.32; envelope-from=drew.adams@oracle.com; helo=mx0b-00069f02.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:237869 Archived-At: File `ffap.el' includes utility functions that have nothing particular to do with ffap. Please consider moving at least some such functions to `files.el', so that 3rd-party code that want so use them doesn't need to depend on `ffap.el'. One example of such a function: `ffap-all-subdirs' (and its internal helper function `ffap-all-subdirs-loop'). Yes, a library that doesn't want to require `ffap.el' could always get the same effect using more general file utilities - in this case `directory-files-recursively' (matching a vacuous regexp and providing a predicate). But something like `ffap-all-subdirs' is convenient for doing just what it does. `ffap.el' seems to have evolved general stuff in isolation - stuff it uses but which is by no means specific to find-file-at-point. Maybe start by moving a few such functions, even just `ffap-all-subdirs', if you don't want to go to a lot of trouble immediately. In GNU Emacs 28.1 (build 2, x86_64-w64-mingw32) of 2022-04-21 built on AVALON Windowing system distributor 'Microsoft Corp.', version 10.0.19044 System Description: Microsoft Windows 10 Pro (v10.0.2009.19044.1826)