From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gabriel Newsgroups: gmane.emacs.bugs Subject: bug#59165: 29.0.50; [PATCH] Ibuffer directory filter not buffer aware Date: Thu, 10 Nov 2022 06:22:23 -0300 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22044"; mail-complaints-to="usenet@ciao.gmane.io" To: 59165@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 10 10:28:24 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ot3rD-0005bz-WA for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 10 Nov 2022 10:28:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ot3qv-00022Z-2Z; Thu, 10 Nov 2022 04:28:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ot3qt-000227-7h for bug-gnu-emacs@gnu.org; Thu, 10 Nov 2022 04:28:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ot3qs-00083M-U3 for bug-gnu-emacs@gnu.org; Thu, 10 Nov 2022 04:28:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ot3qs-00045e-L4 for bug-gnu-emacs@gnu.org; Thu, 10 Nov 2022 04:28:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gabriel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Nov 2022 09:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 59165 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.166807245915690 (code B ref -1); Thu, 10 Nov 2022 09:28:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 10 Nov 2022 09:27:39 +0000 Original-Received: from localhost ([127.0.0.1]:41887 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ot3qU-000450-RG for submit@debbugs.gnu.org; Thu, 10 Nov 2022 04:27:39 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:41872) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ot3qS-00044s-VQ for submit@debbugs.gnu.org; Thu, 10 Nov 2022 04:27:37 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ot3qS-000203-KN for bug-gnu-emacs@gnu.org; Thu, 10 Nov 2022 04:27:36 -0500 Original-Received: from mail-dm6nam12acsn2080b.outbound.protection.outlook.com ([2a01:111:f400:fe59::80b] helo=NAM12-DM6-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ot3qQ-00080Y-9X for bug-gnu-emacs@gnu.org; Thu, 10 Nov 2022 04:27:36 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dMYDx9qG9x6bAIV9tORRuTbPc2YPIufN2EoeSJeW8JMZQ2z+bMGLG9L6te7RAeUhGNwMG0//bVs2eo7o7OV70KzarPAS19HP92gx9WXxtgGU5F/TPKkTxIX6ObVegElxOM9ET3kpJE6foxq3HcK34hV8v/X4UuArfRy9597UQJiOh74iVofFE2c+zinm4smZgPCC5UAZFzsIeDRIcPXPpUp51k7rnQO5oL5FZFrcaK6qy903/MmBDRzzn28/OVrNYMpEmr1UUYKbk5ziLLu8d+BfZUiuOSVTNlYXopL+4O4Fa3TcICASiMROsdkUCOQEkkQh2N/yl3xyzNed49hP1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6orlE5qj952ZQXhI0uOe5uuvQsF7fNatAZb4ZdYsNpQ=; b=P8DabObkIVuRjFDu8k5WswZqE6G0Vc2aRbsqsjqMbFSQFXQ+bE05W320x6IYGJTyqXoyuDr/jPmg0S2B09I/wkPQDgWr+F3t6bg7J9/oKbsdR1aWEDC12dGdsRp7RkIWA5D5QxxQnKHCmUWCBoRO1vRyt/ZTaUETNvgmPiQ7jwyMGHVrVefB02AA+iycPjPVU7FFX3PXFgWjpcsj4un49ZdKnRSUZPEJhwvpZ5prKG374mqusVcUIqu9Elr15Hry0T+99coS+p/xCgFPQEeYJ+8NZPGJYUP6b+cbOKEPKdaKo/lGGotW1e2mJe1PjCea7IN15ucP1enzIysd31AuHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6orlE5qj952ZQXhI0uOe5uuvQsF7fNatAZb4ZdYsNpQ=; b=s5aOn6LZTjTLnDHNRvSNcAYfhQr//+Ce9hiZ46VTvoKyIBDC5dzsNWLHQaTEXxFG5FXpc5/SOTMtkUWAvEMzl4tldFJE7+OXlBVVQifhWapBpRm83CvkMxRFOOW1SJhfdRZnrW3vkhTaPJiRrJH/LV95I843znTbfTNBvK8gdOySrgoFhDmtCHp0gdyHrZRvpTAHqtk+NW1/u5gElMeEslq7Zu0uk0+BDH4P9yl0ZRNbribpv9pW+rn87leTZyKSPSkmyENXhIxJzhHSrx9UBQl0u3bY+lqhneV9cxWpwKeu1kCGEEVyI9qLnbVQB5oxG0ksG7vSV8+Vzs4UXlMeYw== Original-Received: from SJ0PR06MB8609.namprd06.prod.outlook.com (2603:10b6:a03:40c::11) by BYAPR06MB6040.namprd06.prod.outlook.com (2603:10b6:a03:d0::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Thu, 10 Nov 2022 09:22:30 +0000 Original-Received: from SJ0PR06MB8609.namprd06.prod.outlook.com ([fe80::33ae:d3a7:24ae:5c6f]) by SJ0PR06MB8609.namprd06.prod.outlook.com ([fe80::33ae:d3a7:24ae:5c6f%4]) with mapi id 15.20.5813.011; Thu, 10 Nov 2022 09:22:30 +0000 X-TMN: [8I/YY4vSien2UlPswFiClX7AZSsw9jXkRke6/aZiqrcUc7wbTModpfQgawa1PupQ] X-ClientProxiedBy: CP6P284CA0009.BRAP284.PROD.OUTLOOK.COM (2603:10d6:103:1aa::13) To SJ0PR06MB8609.namprd06.prod.outlook.com (2603:10b6:a03:40c::11) X-Microsoft-Original-Message-ID: <87fserqi40.fsf@hotmail.com> X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR06MB8609:EE_|BYAPR06MB6040:EE_ X-MS-Office365-Filtering-Correlation-Id: 71684854-4d06-4fde-f925-08dac2fd16a9 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sCTTIFwE2u9+B6aY+ypckkNnY0Bnf9o0S90/OQwhvkFyAAcpH+MJMLGQAr6kkGhcueTZ3fyHrWAmoSMvVaciK6Wo4t5CYLuAJzKT3fdvUn3HZ8lVOwSbTdpzHbejzjaTIn+WKbwS6AOMlsU0IzqdG16gXcRmxIO6ATjqNoYp7Q6Te8C7uWtQUpdWdrz9q6OogN/zE/2+hu8VAYMwaA/INhoJwuLTt2vuZTJpTCpqoQXwCWEmNMjErYh7Hydi2BZPXZejqnGh9QS+2yDjKwvdv698zCSpBRmItb3VC5YRmgn09UNbWFJNMeTTr/Ox7LKW4zFePV8+uwHkVS0qvVyEk9HfqAPcjv2iHGvS8wUpxfo9oyjzYBlJYfvkveqzAXL3c+Ahk16VlXQQJ+mkOnRU6dkLYtgiaj9PdeHGa8sJ25s+1EBRd2waztHBAHogLyviutLHf0Beo2dpzPb88JK5U9wsEfXIAbXAUqpQGrXrY/NAh9QowPu3UnIBoQqbB9AQZCQrNcLSstPwuU+rKpbxv18/lbI1KxnzrPyRrDpXaAHFNsfS1XaTxUD6rV09ZRakm1qLPbNzVD0FnpDUgV2j5H7saf3b1YgvyegYZupl0rdLE0ftZDzuq5gdiPxzBcW4 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: rfxlknr3cgvNQQbl5k9ILXwgPv2/cj9n5GDpeSXq07yZsuJDHJZJDS30LOB1YO7Z82fRm5SeCFaHscKl0nXavFw3S+bOnh30s1EpfeM/jTaOV+aWqtDWCe+W5YgMNN0d+yOZgUAeigV8n65sonb5Qbh5VH4JaEyWX3f+ePJmRmvK1VSjjFQdQH471y+xlheqBz6smSX5XWMKdipk92HQBmiRgfpAyi5NIBOIVReJ2We568MlNwVaX2H8uelmTUVNNA5c5JySfvR0YVq2g4cTyG0fULIDbGOjyl/+COh1HI5NaBgJuopjLx1ub1oyzFPaaccC9WYl9j07Dp/KCVsg96ehxioErVyPU3qJECctOGdgQmGDhmZSzH4OdHlMHQKpu581wv9Hxh2VgI3MVuARYqUlpRQM/rVnGfY9K2vHNR7sIQEhIoFfmiUid6ani/UeqRSVZzATd4KOgS2dtYWRA69C3IRshhJABcpslVHJngctji9RvbCn62t+GbbVJkveMkBHzoa/foFWf/8V4QBM7tft81FjMw1GFlij7fVfMmJmVNTiTSwq8+/46MILom+ZxxSMoswPCVS9kb7MmG/f4E96kjCG/fqeNIChfe2YkMlU681VLF2Tz7kZyBH2NCtbTbdPyn6EUJV1ngl03qyozdet5txLU64aSf/LJmmwEB1t7g+blyn+LZKXzqfwXt255+qoct/5+m2llkUjp65IVFFtRn0EbtJMKV9HGIxui6aJS2MeUs2b+reQ6x m2LL7S/g6sebUqAMh1K/dCaTlJJ5V6abJ/dA2UK79nGfsFdH8Kk6JiYfHXp7u50q4Da4xO7c+j4rHiqCYVx5MhZRrQY5qYq/sv X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-89723.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 71684854-4d06-4fde-f925-08dac2fd16a9 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR06MB8609.namprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2022 09:22:30.6987 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR06MB6040 Received-SPF: pass client-ip=2a01:111:f400:fe59::80b; envelope-from=gabriel376@hotmail.com; helo=NAM12-DM6-obe.outbound.protection.outlook.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247495 Archived-At: --=-=-= Content-Type: text/plain Description: The ibuffer directory filter is not buffer aware for buffers not visiting files. This bug seems to be introduced by commit 3ef18c7a213, which made the `default-directory` no longer run within `with-current-buffer`. Steps: 1. emacs -Q (29.0.50 master d04433b96215d7d3387573f19cc315de86f2341a) 2. M-x dired /home/myuser/foo 3. M-x compile ls -lha 4. M-x ibuffer 5. / F /home/myuser/foo Expected: filter is applied and two buffers are shown: `foo` and `*compilation*`. Actual: only buffer `foo` is shown. Patch: Below there is a proposed patch. I did a quick inspection and could not find similar regressions in other ibuffer filters. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Make-ibuffer-directory-filter-buffer-aware.patch >From 94e2f3f37b1d807af50c9014b57d24661fb3c5bd Mon Sep 17 00:00:00 2001 From: Gabriel do Nascimento Ribeiro Date: Thu, 10 Nov 2022 06:11:03 -0300 Subject: [PATCH 1/1] Make ibuffer directory filter buffer aware * lisp/ibuf-ext.el (define-ibuffer-filter): Make ibuffer directory filter buffer aware for buffer not visiting files. --- lisp/ibuf-ext.el | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/lisp/ibuf-ext.el b/lisp/ibuf-ext.el index 6b5cccec51..adffef4325 100644 --- a/lisp/ibuf-ext.el +++ b/lisp/ibuf-ext.el @@ -1336,10 +1336,12 @@ directory matches against the value of `default-directory' in that buffer." ( :description "directory name" :reader (read-from-minibuffer "Filter by directory name (regex): ")) - (if-let ((it (with-current-buffer buf (ibuffer-buffer-file-name)))) - (when-let ((dirname (file-name-directory it))) - (string-match qualifier dirname)) - (when default-directory (string-match qualifier default-directory)))) + (with-current-buffer buf + (if-let* ((filename (ibuffer-buffer-file-name)) + (dirname (file-name-directory filename))) + (string-match qualifier dirname) + (when default-directory + (string-match qualifier default-directory))))) ;;;###autoload (autoload 'ibuffer-filter-by-size-gt "ibuf-ext") (define-ibuffer-filter size-gt -- 2.34.1 --=-=-=--