From: Gabriel <gabriel376@hotmail.com>
To: 59165@debbugs.gnu.org
Subject: bug#59165: 29.0.50; [PATCH] Ibuffer directory filter not buffer aware
Date: Thu, 10 Nov 2022 06:22:23 -0300 [thread overview]
Message-ID: <SJ0PR06MB8609E4437601203C2F04925A8B019@SJ0PR06MB8609.namprd06.prod.outlook.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 650 bytes --]
Description:
The ibuffer directory filter is not buffer aware for buffers not
visiting files. This bug seems to be introduced by commit 3ef18c7a213,
which made the `default-directory` no longer run within
`with-current-buffer`.
Steps:
1. emacs -Q (29.0.50 master d04433b96215d7d3387573f19cc315de86f2341a)
2. M-x dired /home/myuser/foo
3. M-x compile ls -lha
4. M-x ibuffer
5. / F /home/myuser/foo
Expected: filter is applied and two buffers are shown: `foo` and
`*compilation*`.
Actual: only buffer `foo` is shown.
Patch:
Below there is a proposed patch. I did a quick inspection and could not
find similar regressions in other ibuffer filters.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Make-ibuffer-directory-filter-buffer-aware.patch --]
[-- Type: text/x-diff, Size: 1406 bytes --]
From 94e2f3f37b1d807af50c9014b57d24661fb3c5bd Mon Sep 17 00:00:00 2001
From: Gabriel do Nascimento Ribeiro <gabriel376@hotmail.com>
Date: Thu, 10 Nov 2022 06:11:03 -0300
Subject: [PATCH 1/1] Make ibuffer directory filter buffer aware
* lisp/ibuf-ext.el (define-ibuffer-filter): Make ibuffer directory
filter buffer aware for buffer not visiting files.
---
lisp/ibuf-ext.el | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/lisp/ibuf-ext.el b/lisp/ibuf-ext.el
index 6b5cccec51..adffef4325 100644
--- a/lisp/ibuf-ext.el
+++ b/lisp/ibuf-ext.el
@@ -1336,10 +1336,12 @@ directory
matches against the value of `default-directory' in that buffer."
( :description "directory name"
:reader (read-from-minibuffer "Filter by directory name (regex): "))
- (if-let ((it (with-current-buffer buf (ibuffer-buffer-file-name))))
- (when-let ((dirname (file-name-directory it)))
- (string-match qualifier dirname))
- (when default-directory (string-match qualifier default-directory))))
+ (with-current-buffer buf
+ (if-let* ((filename (ibuffer-buffer-file-name))
+ (dirname (file-name-directory filename)))
+ (string-match qualifier dirname)
+ (when default-directory
+ (string-match qualifier default-directory)))))
;;;###autoload (autoload 'ibuffer-filter-by-size-gt "ibuf-ext")
(define-ibuffer-filter size-gt
--
2.34.1
next reply other threads:[~2022-11-10 9:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 9:22 Gabriel [this message]
2022-11-10 9:36 ` bug#59165: 29.0.50; [PATCH] Ibuffer directory filter not buffer aware Eli Zaretskii
2022-11-11 0:49 ` Stefan Kangas
2022-11-25 1:16 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR06MB8609E4437601203C2F04925A8B019@SJ0PR06MB8609.namprd06.prod.outlook.com \
--to=gabriel376@hotmail.com \
--cc=59165@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.