From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gabriel Newsgroups: gmane.emacs.bugs Subject: bug#59443: 29.0.50; [PATCH] Allow goto-address-at-point to use secondary browser Date: Mon, 21 Nov 2022 08:45:26 -0300 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18606"; mail-complaints-to="usenet@ciao.gmane.io" To: 59443@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 21 12:46:11 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ox5Fa-0004g6-Tj for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 21 Nov 2022 12:46:11 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ox5FV-0003I5-BK; Mon, 21 Nov 2022 06:46:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ox5FS-0003H4-Hm for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2022 06:46:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ox5FS-0007eY-9O for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2022 06:46:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ox5FR-0001tb-SE for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2022 06:46:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gabriel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Nov 2022 11:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 59443 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16690311437255 (code B ref -1); Mon, 21 Nov 2022 11:46:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 21 Nov 2022 11:45:43 +0000 Original-Received: from localhost ([127.0.0.1]:45578 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ox5F8-0001sx-Kl for submit@debbugs.gnu.org; Mon, 21 Nov 2022 06:45:43 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:36676) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ox5F4-0001sm-6f for submit@debbugs.gnu.org; Mon, 21 Nov 2022 06:45:40 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ox5F3-0002w1-S8 for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2022 06:45:38 -0500 Original-Received: from mail-bn8nam11olkn2010.outbound.protection.outlook.com ([40.92.20.10] helo=NAM11-BN8-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ox5F1-0007Uo-AS for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2022 06:45:37 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CmJyomdDw/OjcskHPRjgwRl5Mlg4217EDpMIovmNSzm92Bv+WGobW2u3qOLjmlTjU/9dhkiPyasBEGHodNq6aFrUE0wAfHTAvQXggqN9Qp51WalgyutVls8gR9nXrST9OKmYUU7BCIS25EnHX+ULXMQw+3INVO6nVzvsYQDGhmasRyuQe00nf5snzAbi1CCqRuAkqbY5li2rZyXn08ZJJR+FohHYfIGrxbLg2uBt65b6j9aQez6PwtRBMYl7EbgD0ae7B/Hn8BThI5Eyri62rsW0HTtNlvb/WGjcBYPf1cMh20B1zkWq0zFerZh7O03FVuFGOQdX3ILK/znoOSnH6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3moIPS1gvYnDXOMYdbWfeCrJMi+COtLBCXiHqUinnE4=; b=ccKsaXRJfTkGsMSEavXrdAJw+koDyiW3PLC2l11VMt82YO/16idKXwaiZm051GoyvsrM9NctWI2GdPzLRH/NpfJdOBxQFqFIgXxYzQFUFsOA9CzxRNCnIiItwMP4IjkMm2eS2NFIFLhKYv1ZfX+ZEfN4Aj2+wZFDV6xSXHA372TKSuVpZ+HRhukBpfrInp0c11DwOJRtqocAsks1CGj6CpI+hvtJtENIGSRK0AMxk+xTS/hLdYkbIGEph5t/oOkoh/NUBrUDH6c/O/RzF24P0DsJilvyIcS9PR4eK+BQZauCae0o7x7Gm/j7F9puqZxeV5EFsZtI7R+xQTUqxnuOEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3moIPS1gvYnDXOMYdbWfeCrJMi+COtLBCXiHqUinnE4=; b=p15a50aVwnqiM6ZV+Gft3rQtnv2I4CWXAhYqce05bzvhrNKDeN8Yqc6y35SY3HkgfJ1iRqvdXANCNsU2Fj6Hf+yg87D3eu8HpcOQQu9IHI4XZ8erMhwlGIauMY1/WjBSU/6AG1Ba9vjcdFx2DP5F7qw9S2Bqjx9UjFN/rDXcHt134V0HWAPnpgGMGNUxuhZmvsxqUyKmkoS7vyZkYLRAcgf596WXyqQYbxFDyHzPpiB5tBay8rzGnRPaSjFwrslaJ8dpNoJ54aD/hR5YJ5LLL1c/ePLWP8GDVkX/hPRGsTThsQ6ABaxo+BcdQuGzrdCfXKThU497njUGAtSDn0aVMA== Original-Received: from SJ0PR06MB8609.namprd06.prod.outlook.com (2603:10b6:a03:40c::11) by BN6PR06MB3267.namprd06.prod.outlook.com (2603:10b6:405:46::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Mon, 21 Nov 2022 11:45:32 +0000 Original-Received: from SJ0PR06MB8609.namprd06.prod.outlook.com ([fe80::33ae:d3a7:24ae:5c6f]) by SJ0PR06MB8609.namprd06.prod.outlook.com ([fe80::33ae:d3a7:24ae:5c6f%4]) with mapi id 15.20.5857.017; Mon, 21 Nov 2022 11:45:32 +0000 X-TMN: [F8zjMYbHI1xu1fuFqjgp1+VZPyp8VSofjxyJvIiKLmofFJL/wQxnCjaUEhDjWvhV] X-ClientProxiedBy: CPXP152CA0013.LAMP152.PROD.OUTLOOK.COM (2603:10d6:103::25) To SJ0PR06MB8609.namprd06.prod.outlook.com (2603:10b6:a03:40c::11) X-Microsoft-Original-Message-ID: <87pmdgttt5.fsf@hotmail.com> X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR06MB8609:EE_|BN6PR06MB3267:EE_ X-MS-Office365-Filtering-Correlation-Id: 6e9df118-b0ca-4ad8-efd4-08dacbb5e508 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vdASrFPeHIMy8iZdN2UXNqTCLKv/+uYuok5WOGObxCmoTCQQ4xeo1CKjkJeIuarRzxkBjdnEKNeyp9tczDEW89Z05hRncrAt/MN+i3Ewt0Yirj7xonuWZ3ZoNeQVBtdfWexmuWL+Mdu40AHAutnZHuwTUu6Z81BWhmFnIFFlod7IT6OorrQTmjacDN3L4KLwdBCSyUen5q4OxH1yt+78ccp7lFs5G4pO/2C/1Wa5KHZr9BOMZjBEHXtlRb7ucv5nft8l1BBSvlRvKEgsrp2KmqGnCiymwDCQUjbI0ABU5Tz+OaG/QAukW7PKxpCawsKXUzXPUYF3LpFy6nzJDizNrLJcprolGSMqP73tO20nvjcO+/30NZAnFvsBpvGD+cILN+W10EcGogsNKhz7OM2B6UY9U9Z71tzMVzs+8AYriUQPN9CVfdM4wx884wX2hIYhdeRAY4dMwmX4oh1pv7H6Gkl1vjUv6e5o2kYdJzHourOPxj9HxHyvJYAjCCrXDqEUmvZhOz7e9d0k8nKScCJdqp/ED/bLMGq4smaHV85bXbK/9TY5ZrY2WWIt4+nuB0ZN6UBGnZqQwAl0AEtmLpNIVCiATk2YlBrfKy3W9QNmfNw= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Y7+rtuEwoax0sxo8itPzVgKr4i4kxAvxuv2eTTYkLz1t2GWmwZ6O7Oomw/JlUwhQBGRPqKTIng+nrdg6Wu/A7XFJuVLgD7NQdazAdfTOYcvSUwhVsixYuRHANOT2oVhJtBV3yp2zovn4s/faDaghxDD0J0RpN9VVnMM2CZLtQ2rVv0FQSj+FeVWohg2r3rIDcSkAcY5wrmv9zUbtRl6xRNkUE4sPATsoRCrDT35dnHHkunieUBKuBv8qknWM43/dW3aQ2fZwRm/n8+vlBL556NzXR8LsdAPXe3+N9JWKAo7Evbe5EH5n0oWf1kCoCSbPlNbYjtmTRXPeJ9yTJapEBTWtmZ26u7jX78m3lWsvyjiWocWs2QfUoK2H/wGz5Q/JLgSehfiVdR6xxT017fQ+HTkN+7jScIahwnW1wxgNI7O9L7Sxd2aW94LbTOaQvVNOw6na8gPfogqtwGjg/AfKvE0ehnLgpzF3LQoZ+Z3amUa9Nl+cSqxMS7h2hAP2YzD5x5qVAg0/RRzclrklHsbfiF4YKVqlijQYN7w2Q27Jy7tMzi/HB+POq0UBYSigcVLprNSRqoTSWl5c0SCWBYYl1Q9XGlgSaB8dUthDzptPbefQ59BBGTby7Aay9OWHx6iAQ5TOISeuWtr5CdzMC6VgjZNJHhoiSueMBh/owny0qGGgsybBEb53faTuDdAUt51PeJnzkdbGeo79LzCZIIWxCGEZAI4HvgQGfeGhzAEkXvYzwppL8JM9yj/QGT 9mQ8+5Q21Ne0u83XwQV574FAi2Pqqy1zyYGIM4ZN5jgNsEipJV4IQxLn0KxGw7cC4faNJ5XAGN1685Ea2OGtvzZaeLDbPB5XTh X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-89723.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 6e9df118-b0ca-4ad8-efd4-08dacbb5e508 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR06MB8609.namprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 11:45:32.3735 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR06MB3267 Received-SPF: pass client-ip=40.92.20.10; envelope-from=gabriel376@hotmail.com; helo=NAM11-BN8-obe.outbound.protection.outlook.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248514 Archived-At: --=-=-= Content-Type: text/plain Description: When `goto-address-mode' is enabled, it's not possible to make "C-c RET" (`goto-address-at-point') open an URL with `browse-url-secondary-browser-function`. Steps: 1) emacs -Q (master "6b0179f7908c658342d1e642e5444e3d2e1cd997") 2) eval (progn (require 'browse-url) (setopt browse-url-browser-function #'eww-browse-url browse-url-secondary-browser-function #'browse-url-default-browser) (scratch-buffer) (goto-address-mode)) 3) Insert "https://www.gnu.org/software/emacs/" in the *scratch* buffer 4) Put point at URL and execute C-c RET (`goto-address-at-point') Result: `browse-url-browser-function' opens the URL with the default browser function. It's not possible to specify the use of the `browse-url-secondary-browser-function'. A proposed patch is attached. The prefix argument will not affect the argument CONTINUE of `compose-email'. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Allow-goto-address-at-point-to-use-secondary-browser.patch >From bfcd2ccb83a94fa1ba99db84cf55e88584fc25d1 Mon Sep 17 00:00:00 2001 From: Gabriel do Nascimento Ribeiro Date: Mon, 21 Nov 2022 08:08:52 -0300 Subject: [PATCH 1/1] Allow goto-address-at-point to use secondary browser * lisp/net/dictionary.el (goto-address-at-point): Call `browse-url-button-open-url', so a prefix argument uses `browse-url-secondary-browser-function'. --- lisp/net/goto-addr.el | 31 +++++++++++++++++-------------- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/lisp/net/goto-addr.el b/lisp/net/goto-addr.el index 86cf98004b..86b8fed362 100644 --- a/lisp/net/goto-addr.el +++ b/lisp/net/goto-addr.el @@ -222,25 +222,28 @@ goto-address-fontify-region ;;;###autoload (defun goto-address-at-point (&optional event) - "Send to the e-mail address or load the URL at point. -Send mail to address at point. See documentation for -`goto-address-find-address-at-point'. If no address is found -there, then load the URL at or before point." + "Compose a new message to the e-mail address or browse the URL at +point. + +If no e-mail address is found at point, use the URL at or before +point. See `goto-address-find-address-at-point'. + +With prefix argument, use the secondary browser to open the URL. +See `browse-url-button-open-url'." (interactive (list last-input-event)) (save-excursion (if event (posn-set-point (event-end event))) (let ((address (save-excursion (goto-address-find-address-at-point)))) (if (and address - (save-excursion - (goto-char (previous-single-char-property-change - (point) 'goto-address nil - (line-beginning-position))) - (not (looking-at goto-address-url-regexp)))) - (compose-mail address) - (let ((url (browse-url-url-at-point))) - (if url - (browse-url url) - (error "No e-mail address or URL found"))))))) + (save-excursion + (goto-char (previous-single-char-property-change + (point) 'goto-address nil + (line-beginning-position))) + (not (looking-at goto-address-url-regexp)))) + (compose-mail address) + (if-let ((url (browse-url-url-at-point))) + (browse-url-button-open-url url) + (error "No e-mail address or URL found")))))) (defun goto-address-find-address-at-point () "Find e-mail address around or before point. -- 2.34.1 --=-=-= Content-Type: text/plain --- Gabriel --=-=-=--