bug#59443: 29.0.50; [PATCH] Allow goto-address-at-point to use secondary browser

[Gabriel <gabriel376@hotmail.com>]

[-- Attachment #1: Type: text/plain, Size: 893 bytes --]

Description:

When `goto-address-mode' is enabled, it's not possible to make "C-c RET"
(`goto-address-at-point') open an URL with
`browse-url-secondary-browser-function`.

Steps:
1) emacs -Q (master "6b0179f7908c658342d1e642e5444e3d2e1cd997")

2) eval
(progn
  (require 'browse-url)
  (setopt browse-url-browser-function           #'eww-browse-url
          browse-url-secondary-browser-function #'browse-url-default-browser)
  (scratch-buffer)
  (goto-address-mode))

3) Insert "https://www.gnu.org/software/emacs/" in the *scratch* buffer

4) Put point at URL and execute C-c RET (`goto-address-at-point')

Result: `browse-url-browser-function' opens the URL with the default
browser function.  It's not possible to specify the use of the
`browse-url-secondary-browser-function'.

A proposed patch is attached.  The prefix argument will not affect the
argument CONTINUE of `compose-email'.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Allow-goto-address-at-point-to-use-secondary-browser.patch --]
[-- Type: text/x-diff, Size: 2446 bytes --]

From bfcd2ccb83a94fa1ba99db84cf55e88584fc25d1 Mon Sep 17 00:00:00 2001
From: Gabriel do Nascimento Ribeiro <gabriel376@hotmail.com>
Date: Mon, 21 Nov 2022 08:08:52 -0300
Subject: [PATCH 1/1] Allow goto-address-at-point to use secondary browser

* lisp/net/dictionary.el (goto-address-at-point): Call
  `browse-url-button-open-url', so a prefix argument uses
  `browse-url-secondary-browser-function'.
---
 lisp/net/goto-addr.el | 31 +++++++++++++++++--------------
 1 file changed, 17 insertions(+), 14 deletions(-)

diff --git a/lisp/net/goto-addr.el b/lisp/net/goto-addr.el
index 86cf98004b..86b8fed362 100644
--- a/lisp/net/goto-addr.el
+++ b/lisp/net/goto-addr.el
@@ -222,25 +222,28 @@ goto-address-fontify-region
 
 ;;;###autoload
 (defun goto-address-at-point (&optional event)
-  "Send to the e-mail address or load the URL at point.
-Send mail to address at point.  See documentation for
-`goto-address-find-address-at-point'.  If no address is found
-there, then load the URL at or before point."
+  "Compose a new message to the e-mail address or browse the URL at
+point.
+
+If no e-mail address is found at point, use the URL at or before
+point.  See `goto-address-find-address-at-point'.
+
+With prefix argument, use the secondary browser to open the URL.
+See `browse-url-button-open-url'."
   (interactive (list last-input-event))
   (save-excursion
     (if event (posn-set-point (event-end event)))
     (let ((address (save-excursion (goto-address-find-address-at-point))))
       (if (and address
-	       (save-excursion
-		 (goto-char (previous-single-char-property-change
-			     (point) 'goto-address nil
-			     (line-beginning-position)))
-		 (not (looking-at goto-address-url-regexp))))
-	  (compose-mail address)
-	(let ((url (browse-url-url-at-point)))
-	  (if url
-	      (browse-url url)
-	    (error "No e-mail address or URL found")))))))
+               (save-excursion
+                 (goto-char (previous-single-char-property-change
+                             (point) 'goto-address nil
+                             (line-beginning-position)))
+                 (not (looking-at goto-address-url-regexp))))
+          (compose-mail address)
+        (if-let ((url (browse-url-url-at-point)))
+            (browse-url-button-open-url url)
+          (error "No e-mail address or URL found"))))))
 
 (defun goto-address-find-address-at-point ()
   "Find e-mail address around or before point.
-- 
2.34.1


[-- Attachment #3: Type: text/plain, Size: 13 bytes --]


---
Gabriel