From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#18093: [External] : Re: bug#18093: 24.4.50; `delsel.el' fixes for use with `completion.el' Date: Sun, 24 Jan 2021 00:52:24 +0000 Message-ID: References: <592101d8-bb6f-4ee3-ae58-e28f0126f09a@default> <8735yrtj2i.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14588"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "18093@debbugs.gnu.org" <18093@debbugs.gnu.org> To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 24 01:53:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l3TeQ-0003gx-3f for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 24 Jan 2021 01:53:10 +0100 Original-Received: from localhost ([::1]:37006 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l3TeP-00042K-5s for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 Jan 2021 19:53:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42908) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l3TeI-00042C-7l for bug-gnu-emacs@gnu.org; Sat, 23 Jan 2021 19:53:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52336) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l3TeH-0005bV-WB for bug-gnu-emacs@gnu.org; Sat, 23 Jan 2021 19:53:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l3TeH-0002U6-Tq for bug-gnu-emacs@gnu.org; Sat, 23 Jan 2021 19:53:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Jan 2021 00:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18093 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 18093-submit@debbugs.gnu.org id=B18093.16114495599519 (code B ref 18093); Sun, 24 Jan 2021 00:53:01 +0000 Original-Received: (at 18093) by debbugs.gnu.org; 24 Jan 2021 00:52:39 +0000 Original-Received: from localhost ([127.0.0.1]:35649 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l3Tdv-0002TT-6m for submit@debbugs.gnu.org; Sat, 23 Jan 2021 19:52:39 -0500 Original-Received: from aserp2120.oracle.com ([141.146.126.78]:36780) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l3Tdt-0002TF-0L for 18093@debbugs.gnu.org; Sat, 23 Jan 2021 19:52:37 -0500 Original-Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 10O0iVJt033331; Sun, 24 Jan 2021 00:52:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=/TQa26shhZ92YC3aejaVDnuFvbbZ+WlYag6EJeIY6Sc=; b=v27Vl+dt5ioIV/g5senaORaynSeRt2yfUbbf0Y9a1XnTcDtjGyTppMF6A3xIFDlOeBcg aUQROug+VmJn0C5JT46ffwd45kJ/uCeSRVbiHGuG2UkttmNKo/IRiH4/aG169DybfdqI AqXsGicggbPvHSa63hSVjUsgHjOS/xskevTOR5KvR6aqQnzJpwDLfo3oZMObcCcbaT5d jZ3TbdLrX9zAwEaYVWcyXtv8JJYPH2R/Qhs2vsimY7KUXAmAFYRFjQfbXh6TW1L3GxMT RubUzcxERIJtPy1U8HQd875lLsDU19LwmOrQU0wkF1+/z70+pGxdu3+sHptGUs4m1mbN Rg== Original-Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2120.oracle.com with ESMTP id 368brk9ksn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 24 Jan 2021 00:52:28 +0000 Original-Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 10O0jCYo005517; Sun, 24 Jan 2021 00:52:27 GMT Original-Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2176.outbound.protection.outlook.com [104.47.56.176]) by userp3020.oracle.com with ESMTP id 368wjn94nq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 24 Jan 2021 00:52:27 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TNK89+YsICDkoslXkfqsKgscGRGyL7o/Tp/x4dwUnEnvbmYGEjez3Gn8niW4/IhkRKukFp8bED0loEG6Ar1KWzhT8yVQ4uKiIBtCRz2ma+DyssRXUmz79AUk0Xw6jzGiOrF4zP7jfZNPSXKzRIu4mi8Kw2wMcEsLRDBjWJ+r3eoH0hurlxPv//ZbVsRHEn+WSkfrUE9otQZzIcHLF9Fpylrch8sR4rIGwxPKVMJSJuiLYjpfo1ISPXh7r9ZkQmbsUQjSZVoAmPA4u4JtPKor9khFlKoDJ/A664jV5LYHgHtRRV2OzdtffnK3viWvzmajJQ1rnaQBebAq0sKDdsYVRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/TQa26shhZ92YC3aejaVDnuFvbbZ+WlYag6EJeIY6Sc=; b=S53Jfy7bDvc+iYC3PLZzT42wV/Wc5Orzo9/XjodX/LeXwwzin7RIsXVje5AZunUzP0Wt2QlRqBgJRn9dV9m4d3yX7zHHktyfxaOnTD+t3uzBBWnPz2ubxWvGwyl2j0P7vXPgtMDeQ6jQPpn6oNnMXGpfWAVgBbbgvL3phmGR32oBpzwMu8tqUUUgIEmBQoQzN4yZ6LJtzS6T+viBUYeaBQZUvM9O0gh/iCt9n4GMyrrBXa5LrbEjp9jxuh1RaRjWhonLYO86pNeYxs73wNCVpMfDU14DZJAS+4tQ1H+PzYm2h2GG2PmuZUve3jJGI6JFgpA9N3ymMpzzO/8jMKLsnQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/TQa26shhZ92YC3aejaVDnuFvbbZ+WlYag6EJeIY6Sc=; b=XoKsMyl0/14AIT2WvUXQCbRP5tZ+s8z1ajWlNYL5xNMMYHRketYha4vokW5FJnanjNTolSmpctwuyOnAULZpeUe0mer/LXhUu6L+eirucQezmri2U2NmBG+uFmaxqMW/dYU4LwUhRL5W3kMICgphr5Fgo5XqnPuGWA4l3b4qCE8= Original-Received: from SA2PR10MB4474.namprd10.prod.outlook.com (2603:10b6:806:11b::15) by SA2PR10MB4523.namprd10.prod.outlook.com (2603:10b6:806:113::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3784.13; Sun, 24 Jan 2021 00:52:24 +0000 Original-Received: from SA2PR10MB4474.namprd10.prod.outlook.com ([fe80::dc4d:9cd0:2010:daa2]) by SA2PR10MB4474.namprd10.prod.outlook.com ([fe80::dc4d:9cd0:2010:daa2%7]) with mapi id 15.20.3784.016; Sun, 24 Jan 2021 00:52:24 +0000 Thread-Topic: [External] : Re: bug#18093: 24.4.50; `delsel.el' fixes for use with `completion.el' Thread-Index: AQHW8dJvIi9/i+z4Uku/7Aa8GIKu0Ko17hmg In-Reply-To: <8735yrtj2i.fsf@gnus.org> Accept-Language: en-US Content-Language: en-US authentication-results: gnus.org; dkim=none (message not signed) header.d=none;gnus.org; dmarc=none action=none header.from=oracle.com; x-originating-ip: [73.170.83.28] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 35f6ffd0-a2a5-41eb-a054-08d8c002504f x-ms-traffictypediagnostic: SA2PR10MB4523: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ROJ3V28XVUFcGJM7SS6oCEwxS8oVgt+JRfeBYqpHmx5NKnIH1bk/JocIix8oFcaIq7dyzQIxc9J7bzOlGFu1ornJN7FDAcVpoJUQAQgbclfafkduQGvKtyJ9hFB3nY1vDzYn+iHsMCz6fbGA63mfvqMKrOyfOfaLaGokNnAHpvEaKMRuorQ37vZ4rrhMQR0/kaImMw2LqXHCBlmTZI1j7D5TyXdhEW8QQe8wyJpiFnZKpy3QhDszKcjAecKLvKEi17fdOzC3Dbh/qCbNBSKYNZFe9wCGXxBUWANfp6pn9RLgfqAJktUnh1K7nPsPhBMf8qT0Wl2UtRJyTYHOvoMWEGI5ajzzxOqiNNq9lVTU3X25r9NX3NTn+rB5reN1dYesRdF1QGZkkDbg3dJQl6IeHi+ScjuROK+lyiPTjes8+ddbW6blyQXXsWlvkPW3FBQR x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA2PR10MB4474.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(346002)(376002)(39860400002)(396003)(136003)(316002)(6506007)(71200400001)(83380400001)(8936002)(2906002)(186003)(8676002)(26005)(44832011)(7696005)(86362001)(66946007)(33656002)(76116006)(9686003)(478600001)(55016002)(52536014)(4326008)(66556008)(66446008)(5660300002)(6916009)(66476007)(64756008)(81973001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: KCXn/MLg8elvTO06CRxOenBRbInSZPP3lM9lJAaEd8hRPH3DdDUVEVtYQ/0cPXEcI/xwYm8UNugHodU8xXu5ClcCyQ08QaJH+hcb7j0yIA9uZBKG5y2rawPGabQHSRtBbNd2WbTzAb37CPZpWss0pV07jOoo43LWoM0qs7YyMFEFMwlDHL6pamn56cFyk7rRq/7pxzPdINiWks6xxoU5UwQKmnIA5Gjy3VRBK9DQqPVjZgBqUreFBUH2Gf9rjimNflGroUejVOt7/lEqLT2xE7iZ/JfMKa5+/ac4hY+9mUo3ASoHGmmdjmY9PM3atwBsh3RgO/kfTghnHjZ+dGr8F7mWuLMRyDcgC3hGOl67bsjDi9vkgT9MZ98HaOSTIgLl28ytyeio65MBSs1s/9JAKltMkS5bTipWEVVrvQiaxTEiPa1PpFCB5xXqpU+ITy8Usi6I5UmXjakQ+JonO6pzVw/2alUjCQcetY1SIErxSAr+S0DnUmEuh66zP3Nzf9A/xiyXqa2ZRlURroRLoQBZ0xCzUGqCWZbywHNUB/DZQt5S/2tj1lSeB6LduPqUg9KvISbLDwISm91q1mNFhyYyZPIoJn24onOQwAyD5UFqiLJ8fCnlaStbA1Dktogk7r48vhdji9FhaqcZP047WSqgygpYJapEVBrzA/+V0DPa1xxs/1h/qWHYZX+TP4mJX8+EjTymz6gSIfUn/wuR1NVOW+RDMOwto5BnrvhgOf1hrFMRvzvIuAmYYn24hUyx fSxwRYrGsc/klZR0SzVfUau+CWEAAGR5M9qqeRVtAap+YdMo6Z38Ux6FXLHZlgs8X5G0iukQtoGpfkJ9l/aAg5srac7JQ97eEO x-ms-exchange-transport-forked: True X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA2PR10MB4474.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 35f6ffd0-a2a5-41eb-a054-08d8c002504f X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jan 2021 00:52:24.1215 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: v3BBrkeFFGoMpBGzAiQBbn8M3l/cka4GSYuFNgcXERGcjlX3iY9jp+KqkUbsHWNLvQDJd3kq0Yu9yPYK8zgXTA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4523 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9873 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 suspectscore=0 adultscore=0 mlxscore=0 malwarescore=0 spamscore=0 mlxlogscore=999 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2101240004 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9873 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 impostorscore=0 phishscore=0 bulkscore=0 priorityscore=1501 mlxlogscore=999 lowpriorityscore=0 spamscore=0 mlxscore=0 suspectscore=0 malwarescore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2101240004 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:198489 Archived-At: > > `delsel.el' should be updated to play well with library `completion.el'= . > > The following should be done (or equivalent): > > > > 1. > > (put 'completion-separator-self-insert-command 'delete-selection t) > > (put 'completion-separator-self-insert-autofilling 'delete-selection t) > > > > 2. If `last-command' is `complete' and `this-command' has > > `delete-selection' property `supersede' or `kill', replace the last > > inserted completion with the string that was completed. > > > > (defun delete-active-region (&optional killp) > > (cond ((and (eq last-command 'complete) ; See `completion.el'. > > (boundp 'cmpl-last-insert-location)) >=20 > As far as I can tell, 1) doesn't exist any more, and I'm not quite sure > I understand 2) (I've never used delsel mode). >=20 > Is this something that still needs work, or has what this bug report is > about been fixed in the years since it was filed? Yes, Emacs 25 changed `completion.el' in this regard when it ___ed `delsel.el' in order to accommodate electric whatever (`electric--after-char-pos' seems to be the place that `completion.el' was affected. I have no idea anymore what needs to be done now, to fix the problems reported by this bug. Sorry. Someone familiar with the changes made to `delsel.el' and `completion.el' back in Emacs 25 for accommodating whatever electric toy was involved will need to take a look. This is what happens when someone adds a feature (or even fixes a bug) without paying attention to outstanding bugs reported for the code they modify. (One can presume that's what happened, else this bug would have been closed one way or another.)