From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#24383: [External] : Re: bug#24383: 25.1.50; Deprecation/internalization of `read-from-whole-string' Date: Sat, 6 Feb 2021 18:52:47 +0000 Message-ID: References: <87im759xsw.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6491"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "24383@debbugs.gnu.org" <24383@debbugs.gnu.org> To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 06 19:53:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l8Shi-0001b8-Lh for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Feb 2021 19:53:10 +0100 Original-Received: from localhost ([::1]:42840 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l8Shh-0006Rr-Or for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Feb 2021 13:53:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56146) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l8Sha-0006Rj-1D for bug-gnu-emacs@gnu.org; Sat, 06 Feb 2021 13:53:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34886) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l8ShZ-00048V-PS for bug-gnu-emacs@gnu.org; Sat, 06 Feb 2021 13:53:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l8ShZ-0004Qb-Of for bug-gnu-emacs@gnu.org; Sat, 06 Feb 2021 13:53:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Feb 2021 18:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24383 X-GNU-PR-Package: emacs Original-Received: via spool by 24383-submit@debbugs.gnu.org id=B24383.161263758017014 (code B ref 24383); Sat, 06 Feb 2021 18:53:01 +0000 Original-Received: (at 24383) by debbugs.gnu.org; 6 Feb 2021 18:53:00 +0000 Original-Received: from localhost ([127.0.0.1]:46432 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l8ShY-0004QM-HP for submit@debbugs.gnu.org; Sat, 06 Feb 2021 13:53:00 -0500 Original-Received: from userp2120.oracle.com ([156.151.31.85]:38204) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l8ShV-0004Q8-PR for 24383@debbugs.gnu.org; Sat, 06 Feb 2021 13:52:58 -0500 Original-Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 116InvZf187852; Sat, 6 Feb 2021 18:52:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=u5v+/zWj4jrcAk/xFrovB2MKPvCPqEaTjwIT6U2FIag=; b=DrDVO1CqhEbt/dXJ+TVGsXOOolfUVnH8kDykpdeFanbpr3e0/UuN3Uof/xEbt1kL1gGG T3pf48bRYYP1VEwykh2DTxUfa184kDV7ol4MyTxGkVS5oEAJ81JRl79ww7tYEzuyRf0P n1/n/sSw12em0Q0xYlIMhTw3Cw9f1y48/V5MrFDv2D24QdoEEIBlww6Y4rqLcd1305J9 WNqnlx92ew/nedUqF/2QmA1dPHit7fa7eXF/2FA4HGQd+WLlJLKiSCvlum3khFdRW3Ca zIcOUzeGegRzTs7T6zcTDp8ZKscl5UICK1P2vEr9Vo7foKlRsCcCrbEUU4Vpx+iVxoOX AQ== Original-Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2120.oracle.com with ESMTP id 36hkrmrwsm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 06 Feb 2021 18:52:50 +0000 Original-Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 116IoSJF069876; Sat, 6 Feb 2021 18:52:50 GMT Original-Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2169.outbound.protection.outlook.com [104.47.57.169]) by userp3020.oracle.com with ESMTP id 36hjeh8rrm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 06 Feb 2021 18:52:49 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XqW8kcUa2qA4Uhs1igfOJqv+QYeWqhGXI3GRQfIO0H++ihhztgnf09Mk9Ski9nMhD2HYS/3XQnJCdYkARs95g55d3ERkjhhp6IRUVnXdfj5+3AsKK5sTSmKZEq4HObDnGbw3fHQJcQ59Fj2FweAJU7F5z54WU973jm3jltq1hnj5Ou+F5VBJmHxdKWS7UJHsu2fAqIGvGHM9N2yUyv48uQrZdTuIyskjLlGBsb84JLbP2cxt/5mw/fRq2eCdyWKIDRt3oH0wj9R2BaVuywRVioC1qE80nzSepH/NYa5MYcNJcWJNQgFqQrKEZLhEfreamHzFbA5W4joKAgmut7/viw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u5v+/zWj4jrcAk/xFrovB2MKPvCPqEaTjwIT6U2FIag=; b=aRBzQFlq5Iir4pLp3iM4crVpZuXXH5pd1vDPJ5pmOoh5Y9eN7xIKC0ndhWcYLja1xbEgoy63g49Ngfo6T9TAQhErQwenYHMz7idto1rAGVPsqaRX0wYuEUZrzJZPZb+V3un70DrovqtrmkDYtW6TEF5LanHRvf+5KuQOVJ2X0VaK8w4AO/R3lCYbQ/5j8QsOJufZQ+eXlN5jvVJGnQzhicqwbMG9t+IZgYXcbSuRFizwQi4rbEvnpYTyt32AgSPCwY39KSTU7VAqHGUA+IeXiZ3ohHvS9JjrS2nR9GsiajUJUnsieoZhbKq6hHuoCJnr60+4gW8XRK3vAle5NfM7Qg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u5v+/zWj4jrcAk/xFrovB2MKPvCPqEaTjwIT6U2FIag=; b=tyVIP9YYrg/P27Q4A//w22vGAOrB5bM/mXl0h53svGdbWKD2gD7Xb5PzdpU81KnSgvIZRqCx6qe98PzFXSuiGaSYfDr+sd0ZFIQhxuHXRkj7pmj/2WAqQJyAvT3I1TfPa83IEykcqMVizD5YxkExz4dWJdCrCPfpid8bm1dXzrg= Original-Received: from SA2PR10MB4474.namprd10.prod.outlook.com (2603:10b6:806:11b::15) by SN6PR10MB2781.namprd10.prod.outlook.com (2603:10b6:805:d4::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3805.19; Sat, 6 Feb 2021 18:52:47 +0000 Original-Received: from SA2PR10MB4474.namprd10.prod.outlook.com ([fe80::dc4d:9cd0:2010:daa2]) by SA2PR10MB4474.namprd10.prod.outlook.com ([fe80::dc4d:9cd0:2010:daa2%7]) with mapi id 15.20.3825.030; Sat, 6 Feb 2021 18:52:47 +0000 Thread-Topic: [External] : Re: bug#24383: 25.1.50; Deprecation/internalization of `read-from-whole-string' Thread-Index: AQHW/ITrpuBen7XMlkGiV9MGSld9ZKpLcmMg In-Reply-To: <87im759xsw.fsf@gnus.org> Accept-Language: en-US Content-Language: en-US authentication-results: gnus.org; dkim=none (message not signed) header.d=none;gnus.org; dmarc=none action=none header.from=oracle.com; x-originating-ip: [73.170.83.28] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0b1c6e05-fced-4bbe-bdcb-08d8cad0655b x-ms-traffictypediagnostic: SN6PR10MB2781: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nvrrVgdtCN/bjsRvWuYYGxNqM30975fNhDIZOntfk4UBGDoFrSdUTPOStPB78MSAGAgLdVyKyYd6DzvjbnHXJcRTq7Ynw3UN9GJKYQtuodr+JwdU8kjB9fEvyRdZBZ2a+nJpyUxFIVLqGVmcnEySjfFH3qLVs7LYS8IimgZRF2wOsSJ7m1y9oAGItyUJ0ST3PQAeSRbX1G8KsSHYPlNp1EAn1ilPpvSJPYGFkWQeXpsCxmWy06PnlXtDwYx7zNXHuFbVqbEt6b1+O1cklt9cVjyUED9CDYEXGcI1pydkcFbtgD5b2EgM4ZfgzGvLPY9iwITZh5mViGKkt9YwvAvJwXEepqyBa84Z2Ar0GcHeow9rvKWWTRVQJRd1khfV0ZFu06xsIvWRgzI6/f2CskEKv2QhlOrKyi6PJjl+F7i/oJFfvgnT1K3/BVD5qlfhC42svVKgJ4iZ7j/Y5iZ5eXu3WIT3/4sR8bk2MrIy0DzZmJeO9l3uz0outkzih6MZnYmiEJ/LcNVU1t2oMcfqP3gdeknLHzNTJFUWVLISv5nnstxjI/ZxQyOSMdBKLnZEPnW0 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA2PR10MB4474.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(396003)(366004)(376002)(346002)(136003)(39860400002)(66556008)(64756008)(66446008)(66476007)(66946007)(4326008)(86362001)(5660300002)(6916009)(52536014)(7696005)(76116006)(8676002)(6506007)(478600001)(33656002)(2906002)(9686003)(44832011)(8936002)(71200400001)(26005)(55016002)(316002)(186003)(81973001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: /AA9JeMCnqUa0PDY+aCdNDV/N+1OUFuSUbfGRh1HxNa0FLzxStFhECBPscO8o9X8XLEv3KmPl8ladgsuNPq2O0fpR5ZArqmeNqruBZXD0MWm3Vh627wCXtpaUvWDUqEVGle1y0ATrYSAZkOMJ7k2nNCc0Ach+aEMG24dLIKB44vIRtndBemaNPK+4Gwu7KUu7aA7uieT0ELrH+py+X7uvTqK7BJiOQoZgmzi3MkSIcJlFrRHBuINdAKs2OJzXMF51zH785SEcU8vGh4df7TwxOkDKsiiTL1krDj9TXTJDhloWyedOwzFNkWs7+Zf8c5GANbCaOZ+ulTasr/dNAUdzaVUjG/etcPAmpwa8g8qiJps8FNA1pVVwTQfXBdwqLwhwkpbmWeTjR3PgtJBFnRIP+UOngVOfE3haCofttBA4h+OnoepiNmDGMwH4T+5XFwPZ+dbBzYVL8lR+rF5Q3ilxLHR7yVjLyUF7wEj2XeVnL/t8LNHI+Pkg8zVa+UQp7Vf4wLSNEMaDiVk+DIMtcoNw0RWHU3zxfzzGdZeT8udgDNY7qThySg46tdRzxPe6y063mCMXSp7eJ6WOKqQU3lwwvnX9fN55dj0Wc7LbPJhBZRb3nRhmqa9gzJoBirSyb5CuKPAf2B4j/rO1qNbbK4322rjMiNEkq3kOOEiefCtd7CFimVmKGQIt4FJNe2Fec2m7LMEIY+KyLZn7JbPC4X54W3WXg2mEqaRvrNBbeEyIT2J8aLoRpWxR9nmgR+C L5syoQMDTqVosYTmYnYwzBKBQEUJ2uZTU0E4YwsJDoghvvr57RV45nhWq8ovr6wsN9NT9FvUDm6W4S5e+V6aDekykvwzEWmr6j x-ms-exchange-transport-forked: True X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA2PR10MB4474.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0b1c6e05-fced-4bbe-bdcb-08d8cad0655b X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Feb 2021 18:52:47.3811 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /TJFbkNOaXfNL69Usp6UhJvRQdwbBjwKsYvxHZ0NgWxGd0BIlrG8P3eyBiuo/ACP3xjM7sBUjl0ozJ4v1ikvGA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR10MB2781 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9887 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0 adultscore=0 phishscore=0 bulkscore=0 mlxlogscore=999 spamscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102060135 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9887 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0 priorityscore=1501 bulkscore=0 spamscore=0 impostorscore=0 mlxscore=0 suspectscore=0 mlxlogscore=999 adultscore=0 clxscore=1011 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102060135 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:199450 Archived-At: > > What's the rationale behind the demotion of > > `read-from-whole-string' and its replacement by > > "internal" function > > `thing-at-point--read-from-whole-string'? ? > > "This is an internal thingatpt function and should not be used." > > > > Should not be used? Really? Why? >=20 > "Should not be used" is perhaps over-stating the case, but it's an > internal thingatpt function with a name that didn't reflect that, so > renaming it is appropriate. What makes it "internal"? The name change is based on it being internal, so the reason it's considered internal can't be because of its name. Does it have anything at all to do specifically with thing-at-point? What makes it a candidate for being designated "internal"? Does anything in the code or the doc string suggest thing-at-point? "Read a Lisp expression from STR. Signal an error if the entire string was not used." > It's up to you whether you want to use internal > Emacs functions, of course. Closing. The alternative to using this function is to reproduce its definition. Is that better? Wouldn't it be better to move this out of thingatpt.el? Isn't this function generally useful? I've copied the definition to two libraries, unrelated to each other. That says something about how internal this is, no?