From: Drew Adams <drew.adams@oracle.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: "46973@debbugs.gnu.org" <46973@debbugs.gnu.org>
Subject: bug#46973: [External] : Re: bug#46973: 26.3; (elisp) `Face Remapping'
Date: Mon, 15 Mar 2021 16:36:03 +0000 [thread overview]
Message-ID: <SA2PR10MB447466383493B358F7778B0AF36C9@SA2PR10MB4474.namprd10.prod.outlook.com> (raw)
In-Reply-To: <83wnubibnt.fsf@gnu.org>
> > But if I do something like this, where SPECS (being a &rest arg) is the
> list `(variable-pitch)', which is a list of face names:
> >
> > (add-hook 'some-mode-hook
> > (lambda ()
> > (face-remap-set-base 'default 'variable-pitch)))
> >
> > I get an error saying that `variable-pitch' isn't a list.
> > (And trying '(variable-pitch) instead gives the same error.)
> >
> > I'm probably missing something - what is it? Or is it possible that
> > `face-remap-set-base' has a different meaning of SPECS?
>
> The doc string of face-remap-set-base says:
>
> The remaining arguments, SPECS, specify the base of the remapping.
> Each one of SPECS should be either a face name or a property list
> of face attribute/value pairs, like in a ‘face’ text property.
You just cited the same doc I cited.
In `(face-remap-set-base 'default 'variable-pitch)' do
you not agree that SPECS is the list `(variable-pitch)',
which is a list of one face name?
Again, what am I missing?
M-x debug-on-entry face-remap-set-base
Stepping through shows that SPECS is indeed the list
`(variable-pitch)'. The first (and only) spec is the
face (name) `variable-pitch'.
To me, it looks like either a doc bug or a code bug.
The `while' loop sets SPECS to `variable-pitch'. And
the subsequent `if' tries to take its car.
Contrast with `face-remap-add-relative', which also
has an &rest SPECS arg, and whose elements can also
each be "a face name or a property list of face
attribute/value pairs."
The code for `face-remap-add-relative' does this:
(while (and (consp specs) (null (cdr specs)))
(setq specs (car specs)))
which is different from what `face-remap-set-base' does:
(while (and (consp specs)
(not (null (car specs)))
(null (cdr specs)))
(setq specs (car specs)))
I'm not saying that the two should necessarily be
the same. I am saying that the latter doesn't
seem to work for SPECS that's a list of face names.
next prev parent reply other threads:[~2021-03-15 16:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-06 18:16 bug#46973: 26.3; (elisp) `Face Remapping' Drew Adams
2021-03-13 10:35 ` Eli Zaretskii
2021-03-15 16:36 ` Drew Adams [this message]
2022-02-23 11:50 ` Lars Ingebrigtsen
2022-02-23 15:56 ` bug#46973: [External] : " Drew Adams
2022-02-23 16:57 ` Eli Zaretskii
2022-02-23 17:23 ` Drew Adams
2022-02-23 22:10 ` Mauro Aranda
2022-02-23 22:55 ` bug#46973: [External] : " Drew Adams
2022-02-24 6:49 ` Eli Zaretskii
2022-02-24 11:52 ` Mauro Aranda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SA2PR10MB447466383493B358F7778B0AF36C9@SA2PR10MB4474.namprd10.prod.outlook.com \
--to=drew.adams@oracle.com \
--cc=46973@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.