From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#47150: [External] : bug#47150: 28.0.50; Incorrect major-mode in minibuffer Date: Mon, 22 Mar 2021 18:40:05 +0000 Message-ID: References: <877dm9nsii.fsf@gmail.com> <40f3c845-ba30-4112-bb3c-9c06c1f106d3@www.fastmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18421"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "47150@debbugs.gnu.org" <47150@debbugs.gnu.org>, Sheng Yang To: Stefan Monnier , Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 22 19:41:19 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lOPUM-0004em-Rf for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 22 Mar 2021 19:41:18 +0100 Original-Received: from localhost ([::1]:49854 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lOPUL-0000CL-Pi for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 22 Mar 2021 14:41:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36394) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lOPU6-00009X-OG for bug-gnu-emacs@gnu.org; Mon, 22 Mar 2021 14:41:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47076) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lOPU6-0005G7-Fe for bug-gnu-emacs@gnu.org; Mon, 22 Mar 2021 14:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lOPU6-00045K-Dk for bug-gnu-emacs@gnu.org; Mon, 22 Mar 2021 14:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 Mar 2021 18:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47150 X-GNU-PR-Package: emacs Original-Received: via spool by 47150-submit@debbugs.gnu.org id=B47150.161643841615616 (code B ref 47150); Mon, 22 Mar 2021 18:41:02 +0000 Original-Received: (at 47150) by debbugs.gnu.org; 22 Mar 2021 18:40:16 +0000 Original-Received: from localhost ([127.0.0.1]:58617 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lOPTL-00043o-Ri for submit@debbugs.gnu.org; Mon, 22 Mar 2021 14:40:16 -0400 Original-Received: from userp2120.oracle.com ([156.151.31.85]:37304) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lOPTJ-00043X-LA for 47150@debbugs.gnu.org; Mon, 22 Mar 2021 14:40:14 -0400 Original-Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12MIO9b2158395; Mon, 22 Mar 2021 18:40:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=vPHy1b6kfxIGbQVR3y8tbI7K9Ng4NuQngFBzs7Cwg7w=; b=bCI5uiGtkQ6gfU86SsWlHaO5mAjVWA6w4iR5Mg7AfSpcW0nUduVg+ljCYJE+nlk4b8S5 S+oppXhaaMecaRAhMafAjPTEi9kGA9ktBTA6hhSPqzVZgJv5W4YQ0TAkLVcYNJ4loGow R4qHqDpWzGLuqyHqJadbs0UtvEya37EKYa1rbh2CnMOhByPJSbdRo2QfmnG2DkuWQ7i6 KS/fxs0SONzRBFG+SYJkOgHu48SUPmJNFd9A/4H/R2f6fclTVMOqXaITJgAXkVsI5uby gSnCSCJ+dH4ZgGA9hv/3oCUCtZzCBvy98VWlgOX1uqEOu7fXvc5ZFjOsVyuvDpo2E8wa pg== Original-Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2120.oracle.com with ESMTP id 37d9pmveg9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 22 Mar 2021 18:40:07 +0000 Original-Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12MIQZJh088865; Mon, 22 Mar 2021 18:40:06 GMT Original-Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2106.outbound.protection.outlook.com [104.47.58.106]) by aserp3020.oracle.com with ESMTP id 37dtxx9wgy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 22 Mar 2021 18:40:06 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MH+HcChyuim/8CW1jBr7PILz9XDTRZXEXxCjagzyXyYUd7RVo5B1prmZMJ/Nz0UdemxThj7RVAveYQPLpt0CZjD5sn8arsnZCaFdooF4khJ1nTRPv9TxugwVPlpeTULHxIIEAi2X7cDThZqKYT1kaHY6/JrxL6whjZcPfRv4ViqfOrS98tI1cRPD2Yzb9BtGlOCxuOTIyKifi9ZOk5+vRSLMRJl80ydw6BkMNd0wRw8ngFT514o4j+LvD4ZPbxAdNkxa3DwgBdLDt8RikAObfXOdF8+Ityt+bCtJ18TskG1SWtMh+DkW6KfEM74MNuiGsz71HOkFF27QVHFtqYbFyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vPHy1b6kfxIGbQVR3y8tbI7K9Ng4NuQngFBzs7Cwg7w=; b=fYFxur9vUl5nW2hy0QNz7542fEL3fJLDfO/sJTwWLwSZoWAJF1E2n7Ljer3i4/mLFT1Ybw7Ek0nzvu/IY1s8Ipyrs0A+iwsyB1xmvdLGWyWmjzO2IX0yjDyYTJjnW/c8IrrJ5uLiDxnoAADK8R1RpKGIdcCqNooB78G88oRlo2+wTvOA29IIwpXU2r1XFrF59BzbzvEycll8Y+Rwj3n0hkI6pAPYIm/4GUALfD3lznaPdOHIZ5Mj8X9hx/qYP7/C83oah3bAJlLMoAaDvxX9Lxi9Jwm/s8+DfffvCQwQz4bdjPMcWhnrm9bLRcnXJVNtEAsmbs3MM71Ln6bBBiu1ww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vPHy1b6kfxIGbQVR3y8tbI7K9Ng4NuQngFBzs7Cwg7w=; b=fGtEPAaY4LJjQrXASgN10WSHQ8tl1BxSKguOhHgu4dwEmGu49DJSEwv5KwUGMRSYkAUz1qDgt6lAquy63bGcgib5qPYysNVX0H7I+zN5QSL2mMVjox1AqYREsumEnaCYIkeCPBnm0pTsuK1DyhJ7WJ/EfRAlJI9ZLhkLD/bTHLs= Original-Received: from SA2PR10MB4474.namprd10.prod.outlook.com (2603:10b6:806:11b::15) by SA2PR10MB4411.namprd10.prod.outlook.com (2603:10b6:806:116::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18; Mon, 22 Mar 2021 18:40:05 +0000 Original-Received: from SA2PR10MB4474.namprd10.prod.outlook.com ([fe80::b8d2:db6d:3e4b:d315]) by SA2PR10MB4474.namprd10.prod.outlook.com ([fe80::b8d2:db6d:3e4b:d315%5]) with mapi id 15.20.3955.027; Mon, 22 Mar 2021 18:40:05 +0000 Thread-Topic: [External] : bug#47150: 28.0.50; Incorrect major-mode in minibuffer Thread-Index: AQHXH0bjCkTZGRWC/E2X/mGKfPiRn6qQU15Q In-Reply-To: Accept-Language: en-US Content-Language: en-US authentication-results: iro.umontreal.ca; dkim=none (message not signed) header.d=none;iro.umontreal.ca; dmarc=none action=none header.from=oracle.com; x-originating-ip: [73.170.83.28] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c223c38a-95b8-42b1-4acc-08d8ed61e919 x-ms-traffictypediagnostic: SA2PR10MB4411: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: bhMhSDgVHiBKP9GUPjybwQyDyiCWhSn/3T0RNatI5eZiiYwjmNuRr1oNrMhiLwDM5pV9r7HouxZzp9QZavfL0jefGfbnvulLVpB2VOWJGKMji/O53V4GzKPk6uJZL5D/4q83rUbgcAfeMyGDGk2ZWzJSXCFbNvZClDqET59RYhTue2hEUl0LSEETZJvf0I9fhfaXeLUwhEh0VUoOCpPlPzJtGURbyvw1SojsELrhog+xIvj4esB9oIzXBz1ots5pG5wf1tJf7/zCCKTcqw++QANgpLQ+N9z24TlOh2b5ptE5BQcuNYyaQajNgdoQSzw03tm/xvVHxI1VR5n85H3ui9y6UiLZssw3Gd1XXxH5y6Akr4760W5n3WS6Kc4x/WAihqEMHziDbbDJzJCHM5Q9lbyQxdUXvyq1iHfW8qkDtCCO3wBvc0vkNjz8o7ksLyhVVFZgMOhHkdPSJ/YtE5wbHMW2Oe8JvOep4vX6zVVfHPUr5JPyfdgFqzcTUW0+E0YE+R28zw4sz1I7uM17PFT+j2AeFsEq95Ag+0N7TIChPb4R77Vwo6/0/Dodkht47C9ojnOKFiWh9jvSWEwpMDmP+QORIbT8H0AbVb8Q40nrImUzW4tKdb4VB5dtD4/AmbL8eQHFMlZ2hal2o4XQdnHx1FaWhPULr8n1HvdwP+4buE4= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA2PR10MB4474.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(396003)(366004)(346002)(136003)(376002)(39860400002)(8936002)(66446008)(33656002)(66946007)(52536014)(2906002)(66556008)(66476007)(64756008)(4326008)(7696005)(38100700001)(86362001)(83380400001)(44832011)(71200400001)(6506007)(478600001)(76116006)(186003)(316002)(55016002)(9686003)(26005)(5660300002)(296002)(54906003)(110136005)(8676002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: WQbVlXAyDItOrNMOP1E2jTD9hR4TDg5M25UXfez4GZlKrIe7esjUH/CvLRZPq2F6Ixf3iFVutBYVd9+xSC5ZyIZtTnB+PrlC+KcRBfcXCA1KictxAkHkKSD5/i2rWWSQ199eRRKUrJu9HQ7M8y5JfgcSQs1tcdcvBZRnTSfrErMi/q2bUGCCcp/L253yuu2cwedRx9WQHy9q7+ocBxEg4Kg6YFWLT74KKiae4i8P5Ej+Pw3RBUUmwcdHhT19XB/IDO7QQ2o4cjHLvmPYpQmtigbXTWVCaYYG0uLwvF3iGeHi2ZwiOK9uvFpV6AhXsY0BGQ0YifJcSLpBKiTpcsu6Mh1AkGwtm0NdRR2xGueemodfUzJU1iLcHzOFmIzwTIUSYAlPqEbeprlv8a8s2XemyOYT0W1FVN1YNWtpj1tjV9tCQKwFKshMEsTWFDWhROtDuY6fTOmKH8bdFolzDVTPuoo99kTugZEwwLYsfb3MgucH/YiqkJeN/ErEI4Q5pZ9HUCNYdgqBxo0KFXEzY3MuJcFp4v3hX+j43bdt7CsLnUXiU12T7mdTtF92en4s7CUUIbk2aLylKkKXX8a/wUIBmPpIxBMky74jGWKJ7F8+l8wnJzTTY1iQUHJm/QLomKaIoZni14nTgNm3hcGzLsebOwmRW3P5zGM0cv3yd7cqvQJHOMLu9hqD/RCD/b5x/UX37QnnA2Clv5hXl71KZaAWrDnacYV5cfAW4UthwbltQspUT2QZWtqU+JcIcbVG GKdg8SPDorWDLTEwTMPzHrfYdDOwfvxCC+rYCPx0EWkJ2LcARstPBuuPtxBH6C4cG8Sz7tCzlqj173hXibfUof1RsjZ8Lj1pSK x-ms-exchange-transport-forked: True X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA2PR10MB4474.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c223c38a-95b8-42b1-4acc-08d8ed61e919 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Mar 2021 18:40:05.0727 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hTm78XV7GlGc/+A5Pk88C+rmlppxvHiMAzDaB5ssjSWgwo9J4xlwZZNfB0ZFFhgcUBGNKu1UTmD32B0dKQ/H1g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4411 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9931 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=999 malwarescore=0 phishscore=0 bulkscore=0 mlxscore=0 suspectscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103220134 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9931 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 lowpriorityscore=0 phishscore=0 mlxlogscore=999 priorityscore=1501 impostorscore=0 bulkscore=0 spamscore=0 adultscore=0 clxscore=1011 malwarescore=0 mlxscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103220134 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:202856 Archived-At: > I'm in favor of introducing a `minibuffer-mode`. Why? > Part of the question is also when and how that mode is activated (since > activating such a mode has the effect of deleting the local variables). > I think we should call `minibuffer-mode` every time we (re)activate > a minibuffer. Why? > The way I see it, `eval-expression` would want to use a new major mode > that derives from `minibuffer-mode`. Why change the major mode? What's involved, besides keymaps? Does parenthesis pairing and such require a major-mode change? > And more generally > `read-from-minibuffer` should accept an argument that says which major > mode to use (I think it'd make sense to re-use the `keymap` argument > for that: if that argument is `functionp`, then treat it as a major > mode, if it's `keymapp` then use it as the keymap). Why? What's the use case for changing major modes? > It would also provide a cleaner way to do what we currently do via the > `minibuffer-with-setup-hook` hack. Really? Everything that someone might do on that hook you would have passed as a function arg? Why would you find that cleaner? > >> It seems to me the minibuffer is always inactive? I tried M-x, > >> M-!, M-:, all reports minibuffer-inactive-mode in Emacs 27.1. Is this > >> a mistake and the offending commit was trying to fix this > >> inconsistency? > > Very much so! >=20 > BTW: thank you for that. AFAICT, the only "offense" was committed by the misleading mode name. I don't see why two (or more...) major modes are needed. > > So, a quick summary: (i) the change in the minibuffer's major mode to > > fundamental-mode was intended; (ii) there may be some problems in some > > packages because of this; >=20 > The minibuffer used to be "always" in fundamental mode in Emacs<24 > (since there was no `minibuffer-inactive-mode` back then), so I'm not > too worried. Right. There was nothing missing before `minibuffer-inactive-mode' was added, except possibly the corner case you mentioned for a standalone minibuffer frame. (And I use such a frame, and I've never felt the need to use it in an "inactive" active way.)