From: Drew Adams <drew.adams@oracle.com>
To: Stefan Kangas <stefan@marxist.se>, Lars Ingebrigtsen <larsi@gnus.org>
Cc: "emacs-devel@gnu.org" <emacs-devel@gnu.org>
Subject: RE: [External] : Consistent face for keys in *Help* and `substitute-command-keys'
Date: Wed, 24 Feb 2021 22:01:00 +0000 [thread overview]
Message-ID: <SA2PR10MB447421E2A51FA2209EFC5267F39F9@SA2PR10MB4474.namprd10.prod.outlook.com> (raw)
In-Reply-To: <CADwFkmkNsu_An7D9r+78EczSA0N04NAM5BUNaOGaFkDoNfZcxA@mail.gmail.com>
> > I think you already knew that I've been doing this
> > in help-fns+.el for over a decade. I've offered
> > the code before, and we've discussed it. It uses
> > `help-substitute-command-keys':
>
> I admit that I have never used any of your libraries.
>
> But I have seen Bug#8951 and the code you presented there.
>
> > That is, keys are linked to their commands.
> > So their face is the face Emacs uses for links.
> >
> > I think that's the right (better) approach.
>
> I'm not convinced of that. There will be many links all
> over the place, sometimes many links to the same place.
Why do you think so? I haven't seen that.
> It risks cluttering the help screen too much,
> whereas the effect you see with my patch is
> more subtle.
What makes you think your highlighting is more
subtle? And more subtle than what? You just
said that you've never even tried help-fns+.el.
> I also don't know of too many examples where
> links will be highly useful.
Specifics, please. Show an example where a
`...' key link isn't useful.
> Still, I'm not writing off the idea completely,
> I just don't currently see how to balance the drawbacks.
What drawbacks? So far, you've talked only
abstractly, about things that don't exist.
> > That's already been solved.
>
> Care to elaborate? AFAICT, messages do not currently
> display keybindings in a different face.
I meant that `...' for keys in *Help* is solved.
And the key listings you speak of there (e.g.
C-h C-h), which do _not_ use `...', can be dealt
with separately. That help (e.g. `C-h h') is
constructed individually - it doesn't use doc
strings or `substitute-command-keys'.
> > You can start with the code in help-fns+.el.
> > Or you can start from scratch. But DTRT.
>
> The work is mostly to identify the places where we output keys and
> ensure the strings get the correct face properties applied to them.
> Therefore, it is unfortunately not much help to start from anything
> that is not the Emacs source code or a patch to the Emacs source code.
And yet that's what you've done with other parts
of help-fns+.el... Suit yourself.
My point is that it's more helpful to users to
put links on those keys, in addition to keys
wrapped with `...'.
next prev parent reply other threads:[~2021-02-24 22:01 UTC|newest]
Thread overview: 188+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-21 12:06 Proposal for an improved `help-for-help' Stefan Kangas
2021-02-21 16:46 ` [External] : " Drew Adams
2021-02-21 17:31 ` Stefan Kangas
2021-02-21 18:17 ` Drew Adams
2021-02-21 17:42 ` Lars Ingebrigtsen
2021-02-21 18:18 ` [External] : " Drew Adams
2021-02-21 19:49 ` Stefan Kangas
2021-02-24 1:40 ` Consistent face for keys in *Help* and `substitute-command-keys' Stefan Kangas
2021-02-24 2:24 ` [External] : " Drew Adams
2021-02-24 4:44 ` Stefan Kangas
2021-02-24 22:01 ` Drew Adams [this message]
2021-02-25 1:25 ` Stefan Kangas
2021-02-25 6:43 ` Drew Adams
2021-02-25 15:06 ` Eli Zaretskii
2021-02-25 16:22 ` Stefan Kangas
2021-02-24 14:00 ` Basil L. Contovounesios
2021-02-24 16:35 ` Stefan Kangas
2021-02-24 19:09 ` Basil L. Contovounesios
2021-02-25 2:11 ` Stefan Kangas
2021-02-24 14:29 ` Lars Ingebrigtsen
2021-02-24 16:46 ` Eli Zaretskii
2021-02-25 2:26 ` Stefan Kangas
2021-02-25 14:28 ` Eli Zaretskii
2021-02-25 16:45 ` Stefan Kangas
2021-02-25 18:25 ` Eli Zaretskii
2021-02-25 18:48 ` Stefan Kangas
2021-02-25 19:11 ` Eli Zaretskii
2021-02-25 19:47 ` Stefan Kangas
2021-02-25 20:32 ` Eli Zaretskii
2021-03-04 6:24 ` Stefan Kangas
2021-03-04 14:00 ` Eli Zaretskii
2021-03-05 16:18 ` Stefan Kangas
2021-03-05 17:07 ` [External] : " Drew Adams
2021-03-05 17:58 ` Stefan Kangas
2021-03-06 16:44 ` Drew Adams
2021-03-06 17:04 ` Stefan Kangas
2021-03-06 17:39 ` Drew Adams
2021-03-05 18:58 ` Eli Zaretskii
2021-03-05 19:28 ` Stefan Kangas
2021-03-05 20:15 ` Eli Zaretskii
2021-03-05 20:39 ` Stefan Kangas
2021-03-05 20:52 ` Eli Zaretskii
2021-03-05 21:43 ` Stefan Kangas
2021-03-06 7:33 ` Eli Zaretskii
2021-03-06 16:25 ` Stefan Kangas
2021-03-06 17:32 ` Stefan Kangas
2021-03-06 18:28 ` Eli Zaretskii
2021-03-07 3:03 ` Stefan Kangas
2021-03-07 6:45 ` Eli Zaretskii
2021-03-07 7:26 ` Stefan Kangas
2021-03-07 7:42 ` Eli Zaretskii
2021-03-08 9:17 ` Juri Linkov
2021-03-08 11:10 ` Stefan Kangas
2021-03-08 17:43 ` Juri Linkov
2021-03-10 1:38 ` Stefan Kangas
2021-03-10 17:16 ` Juri Linkov
2021-03-10 19:35 ` Stefan Kangas
2021-03-10 19:50 ` Juri Linkov
2021-03-10 19:59 ` Eli Zaretskii
2021-03-11 0:46 ` Stefan Kangas
2021-03-11 3:09 ` Stefan Monnier
2021-03-11 6:25 ` Eli Zaretskii
2021-03-11 13:25 ` Stefan Monnier
2021-03-11 13:59 ` Eli Zaretskii
2021-03-13 14:11 ` Stefan Kangas
2021-03-11 6:05 ` Eli Zaretskii
2021-03-13 14:27 ` Stefan Kangas
2021-03-13 15:16 ` Eli Zaretskii
2021-03-13 15:59 ` Stefan Kangas
2021-03-11 0:45 ` Stefan Kangas
2021-03-15 9:19 ` Juri Linkov
2021-03-16 2:37 ` Stefan Kangas
2021-03-16 23:20 ` Dmitry Gutov
2021-03-08 15:39 ` [External] : " Drew Adams
2021-03-08 16:40 ` Stefan Kangas
2021-03-08 17:43 ` Juri Linkov
2021-03-09 7:38 ` Stefan Kangas
2021-03-09 9:05 ` Juri Linkov
2021-02-25 19:14 ` Drew Adams
2021-02-25 19:44 ` martin rudalics
2021-02-24 16:51 ` Eli Zaretskii
2021-02-25 1:56 ` Stefan Kangas
2021-02-25 14:24 ` Eli Zaretskii
2021-02-21 17:45 ` Proposal for an improved `help-for-help' Eli Zaretskii
2021-02-21 18:20 ` [External] : " Drew Adams
2021-02-21 18:48 ` Stefan Kangas
2021-02-21 19:19 ` Eli Zaretskii
2021-02-21 20:04 ` Stefan Kangas
2021-02-21 20:16 ` Eli Zaretskii
2021-02-21 23:27 ` Stefan Kangas
2021-02-22 16:12 ` Eli Zaretskii
2021-03-13 16:26 ` Stefan Kangas
2021-03-14 2:37 ` [External] : " Drew Adams
2021-03-14 23:05 ` Drew Adams
2021-03-14 23:53 ` Stefan Kangas
2021-03-15 1:54 ` Drew Adams
2021-04-07 15:18 ` Stefan Kangas
2021-04-07 16:10 ` Eli Zaretskii
2021-04-07 22:54 ` Howard Melman
2021-04-08 7:15 ` Eli Zaretskii
2021-04-08 12:57 ` Stefan Kangas
2021-04-08 13:35 ` Stefan Kangas
2021-04-08 13:50 ` Eli Zaretskii
2021-04-08 15:27 ` Stefan Kangas
2021-04-08 15:34 ` Eli Zaretskii
2021-04-08 17:16 ` Howard Melman
2021-04-08 22:52 ` Stefan Kangas
2021-04-09 6:23 ` Eli Zaretskii
2021-04-08 14:08 ` Alan Mackenzie
2021-04-08 14:50 ` Dmitry Gutov
2021-04-08 15:02 ` Alan Mackenzie
2021-04-08 15:15 ` Eli Zaretskii
2021-04-08 15:45 ` Alan Mackenzie
2021-04-08 15:51 ` Eli Zaretskii
2021-04-08 17:55 ` Howard Melman
2021-04-09 15:42 ` Stefan Kangas
2021-04-08 18:48 ` Gregory Heytings
2021-04-08 23:23 ` Stefan Kangas
2021-04-08 23:35 ` Gregory Heytings
2021-04-08 23:41 ` Howard Melman
2021-04-07 16:42 ` [External] : " Drew Adams
2021-04-07 18:33 ` Gregory Heytings
2021-04-07 19:50 ` Gregory Heytings
2021-04-07 22:56 ` Stefan Kangas
2021-04-07 23:26 ` Gregory Heytings
2021-04-08 12:42 ` Stefan Kangas
2021-04-07 19:55 ` Juri Linkov
2021-04-24 13:21 ` Stefan Kangas
2021-04-24 13:27 ` Eli Zaretskii
2021-04-24 16:44 ` Dmitry Gutov
2021-04-24 23:48 ` Stefan Kangas
2021-04-25 7:26 ` Eli Zaretskii
2021-04-25 9:30 ` Stefan Kangas
2021-04-25 10:25 ` Eli Zaretskii
2021-04-25 11:49 ` Stefan Kangas
2021-04-25 12:14 ` Eli Zaretskii
2021-04-25 16:26 ` [External] : " Drew Adams
2021-04-25 10:20 ` Dmitry Gutov
2021-04-25 10:38 ` Eli Zaretskii
2021-04-25 10:46 ` Eli Zaretskii
2021-04-25 11:23 ` Dmitry Gutov
2021-04-25 15:18 ` Stefan Kangas
2021-04-25 15:28 ` Dmitry Gutov
2021-04-30 17:39 ` Stefan Kangas
2021-04-30 20:02 ` Dmitry Gutov
2021-04-30 20:36 ` Stefan Monnier
2021-04-30 22:09 ` Dmitry Gutov
2021-05-02 10:23 ` Stefan Kangas
2021-05-02 18:57 ` Dmitry Gutov
2021-04-30 17:34 ` Stefan Kangas
2021-04-25 12:47 ` Gregory Heytings
2021-04-25 13:05 ` Eli Zaretskii
2021-04-25 13:09 ` Eli Zaretskii
2021-04-25 16:22 ` [External] : " Drew Adams
2021-04-25 16:30 ` Eli Zaretskii
2021-04-25 13:16 ` Gregory Heytings
2021-04-25 13:24 ` Eli Zaretskii
2021-04-25 13:32 ` Gregory Heytings
2021-04-25 13:44 ` Eli Zaretskii
2021-04-25 13:58 ` Dmitry Gutov
2021-04-25 11:12 ` Dmitry Gutov
2021-04-25 15:47 ` DEL vs Backspace (was: Proposal for an improved `help-for-help') Stefan Monnier
2021-04-25 16:49 ` DEL vs Backspace Lars Ingebrigtsen
2021-04-25 17:25 ` Stefan Monnier
2021-04-25 17:50 ` Dmitry Gutov
2021-04-26 0:45 ` Stefan Kangas
2021-04-26 11:45 ` Eli Zaretskii
2021-04-26 11:48 ` Dmitry Gutov
2021-04-26 4:41 ` Richard Stallman
2021-04-27 20:56 ` Proposal for an improved `help-for-help' Stefan Kangas
2021-04-27 23:15 ` Dmitry Gutov
2021-04-24 17:18 ` Gregory Heytings
2021-04-24 20:32 ` Juri Linkov
2021-04-25 10:00 ` Stefan Kangas
2021-04-07 17:56 ` Howard Melman
2021-04-07 18:21 ` John Yates
2021-04-07 22:56 ` Stefan Kangas
2021-04-07 22:41 ` Stefan Kangas
2021-04-07 23:15 ` Howard Melman
2021-04-08 12:57 ` Stefan Kangas
2021-02-21 19:27 ` Howard Melman
2021-02-22 15:25 ` Stefan Kangas
2021-02-22 10:01 ` Yuri Khan
2021-02-22 15:25 ` Stefan Kangas
2021-04-25 15:11 ` Stefan Kangas
2021-04-25 15:34 ` Dmitry Gutov
2021-04-25 18:43 ` Stefan Kangas
2021-04-25 14:06 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SA2PR10MB447421E2A51FA2209EFC5267F39F9@SA2PR10MB4474.namprd10.prod.outlook.com \
--to=drew.adams@oracle.com \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.