From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#47425: [External] : Re: bug#47425: 26.3; `plist-get', `plist-put' should accept a TEST function Date: Sun, 28 Mar 2021 16:43:19 +0000 Message-ID: References: <87v99b5smv.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3754"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Nicolas Petton , "47425@debbugs.gnu.org" <47425@debbugs.gnu.org>, Stefan Monnier To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 28 18:44:15 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lQYWN-0000rt-BA for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 28 Mar 2021 18:44:15 +0200 Original-Received: from localhost ([::1]:44602 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lQYWM-0006oR-Ct for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 28 Mar 2021 12:44:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34898) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lQYWA-0006oH-1H for bug-gnu-emacs@gnu.org; Sun, 28 Mar 2021 12:44:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35370) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lQYW9-0006os-QZ for bug-gnu-emacs@gnu.org; Sun, 28 Mar 2021 12:44:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lQYW9-0001K1-MU for bug-gnu-emacs@gnu.org; Sun, 28 Mar 2021 12:44:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Mar 2021 16:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47425 X-GNU-PR-Package: emacs Original-Received: via spool by 47425-submit@debbugs.gnu.org id=B47425.16169498115036 (code B ref 47425); Sun, 28 Mar 2021 16:44:01 +0000 Original-Received: (at 47425) by debbugs.gnu.org; 28 Mar 2021 16:43:31 +0000 Original-Received: from localhost ([127.0.0.1]:46916 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQYVf-0001JA-4J for submit@debbugs.gnu.org; Sun, 28 Mar 2021 12:43:31 -0400 Original-Received: from aserp2120.oracle.com ([141.146.126.78]:37192) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQYVc-0001Iw-UK for 47425@debbugs.gnu.org; Sun, 28 Mar 2021 12:43:29 -0400 Original-Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12SGgDnx166116; Sun, 28 Mar 2021 16:43:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=Vo8kVjtTkPjuxKsltcoPDmDFPa7Grk5QCDwjKdzmGhM=; b=a8LIDp+h5ez2/sym0djzGllL2dLfGY8hToFlbsUHChsO3gqIRKQL1TiWotFhS3rtpt2h jP6DrVBftfTEcMSl+Y2UEadxx2B9qyFVmsUDg6Y+M4xolbJ145itva8MQRltTRK1rBwt zj/DrieeEGZ1ggWPHZrMpc/b0/KMBHPOoftaGXyQa2dEEL1QI0dXbWFc5mjG7FE4hDJO eYA1iAiMVBWYEjw93Hlppi9551IOtpTBUorKNdUNblovyXVieQ+j5/iKPjuJe5DgZ0uo KeKCTegRFmmpc/l7V44OMWzPcQfhE+uoC8D/H0ViS3uUip2SQBzs5Z6w3gLi5YM2tL0e Ow== Original-Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2120.oracle.com with ESMTP id 37hvnm1qc7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 28 Mar 2021 16:43:23 +0000 Original-Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12SGeS29185809; Sun, 28 Mar 2021 16:43:22 GMT Original-Received: from nam02-bl2-obe.outbound.protection.outlook.com (mail-bl2nam02lp2058.outbound.protection.outlook.com [104.47.38.58]) by userp3020.oracle.com with ESMTP id 37jefpu4f4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 28 Mar 2021 16:43:22 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YWubksYbKgHKkWnuhzzVSJjZrjgHyvIj5jV+mn3gxjl6j1I2luu2wBtcNV9/ILchgJxVeHOniYB1bE7y0FQnszMKLI2JWNF846QEUml1VSuB0QgMBmG+jIRBPSXzYgiI8qVAaHwL14EXCRzLBP8bkKSl1Apb0gIIqh3wZ6rj5t4vn2IeKsrG8sqh36TXnRL5H9GxWjY3HPMhPVcoKqkSc13Cwn2sZVv20hnfrdzmQBjQi7wy084m3AJWZeKzVtl3dpmXdFVot6FeTW30ahqlKCm7gGvX2sodtMbaKpKBkP2LnGTdV0eeScPHoTVEksU083OH4IsN/fFH5S49fpHYPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vo8kVjtTkPjuxKsltcoPDmDFPa7Grk5QCDwjKdzmGhM=; b=KJyw0IkpvcNIiM4GTSn9YelBfRxSdFzkgkoAsPnKJ91sWPHAewQnDymNQYcxu5dqjUKq4KfHoBPDNsC4wSoRok5damygwWMA3p/hbPVNlSeyDleKPluFpV5GruSuu1Qnb1hMA27t88o+8AoFqMi6ubH5Edax1hfAkkvZk8hkpYmM/CylfgukNiGULh517H10BpyMCAwwKIqVbE4u2KAx1QeS4Fnbg3sep3MdfqJSsQ9GLVIKO4WayuRTwUTEMmCzX5hLp3LNsT/FR1EP76EHVBxwKE78RxUbKXC+B+sNpnD4XxsgmdLYktxzd0dH+DREScpuGp4cfu127gTPYGwBFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vo8kVjtTkPjuxKsltcoPDmDFPa7Grk5QCDwjKdzmGhM=; b=ub9rklwBMLlcAjaz6FA5/bmQ9jSDlvhzov4VDOee20EMQyAG9JlOGIpJRjPkRhgsLwPb9knoH/TZFMaL5PSfQsxnT/dOdfDKQZHKj9iBGiQFtpJmefzwAIjdHIQLjiRDgblAI/3uLV/vRHiMAwKmN4fMHjN5pkzOTuOORUdoMZI= Original-Received: from SA2PR10MB4474.namprd10.prod.outlook.com (2603:10b6:806:11b::15) by SA2PR10MB4507.namprd10.prod.outlook.com (2603:10b6:806:119::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.30; Sun, 28 Mar 2021 16:43:20 +0000 Original-Received: from SA2PR10MB4474.namprd10.prod.outlook.com ([fe80::b8d2:db6d:3e4b:d315]) by SA2PR10MB4474.namprd10.prod.outlook.com ([fe80::b8d2:db6d:3e4b:d315%5]) with mapi id 15.20.3977.033; Sun, 28 Mar 2021 16:43:20 +0000 Thread-Topic: [External] : Re: bug#47425: 26.3; `plist-get', `plist-put' should accept a TEST function Thread-Index: AdcijTlucWJyPG/hRjGNffNRatDIDQBRt8hDAAc8CLA= In-Reply-To: <87v99b5smv.fsf@gnus.org> Accept-Language: en-US Content-Language: en-US authentication-results: gnus.org; dkim=none (message not signed) header.d=none;gnus.org; dmarc=none action=none header.from=oracle.com; x-originating-ip: [73.170.83.28] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 87bd9f86-4a89-4bf5-dd6b-08d8f2089834 x-ms-traffictypediagnostic: SA2PR10MB4507: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TsPoJsBjfcAlhpB3oVm1Bt+geIytVdJHZ/nah458drycf1IDkTiwfSFUXADH2CoGhBvvwLjNMqWHROx7RPEpGQxrcUjwINby9hUXOJOW6/J0QmAPISEo+BpDskwTYhVNkURLGV83UVZ1of96qYS3wdVouS622+/qx+5MllbfDBdsnFbSaxocilCYD1Dzwtq0LlNFHhrOEg5fs1Bv0JfrUq5ERxiUG6x5zLSuE8FEVilO0WEXDSHdKE0ygpM5QTwegldePBz4cO3pDwuyER6e3O2ZLmAfWEP+PpQT7KTss3UTiihXTV7d5qcNiombRcvmtl1oR5br7Pg5mx2RoLr59LTVkvbm2Ojaz+pHxZN5z4gikwDbDhkQcGD1lH/RpQ8vmz9KjahiXroXAvhzGxkG4EzaIQH6TTta9WemXUupBPfA8RaDTnKIV+sPpeJ0hdBOWNWCZP7WteN78Lhuxf4wckrC9nvWH1YxQf3zBdHpwe3RM5AkFPHXUXiAHpUSLZkA0Q5uU4miNz2BmsRwPWCEGRNLprBvXyrNgFnELAhT9P8aHsyAXQVsHQExprDJTI7QMzYCAb32W8A9f7GSJ/RDcXJGBbhbSZhbmVEL2nXvFGVf422Gs6y/19g9zZsM+lmZAeC5R03ztuFfwWiapTtHLvQchKdVLrwlkXxqq2AKSdq0/UYjxTgwSftym17bMBlZ x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA2PR10MB4474.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(396003)(136003)(366004)(376002)(39860400002)(26005)(186003)(71200400001)(7696005)(6916009)(76116006)(5660300002)(8936002)(66946007)(55016002)(6506007)(52536014)(2906002)(33656002)(86362001)(66556008)(9686003)(66446008)(66476007)(64756008)(83380400001)(54906003)(44832011)(478600001)(4326008)(8676002)(316002)(38100700001)(81973001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: L5b5YQMWUOFLPUpdsG/rIl2Mle23ClOLitxTSg/zejebNs8idGMdYNTVPHHVDACv3qzvHXW8cJefgblTRCQKSouPhiYoJYPkNtZ57ysw3SML+HA79f1qc1QipVsCYjeQcGH68ZhI6ART7m00IFcz19A2ZNe/aHN4V+E87SChlEap2E62SfURekUSN2Wmbvul7283YY9u6n4FoRw8Rra4fL08yD2h/5GonjtBgB/fOPIdx84nLoEE3o6RBRDYPaPJQ6Z7yxiwxqQ58Eo2W3DC/eyGnryeVmwRO9kf2xbvxIFQ0+DV5jGVy4+PyU/o7VIPhRCla7UtvBf6D/nM3gR2sfUwG/WxDin1dX/NKmXBMnrR7ZBDjPbhYhUFA7DiOI6V5f94Ar9nd2612XQhk4DYc6MzXANn50Fw83iBmTZmpyHu5oPYt0aRhNr2tszWmBZ3zqwUqAsF2xz6WQvMUw5Fno/KyIj+P4WoE2DwPpe3qhsQDbXiPAYH5mcBjYcDGadESCdNxf4pCclPimj9Ummrnw6tf5iqcCn2iuyWwV2N9KGVmfk5Tjg3Rl+VIuSLRU2ZVBGbu9kKnumU7Ob3lbkJl0kJnDADGNFL7gpypxY9DEBBEHIDlFA5qqBKXXwvIrXHZ8nKKUfEzwNHny2qKo9L6SFeHlsBaym/aj2wdTMnhM1Lsu0W8lKfs26+vtYErtAxEStznSGaGF4neXSowe/AqNAN1r7I9LJIZgd7bDjjsqtuf0OSlrRlFQBw1072 VB6adKebRXwaYSYkf0JNWXu8qD5v9iNN09W1GWdeTn8rwEpJ1OaPPkUVMMg1qaCCD3gguMMCmubWbAICc4oJSy3NowyeP7ASUv x-ms-exchange-transport-forked: True X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA2PR10MB4474.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 87bd9f86-4a89-4bf5-dd6b-08d8f2089834 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Mar 2021 16:43:19.8673 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rXGE6WbN+e8TcCHMRmyFGLAngWOClN1fhjp9oTUO4XfD3wVjTUvj/8/9E355mkKzQX+u/SSpvAO4agb4lQy7tQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4507 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9937 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=600 adultscore=0 mlxscore=0 malwarescore=0 bulkscore=0 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2103250000 definitions=main-2103280127 X-Proofpoint-GUID: nPNlQ6dnOHNU1asdQIXepxtqKM9NlFtC X-Proofpoint-ORIG-GUID: nPNlQ6dnOHNU1asdQIXepxtqKM9NlFtC X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9937 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 impostorscore=0 mlxlogscore=899 clxscore=1011 priorityscore=1501 phishscore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 suspectscore=0 mlxscore=0 malwarescore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2103250000 definitions=main-2103280126 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:203192 Archived-At: > > Please consider adding a TEST comparer arg for plist keys. > > > > In Elisp, a plist key need not be a symbol: > > > > (plist-put (list "aaa" 1 "bbb" 2 "ccc" 3) "bbb" 42) > > > > That "works" (and no error), but it doesn't do what's expected, since > > the keys should be compared with `equal' or `string=3D', not `eq'. >=20 > plist-put doesn't ensure that the operation makes sense here, no, but we > can't really add that at this point, either. Please elaborate. I don't know what you're saying, or why. > I think adding a comparison function makes sense, but on the other > hand -- we seem to be moving towards using map.el more for these things > now, so I'm not sure there's much enthusiasm for that. On the other > hand, the generic map functions have the problem that they... can't > really be used like plist-put. No. Please do _not_ bring generic mapping into this. This is a legitimate issue about plists and plist functions. > So does anybody have an opinion here? I think I'm in favour of adding a > comparison function for all three `plist-*' functions. +1.=20 > > That would also mean we wouldn't need `lax-plist-*' functions. >=20 > Yes, those are horrible functions, and are barely used anywhere. (And > `lax-plist-member' is missing.) Agreed. But their existence is an argument that the intention was to provide for the use of `equal' as an alternative test pred to `eq'.