From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Randy Taylor Newsgroups: gmane.emacs.bugs Subject: bug#70939: [PATCH] Add commands to run unit tests in go-ts-mode Date: Thu, 11 Jul 2024 14:21:59 +0000 Message-ID: References: <3YG1jNZQXdsT7DtRW9TTuDWpXHZ6qNpBW-7sfn36Mo7fzUp9dEKcHxCBEjpFVeJUbqP8YB9WXd8KyR9LuUERxjVUlLfw8MiE6DGcngF9lG4=@rjt.dev> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38976"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 70939@debbugs.gnu.org To: Ankit Gadiya Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 11 16:23:29 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sRuhk-0009vi-8m for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 11 Jul 2024 16:23:28 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sRuhN-0001Iq-Jq; Thu, 11 Jul 2024 10:23:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sRuhL-0000qU-8m for bug-gnu-emacs@gnu.org; Thu, 11 Jul 2024 10:23:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sRuhK-0006bY-UQ for bug-gnu-emacs@gnu.org; Thu, 11 Jul 2024 10:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sRuhK-0000YZ-Af for bug-gnu-emacs@gnu.org; Thu, 11 Jul 2024 10:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Jul 2024 14:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70939 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70939-submit@debbugs.gnu.org id=B70939.17207077342064 (code B ref 70939); Thu, 11 Jul 2024 14:23:02 +0000 Original-Received: (at 70939) by debbugs.gnu.org; 11 Jul 2024 14:22:14 +0000 Original-Received: from localhost ([127.0.0.1]:52333 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sRugY-0000XE-Ci for submit@debbugs.gnu.org; Thu, 11 Jul 2024 10:22:14 -0400 Original-Received: from mail-4323.proton.ch ([185.70.43.23]:52819) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sRugU-0000Wu-Qk for 70939@debbugs.gnu.org; Thu, 11 Jul 2024 10:22:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1720707722; x=1720966922; bh=JWiUSeBjr0B1w0jYSHFLOdC0aALuUbmMw/kPTg0ELlg=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=qzepEfePnf6AUqe8nbS+xaKX/xtsAIMVv6LYp8bu1cV2dIi2DkLemAnP543oQNx2C FlUeJd9uLiuhOp17P4KkJcH3W9m9CDN0eqMsMy174dUoSipVyQWYV7kGi6VJoQOuHs HIHffTgien3nSiChh/lcAPLGhHHqsEXAdibafZD07YLCsEb75CnvU5u7Kb0US8w3vZ 6S2a0tNbWQjmU1DRtEb3T+Lrv7CATmvcs76xLJOkWfmA5oDLufqCAIgi07Wcz+A+sB m2ia8AWHi+tzMbbVsS2bJFbUMZkqBop+1gQwTJ28CwW/cY44nJbw234t1BMiqDZjyE Zfwl9lqU+GWIg== In-Reply-To: Feedback-ID: 44397038:user:proton X-Pm-Message-ID: d0ba95a8debc525869c1c508bef8e26b9c412cbf X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288738 Archived-At: On Thursday, July 11th, 2024 at 03:33, Ankit Gadiya wrote: >=20 > > I only have a few comments about the commit message: >=20 > > Three new commands are added in the go-ts-mode to run unit tests. > > I would just drop this line altogether, personally. > >=20 > > (go-ts-mode-map): New map variable. > > This should probably read something like Add new bindings. > >=20 > > (go-ts-mode-test-file): New function. > > (go-ts-mode-test-package): New function. > > These two need to be updated (...-test-this-...). >=20 >=20 > Thanks, I'm sending the updated patch with these fixes. Thanks, looks good! >=20 > > Everything else looks good to me. Thanks for working on this, Ankit. > >=20 > > Eli, if you have no further comments please install when you get a chan= ce. Thanks in advance. >=20 >=20 > Thank you for being patient through this review. After this interaction, = I feel > encouraged to send more patches in the future. Glad to hear that! Thanks for putting up with us :). >=20 > -- > Ankit