From: Eli Zaretskii <eliz@is.elta.co.il>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCHES] 21.3.50 for Cygwin: patch 5
Date: Wed, 25 Dec 2002 08:12:45 +0200 (IST) [thread overview]
Message-ID: <Pine.SUN.3.91.1021225080757.7483D-100000@is> (raw)
In-Reply-To: <asqqnl$797$3@main.gmane.org>
On Fri, 6 Dec 2002, Joe Buehler wrote:
> --- lib-src/pop.c 17 May 2002 11:24:02 -0000 1.31
> +++ lib-src/pop.c 6 Dec 2002 16:34:43 -0000
> @@ -119,6 +119,9 @@
> #endif
> #endif
>
> +#ifdef _P
> +#undef _P
> +#endif
> #ifndef _P
> # ifdef __STDC__
> # define _P(a) a
This might be dangerous: other platforms could define _P in their system
header, and this patch then causes them to use the definition supplied by
pop.c. If that definition somehow doesn't work on some of those
platforms, pop.c is now broken on them.
In other words, this change has effect much beyond the Cygwin port, and
should IMHO be avoided if possible.
Why isn't the original #ifndef guard enough to solve the problem on
Cygwin? Could you please show how does the original code fail, and
explain why?
> --- src/mem-limits.h 19 Aug 2002 17:45:50 -0000 1.31
> +++ src/mem-limits.h 6 Dec 2002 16:35:33 -0000
> @@ -46,6 +46,10 @@
> #define BSD4_2
> #endif
>
> +#ifdef CYGWIN
> +#define BSD4_2
> +#endif
Can't this be done in src/s/cygwin.h?
next prev parent reply other threads:[~2002-12-25 6:12 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-06 18:36 [PATCHES] 21.3.50 for Cygwin: patch 5 Joe Buehler
2002-12-25 6:12 ` Eli Zaretskii [this message]
2002-12-26 13:15 ` Juanma Barranquero
2002-12-26 23:39 ` Richard Stallman
2002-12-27 7:46 ` Juanma Barranquero
2002-12-28 21:22 ` Richard Stallman
2003-01-03 16:19 ` Joe Buehler
2003-01-04 4:19 ` Richard Stallman
2003-01-05 0:31 ` Kim F. Storm
2003-01-05 16:45 ` Benjamin Riefenstahl
2003-01-06 0:13 ` Kim F. Storm
2003-01-06 13:45 ` Joe Buehler
2003-01-06 17:13 ` Richard Stallman
2003-01-07 9:47 ` Kim F. Storm
2003-01-07 18:44 ` Richard Stallman
2003-01-08 23:52 ` Kim F. Storm
2003-01-09 23:14 ` Richard Stallman
2003-01-10 9:49 ` Kim F. Storm
2003-01-10 19:44 ` Eli Zaretskii
2003-01-11 0:02 ` Kim F. Storm
2003-01-12 11:55 ` Richard Stallman
2003-01-11 0:22 ` Richard Stallman
2003-01-05 18:34 ` [PATCHES] " Richard Stallman
2003-01-04 10:07 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.SUN.3.91.1021225080757.7483D-100000@is \
--to=eliz@is.elta.co.il \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.