From mboxrd@z Thu Jan  1 00:00:00 1970
Path: main.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@is.elta.co.il>
Newsgroups: gmane.emacs.devel
Subject: Re: [PATCHES] 21.3.50 for Cygwin: patch 3
Date: Wed, 25 Dec 2002 07:59:03 +0200 (IST)
Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org
Message-ID: <Pine.SUN.3.91.1021225075032.7483A-100000@is>
References: <asqqhf$797$1@main.gmane.org>
NNTP-Posting-Host: main.gmane.org
Mime-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Trace: main.gmane.org 1040796034 17521 80.91.224.249 (25 Dec 2002 06:00:34 GMT)
X-Complaints-To: usenet@main.gmane.org
NNTP-Posting-Date: Wed, 25 Dec 2002 06:00:34 +0000 (UTC)
Cc: emacs-devel@gnu.org
Return-path: <emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org>
Original-Received: from quimby.gnus.org ([80.91.224.244])
	by main.gmane.org with esmtp (Exim 3.35 #1 (Debian))
	id 18R4aM-0004Y0-00
	for <emacs-devel@main.gmane.org>; Wed, 25 Dec 2002 07:00:06 +0100
Original-Received: from monty-python.gnu.org ([199.232.76.173])
	by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian))
	id 18R4eG-00076L-00
	for <emacs-devel@quimby.gnus.org>; Wed, 25 Dec 2002 07:04:08 +0100
Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org)
	by monty-python.gnu.org with esmtp (Exim 4.10.13)
	id 18R4Zz-0004ga-02
	for emacs-devel@quimby.gnus.org; Wed, 25 Dec 2002 00:59:43 -0500
Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13)
	id 18R4Zf-0004cx-00
	for emacs-devel@gnu.org; Wed, 25 Dec 2002 00:59:23 -0500
Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13)
	id 18R4Zd-0004bM-00
	for emacs-devel@gnu.org; Wed, 25 Dec 2002 00:59:22 -0500
Original-Received: from is.elta.co.il ([199.203.121.2])
	by monty-python.gnu.org with esmtp (Exim 4.10.13)
	id 18R4Zb-0004b0-00
	for emacs-devel@gnu.org; Wed, 25 Dec 2002 00:59:20 -0500
Original-Received: from is (is [199.203.121.2])
	by is.elta.co.il (8.9.3/8.8.8) with SMTP id HAA07560;
	Wed, 25 Dec 2002 07:59:03 +0200 (IST)
X-Sender: eliz@is
Original-To: Joe Buehler <jbuehler@hekimian.com>
In-Reply-To: <asqqhf$797$1@main.gmane.org>
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1b5
Precedence: list
List-Id: Emacs development discussions. <emacs-devel.gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Post: <mailto:emacs-devel@gnu.org>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
List-Archive: <http://mail.gnu.org/pipermail/emacs-devel>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org
Xref: main.gmane.org gmane.emacs.devel:10335
X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:10335

Thank you for working on this.

I have some comments, below.

On Fri, 6 Dec 2002, Joe Buehler wrote:

> Some Cygwin commands (e.g. cp) work transparently with or without the .exe
> extension on an executable file, but some commands (e.g. ln, chmod,
> chgrp, chown) require the exact file name.

Is running a program via a Makefile rule one of those cases?  I'd think 
it isn't, in which case changes like this one:

>   TAGS:
> -	../lib-src/etags $(srcdir)/*.[ch]
> +	../lib-src/etags@EXEEXT@ $(srcdir)/*.[ch]

are unnecessary.

Btw, perhaps you should suggest to the Cygwin maintainers a change in the 
ported `install' (from GNU Fileutils/Coreutils) such that when invoked 
with a command "install foo /bin/foo" it will look for foo.exe if foo is 
not found.  That will make `install:' targets in Makefiles work out of 
the box.

> -	rm -f emacs-* emacs
> +	rm -f emacs-*@EXEEXT@ emacs@EXEEXT@

Why can't the "emacs-*" part be left alone here?  It does match file 
names that end in .exe, right?

> -	-rm -f emacs emacs-* ../etc/DOC*
> +	-rm -f emacs@EXEEXT@ emacs-*@EXEEXT@ ../etc/DOC*

Same here.