Re: Fwd: Re: Minor problem in "Apropos" - 21.2.93

Re: Fwd: Re: Minor problem in "Apropos" - 21.2.93

[Richard Stallman]

     I looked in the the file "lisp/help.el". In place of using
     "exec-directory", we should be using "invocation-directory".

Using exec-directory looks correct to me; the fns... file is supposed
to be in that directory.  If it is not present there for you,
I think that is the bug.  Can you investigate why it was not
installed there?

I am pretty sure invocation-directory is not correct,
because that is nil for an installed Emacs.  And for an
uninstalled Emacs, it is the src directory, which is the
wrong place for fns-...


Content-Disposition: inline
From: "Dhruva Krishnamurthy" <seagull@fastmail.fm>
To: "Emacs Beta" <emacs-pretesters@gnu.org>
Date: Mon, 09 Dec 2002 19:44:30 +0530
X-Epoch: 1039443270
X-Sasl-enc: A24LMNXo0+mDtaMAYOJ04A
Cc: "Richard Stallman" <rms@gnu.org>
Subject: Fwd: Re: Minor problem in "Apropos" - 21.2.93
X-Spam-Status: No, hits=-6.3 required=5.0
	tests=FWD_MSG,QUOTED_EMAIL_TEXT,SIGNATURE_SHORT_DENSE,
	      SPAM_PHRASE_00_01
	version=2.41
X-Spam-Level: 

Hi,
 I looked in the the file "lisp/help.el". In place of using
 "exec-directory", we should be using "invocation-directory". This will
 ensure that the search for "fns-VERSION.el" file is made in the correct
 folder.
Looking forward to seeing this minor fix.
file:lisp/help.el
line:616
Other lines (doc):602,607

with best regards,
dhruva

On Mon, 09 Dec 2002 19:10:40 +0530, "Dhruva Krishnamurthy"
<seagull@fastmail.fm> said:
> Hello,
>  I am sorry for misleading you all. By sheer coincidence I had and
>  environmental variable "EMACSPATH" with other folders which I was adding
>  to the PATH variable. I realized, EMACSPATH is not to be used other than
>  just pointing to the path where emacs.exe resides. My sincere apologies
>  for those who have spent time trying to debug.
> 
> with best regards,
> dhruva
> NOTE:
> I feel we should use the ARGV[0] and do a strtok() to get the actual path
> to store in "exec-directory" var instead of just taking it from the
> EMACSPATH env variable.
> 
> On Mon, 09 Dec 2002 18:50:24 +0530, "Dhruva Krishnamurthy"
> <seagull@fastmail.fm> said:
> > Hi,
> >  I have built GNU Emacs 21.2.93 using MinGW 2.0 on W2K platform. When I
> >  do the following:
> > M-x apropos "stipple"
> > Select "set-face-stipple", command for extrra information/help, I get the
> > following error message:
> > Cannot open load file: d:/GNU/bin/fns-21.2.93.1.el
> > 
> > I have installed GNU Emacs under: D:/GNU/emacs. I feel it should have
> > looked into the folder "D:/GNU/emacs/bin" where the file
> > "fns-21.2.93.1.el" is present.
> > 
> > with regards,
> > dhruva
> > 
> > -- 
> > Dhruva Krishnamurthy
> > Home: http://www.geocities.com/gnued/
> > 
> -- 
> Dhruva Krishnamurthy
> Home: http://www.geocities.com/gnued/
-- 
Dhruva Krishnamurthy
Home: http://www.geocities.com/gnued/

Re: Minor problem in "Apropos" - 21.2.93

[Dhruva Krishnamurthy]

On Wed, 11 Dec 2002 12:44:32 -0500, "Richard Stallman" <rms@gnu.org>
said:
>      I looked in the the file "lisp/help.el". In place of using
>      "exec-directory", we should be using "invocation-directory".
> 
> Using exec-directory looks correct to me; the fns... file is supposed
> to be in that directory.  If it is not present there for you,
> I think that is the bug.  Can you investigate why it was not
> installed there?
> 
> I am pretty sure invocation-directory is not correct,
> because that is nil for an installed Emacs.  And for an
> uninstalled Emacs, it is the src directory, which is the
> wrong place for fns-...

The fns-VERSION.el is getting installed in the correct folder where the
emacs.exe resides (NO BUG).
The problem is, if environment variable EMACSPATH is set to some other
folder or list of folders as in PATH variable, "exec-directory" has the
first entry from EMACSPATH.

Ex:
Case where I have GNU Emacs installed under D:/GNU/emacs and have
"gnuserv.exe" and other binaries in
"D:/GNU/bin":

cmd>set EMACSPATH=D:/GNU/bin;D:/GNU/emacs/bin
cmd>emacs
In Emacs session, the value of "exec-directory" is "D:/GNU/bin" but Emacs
executable is in "D:/GNU/emacs/bin"
and "fns-VERSION.el" file is also in "D:/GNU/emacs/bin" folder.
The value of "invocation-directory" is "D:/GNU/emacs/bin" which is
correct.

The same behavior is shown in uninstalled Emacs exe too found in
"emacs-21.2.93/bin/emacs.exe" after build.

>From my understanding "invocation-directory" is got from parsing argv[0]

with best regards,
dhruva
-- 
Dhruva Krishnamurthy
Home: http://www.geocities.com/gnued/

Re: Minor problem in "Apropos" - 21.2.93

[Richard Stallman]

    The fns-VERSION.el is getting installed in the correct folder where the
    emacs.exe resides (NO BUG).

That is the wrong place.  It is supposed to be installed
in the same place as movemail, etc.

Re: Minor problem in "Apropos" - 21.2.93

[Dhruva Krishnamurthy]

On Fri, 13 Dec 2002 17:21:35 -0500, "Richard Stallman" <rms@gnu.org>
said:
>     The fns-VERSION.el is getting installed in the correct folder where
>     the
>     emacs.exe resides (NO BUG).
> 
> That is the wrong place.  It is supposed to be installed
> in the same place as movemail, etc.

On Windows Platform (on which I build and test), all executables are put
in the same folder.
If --prefix=D:/GNU/emacs
All executables and fns-VERSION.el files are in "D:/GNU/emacs/bin"

The following is the dir contents:

D:\GNU\emacs\bin
[dky]ls D:/GNU/emacs/bin
addpm.exe         ddeclient.exe     etags.exe         movemail.exe
cmdproxy.exe      ebrowse.exe       fns-21.2.93.1.el  runemacs.exe
ctags.exe         emacs.exe         hexl.exe

Since "invocation-directory" holds the correct value computed correctly
based on the argv[0] (src/emacs.c) of the Emacs process and not the
environmental variable as done for "exec-directory", IMHO, we should
consider using it.

with best regards,
dhruva


-- 
Dhruva Krishnamurthy
Home: http://www.geocities.com/gnued/

Re: Minor problem in "Apropos" - 21.2.93

[Eli Zaretskii]

> From: "Dhruva Krishnamurthy" <seagull@fastmail.fm>
> Date: Sat, 14 Dec 2002 11:56:35 +0530
> 
> On Fri, 13 Dec 2002 17:21:35 -0500, "Richard Stallman" <rms@gnu.org>
> said:
> >     The fns-VERSION.el is getting installed in the correct folder where
> >     the
> >     emacs.exe resides (NO BUG).
> > 
> > That is the wrong place.  It is supposed to be installed
> > in the same place as movemail, etc.
> 
> On Windows Platform (on which I build and test), all executables are put
> in the same folder.
> If --prefix=D:/GNU/emacs
> All executables and fns-VERSION.el files are in "D:/GNU/emacs/bin"

I think this is then a bug in the Windows installation setup.  It
should have either put some of the executables in a separate
directory, like what's done on other platforms, or point
exec-directory tp d:/gnu/emacs.

Re: Minor problem in "Apropos" - 21.2.93

[Richard Stallman]

    Since "invocation-directory" holds the correct value computed correctly
    based on the argv[0] (src/emacs.c) of the Emacs process and not the
    environmental variable as done for "exec-directory", IMHO, we should
    consider using it.

I already considered it, and I told you why it is wrong.  On most
systems these files are NOT in invocation-directory.  exec-directory
is the right place.

Someone who works on Emacs for Windows should figure out why this file
is not in the place which exec-directory points to, and fix things so
that the file is there.

Re: Minor problem in "Apropos" - 21.2.93

[Juanma Barranquero]

On Sun, 15 Dec 2002 18:39:49 -0500, Richard Stallman <rms@gnu.org> wrote:

> Someone who works on Emacs for Windows should figure out why this file
> is not in the place which exec-directory points to, and fix things so
> that the file is there.

In the prebuilt binaries, fns-21.2.9X-1.el is in bin/ and exec-directory
points to that directory. In my MSVC 6.0 builds it's also correct.
OTOH, I always build in the source tree; I don't use --prefix.

In which case does exec-directory point to a directory other than bin/?
It is perhaps related to using --prefix?

                                                           /L/e/k/t/u

Re: Minor problem in "Apropos" - 21.2.93

[Dhruva Krishnamurthy]

On Mon, 16 Dec 2002 15:04:41 +0100, "Juanma Barranquero" <lektu@terra.es>
said:
> On Sun, 15 Dec 2002 18:39:49 -0500, Richard Stallman <rms@gnu.org> wrote:
> 
> > Someone who works on Emacs for Windows should figure out why this file
> > is not in the place which exec-directory points to, and fix things so
> > that the file is there.
> 
> In the prebuilt binaries, fns-21.2.9X-1.el is in bin/ and exec-directory
> points to that directory. In my MSVC 6.0 builds it's also correct.
> OTOH, I always build in the source tree; I don't use --prefix.
> 
> In which case does exec-directory point to a directory other than bin/?
> It is perhaps related to using --prefix?
> 
>                                                            /L/e/k/t/u

The problem is when environment variable "EMACSPATH" is set to something
other than where the emacs.exe resides.
The variable "exec-directory" is set using "EMACSPATH" env variable and
not argv[0]. Hence, it is very easy to confuse by setting "EMACSPATH" to
a wrong location.
In my case:
Emacs is installed in "D:/GNU/emacs"
EMACSPATH="D:/GNU/bin;D:/GNU/emacs/bin"
Hence, "exec-directory" was "D:/GNU/bin"

-dhruva
-- 
Dhruva Krishnamurthy
Home: http://www.geocities.com/gnued/

Re: Minor problem in "Apropos" - 21.2.93

[Kai Großjohann]

"Dhruva Krishnamurthy" <seagull@fastmail.fm> writes:

> The variable "exec-directory" is set using "EMACSPATH" env variable and
> not argv[0]. Hence, it is very easy to confuse by setting "EMACSPATH" to
> a wrong location.
> In my case:
> Emacs is installed in "D:/GNU/emacs"
> EMACSPATH="D:/GNU/bin;D:/GNU/emacs/bin"
> Hence, "exec-directory" was "D:/GNU/bin"

Why did you set EMACSPATH at all?  Is it necessary in Windows?
-- 
~/.signature is: umop ap!sdn    (Frank Nobis)

Re: Minor problem in "Apropos" - 21.2.93

[Eli Zaretskii]

> From: "Dhruva Krishnamurthy" <seagull@fastmail.fm>
> Date: Tue, 17 Dec 2002 13:03:13 +0530
> 
> For my understanding:
> Can someone please tell me difference in the "exec-directory" and
> "invocation-directory". I feel I am missing out something very important.

exec-directory is where Emacs looks for the programs that are
required for Emacs's own features, such as `hexl', Ebrowse, etc.

Re: Minor problem in "Apropos" - 21.2.93

[Richard Stallman]

    The problem is when environment variable "EMACSPATH" is set to something
    other than where the emacs.exe resides.
    The variable "exec-directory" is set using "EMACSPATH" env variable and
    not argv[0]. Hence, it is very easy to confuse by setting "EMACSPATH" to
    a wrong location.

Perhaps the code for choosing which element in EMACSPATH should be
exec-directory should be made smarter.  However, since the fns file
will be disappearing, I don't think we should put much effort now
into fixing it up.  You should just make the right directory be
first in EMACSPATH.

It would be good to add something to PROBLEMS about this.  Would you like
to write an entry?

Re: Minor problem in "Apropos" - 21.2.93

[Kim F. Storm]

Richard Stallman <rms@gnu.org> writes:

>     The problem is when environment variable "EMACSPATH" is set to something
>     other than where the emacs.exe resides.
>     The variable "exec-directory" is set using "EMACSPATH" env variable and
>     not argv[0]. Hence, it is very easy to confuse by setting "EMACSPATH" to
>     a wrong location.
> 
> Perhaps the code for choosing which element in EMACSPATH should be
> exec-directory should be made smarter.  However, since the fns file
> will be disappearing, I don't think we should put much effort now
> into fixing it up.  You should just make the right directory be
> first in EMACSPATH.

It would be "trivial" to search EMACSPATH to find the proper directory
by looking for the directory which has the fns file.  If it cannot find
fns in any directory on the EMACSPATH, maybe it should abort with a
message telling the user to fix it.

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

Re: Minor problem in "Apropos" - 21.2.93

[Eli Zaretskii]

On 18 Dec 2002, Kim F. Storm wrote:

> It would be "trivial" to search EMACSPATH to find the proper directory
> by looking for the directory which has the fns file.  If it cannot find
> fns in any directory on the EMACSPATH, maybe it should abort with a
> message telling the user to fix it.

There's no reason to abort, IMHO: fns is used for load-history, so losing 
it is not fatal, right?

But a warning should be nice in any case, I think.