bug#648: htmlize.el doesn't work fine

bug#648: htmlize.el doesn't work fine

[clinif]

[-- Attachment #1: Type: text/plain, Size: 720 bytes --]

htmlize.el works fine with emacs22 and ntemacs(version 23.0.50)
But when I use the latest emacs-cvs, it doesn't work.
I've cleaned my .emacs, kept only two lines:
(require `htmlize)
(setq debug-on-error t)

Open a new buffer in emacs, then write something in it.
when  "M-x htmlize-buffer", I found these messages:

Debugger entered--Lisp error: (error "Invalid face")
  internal-get-lisp-face-attribute(nil :height nil)
  face-attribute(nil :height)
  htmlize-face-size(default)
  htmlize-face-to-fstruct(default)
  htmlize-make-face-map((default))
  htmlize-buffer-1()
  htmlize-buffer()
  call-interactively(htmlize-buffer t nil)
  execute-extended-command(nil)
  call-interactively(execute-extended-command nil nil)

[-- Attachment #2: Type: text/html, Size: 908 bytes --]

bug#648: htmlize.el doesn't work fine

[Juanma Barranquero]

On Tue, Aug 5, 2008 at 08:06, clinif <clin24@gmail.com> wrote:

> Debugger entered--Lisp error: (error "Invalid face")
>   internal-get-lisp-face-attribute(nil :height nil)
>   face-attribute(nil :height)

In Emacs 23.X,

  (face-attribute 'default :inherit) => nil

while in Emacs 22.X,

  (face-attribute 'default :inherit) => unspecified

I'm not sure whether that's a bug, but it is an incompatible change.

For the time being, you can patch your htmlize.el, changing one line
of htmlize-face-size, from

	  for f = face then (face-attribute f :inherit)

to

	  for f = face then (or (face-attribute f :inherit) 'unspecified)

 Juanma

bug#648: htmlize.el doesn't work fine

[Lennart Borgman (gmail)]

Juanma Barranquero wrote:
> On Tue, Aug 5, 2008 at 08:06, clinif <clin24@gmail.com> wrote:
> 
>> Debugger entered--Lisp error: (error "Invalid face")
>>   internal-get-lisp-face-attribute(nil :height nil)
>>   face-attribute(nil :height)
> 
> In Emacs 23.X,
> 
>   (face-attribute 'default :inherit) => nil
> 
> while in Emacs 22.X,
> 
>   (face-attribute 'default :inherit) => unspecified
> 
> I'm not sure whether that's a bug, but it is an incompatible change.
> 
> For the time being, you can patch your htmlize.el, changing one line
> of htmlize-face-size, from
> 
> 	  for f = face then (face-attribute f :inherit)
> 
> to
> 
> 	  for f = face then (or (face-attribute f :inherit) 'unspecified)


Please also notice that htmlfontify.el was meant to be included in 
Emacs. Vivek, what has happened with this?

bug#648: htmlize.el doesn't work fine

[clinif]

Lennart Borgman (gmail) 写道:
> Juanma Barranquero wrote:
>> On Tue, Aug 5, 2008 at 08:06, clinif <clin24@gmail.com> wrote:
>>
>>> Debugger entered--Lisp error: (error "Invalid face")
>>>   internal-get-lisp-face-attribute(nil :height nil)
>>>   face-attribute(nil :height)
>>
>> In Emacs 23.X,
>>
>>   (face-attribute 'default :inherit) => nil
>>
>> while in Emacs 22.X,
>>
>>   (face-attribute 'default :inherit) => unspecified
>>
>> I'm not sure whether that's a bug, but it is an incompatible change.
>>
>> For the time being, you can patch your htmlize.el, changing one line
>> of htmlize-face-size, from
>>
>>       for f = face then (face-attribute f :inherit)
>>
>> to
>>
>>       for f = face then (or (face-attribute f :inherit) 'unspecified)
>
>
> Please also notice that htmlfontify.el was meant to be included in 
> Emacs. Vivek, what has happened with this?
Thank you very much, it works now!

bug#648: htmlize.el doesn't work fine

[Vivek Dasmohapatra]

> Please also notice that htmlfontify.el was meant to be included in Emacs. 
> Vivek, what has happened with this?

I'm looking at your final patch as we speak, trying to figure out why
you made the changes you did - it's kind of hard to figure out without any 
test cases. I'll wrap it up tonight, I've got some time free.

bug#648: htmlize.el doesn't work fine

[Stefan Monnier]

>> Debugger entered--Lisp error: (error "Invalid face")
>> internal-get-lisp-face-attribute(nil :height nil)
>> face-attribute(nil :height)

> In Emacs 23.X,

>   (face-attribute 'default :inherit) => nil

> while in Emacs 22.X,

>   (face-attribute 'default :inherit) => unspecified

> I'm not sure whether that's a bug, but it is an incompatible change.

It does look like a bug in htmlize: the `inherit' property is supposed
to hold a list of faces, so nil is a perfectly valid value there (it's
the empty list).


        Stefan

bug#648: htmlize.el doesn't work fine

[Juanma Barranquero]

On Fri, Aug 8, 2008 at 20:10, Stefan Monnier <monnier@iro.umontreal.ca> wrote:

> It does look like a bug in htmlize: the `inherit' property is supposed
> to hold a list of faces, so nil is a perfectly valid value there (it's
> the empty list).

That's a way to see it; the other is that it expects that you can
trace back a chain of face :inherit's until you find 'unspecified.

 Juanma