From: Reindert-Jan Ekker <R.Ekker@ai.rug.nl>
To: martin rudalics <rudalics@gmx.at>
Cc: Reindert-Jan Ekker <R.Ekker@ai.rug.nl>, bug-gnu-emacs@gnu.org
Subject: Re: highlight-changes-rotate-faces sets buffer modified flag
Date: Wed, 9 May 2007 15:41:14 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.0705091514001.24246@tcw2.ai.rug.nl> (raw)
In-Reply-To: <4641BD88.7020207@gmx.at>
On Wed, 9 May 2007, martin rudalics wrote:
>> Hi,
>>
>> Turning off highlight-changes-mode sets the buffer-modified state as well.
>
> This could be handled as with `highlight-changes-rotate-faces'.
> Unfortunately, switching `highlight-changes-mode' off will leave
> `buffer-undo-list' cluttered with all sorts of remnants that make sense
> iff the mode is on. You could try as follows: Switch the mode on, do
> some changes, rotate colors, switch it off, undo changes. Changed text
> may get highlighted although the mode is off.
This does not seem to be a problem in my case. Looking at the value of
buffer-undo-list after turning of highlight-changes-mode does show some
face changes, but undo-ing these does not cause any text to become
highlighted again.
>
>> By the way, I do not have a lot of experience with emacs lisp. Regarding
>> buffer-undo-list: would it be correct to just remove the front element
>> of the list in the advice I wrote?
>
> Better not record the change in the first place by temporarily binding
> `buffer-undo-list' to t during the buffer change.
So this is an improved version of my advice:
(defadvice highlight-changes-rotate-faces (around around-rotate-faces)
(let ((was-modified (buffer-modified-p))
(saved-undo-list buffer-undo-list)
(buffer-undo-list t))
ad-do-it
(setq buffer-undo-list saved-undo-list)
(unless was-modified
(set-buffer-modified-p nil))))
(ad-activate 'highlight-changes-rotate-faces)
>
> BTW, am I correct that you run `highlight-changes-rotate-faces'
> interactively and not in `write-file-functions'? In the latter case
> setting the buffer-modified flag should get shadowed by the saving
> primitive.
>
Actually, I am trying to write a hook that calls
highlight-changes-rotate-faces on the right buffers whenever I do a
subversion commit with psvn.
Reindert
next prev parent reply other threads:[~2007-05-09 13:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-08 6:10 highlight-changes-rotate-faces sets buffer modified flag martin rudalics
2007-05-09 9:29 ` Reindert-Jan Ekker
2007-05-09 12:24 ` martin rudalics
2007-05-09 13:41 ` Reindert-Jan Ekker [this message]
2007-05-09 16:53 ` martin rudalics
-- strict thread matches above, loose matches on Subject: below --
2007-05-07 15:30 Reindert-Jan Ekker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0705091514001.24246@tcw2.ai.rug.nl \
--to=r.ekker@ai.rug.nl \
--cc=bug-gnu-emacs@gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.