smtpmail.el

smtpmail.el

[Sam Steingold]

Your recent patches to smtpmail.el broke it for me.
In `smtpmail-try-auth-methods', the `supported-extensions' does not
have 'auth, so `mechs' is nil, `mech' is nil, and I am asked for a
(useless!) password before getting 
        (error "Mechanism %s not implemented" nil)
For now, I just use the appended patch.
Is it okay to check it in?

-- 
Sam Steingold (http://www.podval.org/~sds) running RedHat7.2 GNU/Linux
<http://www.camera.org> <http://www.iris.org.il> <http://www.memri.org/>
<http://www.palestine-central.com/> <http://www.mideasttruth.com/>
There is Truth, and its value is T.  Or just non-NIL.  So 0 is True!


--- smtpmail.el.~1.40.~	Fri Apr 26 08:03:58 2002
+++ smtpmail.el	Fri Apr 26 10:55:09 2002
@@ -477,7 +477,7 @@
 			   (netrc-get hostentry "password")))
 		 (smtpmail-find-credentials
 		  smtpmail-auth-credentials host port)))
-	 (passwd (when cred
+	 (passwd (when (and mech cred)
 		   (or (smtpmail-cred-passwd cred)
 		       (read-passwd
 			(format "SMTP password for %s:%s: "
@@ -520,8 +520,8 @@
 		(not (integerp (car ret)))
 		(>= (car ret) 400))
 	    (throw 'done nil)))
-       (t
-	(error "Mechanism %s not implemented" mech)))
+       (t ;; no auth mech - do nothing
+        ))
       ;; Remember the password.
       (when (and (not (stringp smtpmail-auth-credentials))
 		 (null (smtpmail-cred-passwd cred)))

Re: smtpmail.el

[Simon Josefsson]

Yes, it looks alright.  Except possible to `else' clause, isn't it OK to 
warn about if no supported mechanism was supported?  I'm not sure just 
ignoring it is OK.  Well, the server would reject the submission saying 
that no authentication was performed, but the user would be somewhat 
surprised since she did supply credentials, but the real problems was that 
smtpmail.el didn't support the SASL mechanism offered by the server.

On 26 Apr 2002, Sam Steingold wrote:

> Your recent patches to smtpmail.el broke it for me.
> In `smtpmail-try-auth-methods', the `supported-extensions' does not
> have 'auth, so `mechs' is nil, `mech' is nil, and I am asked for a
> (useless!) password before getting 
>         (error "Mechanism %s not implemented" nil)
> For now, I just use the appended patch.
> Is it okay to check it in?
> 
>