Commenting invisible text

Commenting invisible text

[Josef Urban]

Hi,

running 'comment-region on a block containing some invisible lines does 
not comment the invisible lines. I get this behavior with Hide/Show and 
also with other kinds of invisible text. 

Should not this be fixed in newcomment.el? If it is a feature (why?), 
should not there be at least some customization?

Thanks,
Josef Urban

Re: Commenting invisible text

[Stefan]

> running 'comment-region on a block containing some invisible lines does 
> not comment the invisible lines. I get this behavior with Hide/Show and 
> also with other kinds of invisible text. 

Works for me,


        Stefan

Re: Commenting invisible text

[Josef Urban]

> > running 'comment-region on a block containing some invisible lines does 
> > not comment the invisible lines. I get this behavior with Hide/Show and 
> > also with other kinds of invisible text. 
> 
> Works for me,

Which Emacs version do you use? I have: 
"GNU Emacs 21.3.1 (i386-pc-linux-gnu, X toolkit, Xaw3d scroll bars) of 
2004-08-03 on raven, modified by Debian",
but the bug was also reported on some earlier SuSE version.
Here is a test example:

(progn
  (find-file "foo.el") 
  (insert "a\nb\n\c\n") 
  (put-text-property (point-min) (point-max) 'invisible t)
  (comment-region (point-min) (point-max)))

the result is:
a
b
c;; 

if the fourth line is commented, it is:

;; a
;; b
;; c

Josef

Re: Commenting invisible text

[Stefan Monnier]

>> > running 'comment-region on a block containing some invisible lines does 
>> > not comment the invisible lines. I get this behavior with Hide/Show and 
>> > also with other kinds of invisible text. 
>> 
>> Works for me,

> Which Emacs version do you use?

The version that I expect everyone on emacs-devel to use: Emacs-CVS.


        Stefan

Re: Commenting invisible text

[Josef Urban]

On Thu, 30 Sep 2004, Stefan Monnier wrote:

> >> > running 'comment-region on a block containing some invisible lines does 
> >> > not comment the invisible lines. I get this behavior with Hide/Show and 
> >> > also with other kinds of invisible text. 
> >> 
> >> Works for me,
> 
> > Which Emacs version do you use?
> 
> The version that I expect everyone on emacs-devel to use: Emacs-CVS.

Does not work for me either. Did you try the example?

Josef

Re: Commenting invisible text

[Stefan Monnier]

> Does not work for me either. Did you try the example?

Which example?  I didn't see any example,


        Stefan

Re: Commenting invisible text

[Josef Urban]

On Thu, 30 Sep 2004, Stefan Monnier wrote:

> > Does not work for me either. Did you try the example?
> 
> Which example?  I didn't see any example,

It is in my today's e-mail to which you have replied :-).
(progn
  (find-file "foo.el")
  (insert "a\nb\n\c\n")
  (put-text-property (point-min) (point-max) 'invisible t)
  (comment-region (point-min) (point-max)))

I have now tried with the Emacs-CVS version also the original problem 
with Hide/Show, and it really works properly. This probably means that 
commenting invisible overlays already works, but not invisible text 
properties. Is it the intended behavior?

Josef

Re: Commenting invisible text

[Stefan Monnier]

>> > Does not work for me either. Did you try the example?
>> Which example?  I didn't see any example,

> It is in my today's e-mail to which you have replied :-).
> (progn
>   (find-file "foo.el")
>   (insert "a\nb\n\c\n")
>   (put-text-property (point-min) (point-max) 'invisible t)
>   (comment-region (point-min) (point-max)))

Sorry, I missed that part.  You use a non-ellipsis invisible property, so
it's a different behavior than what you get with outline-minor-mode or
hs-minor-mode.

> I have now tried with the Emacs-CVS version also the original problem 
> with Hide/Show, and it really works properly. This probably means that 
> commenting invisible overlays already works, but not invisible text 
> properties. Is it the intended behavior?

No, overlays and text-properties behave just the same in this respect.
The issue is whether the invisible text is really invisible or whether it's
replaced by an ellipsis (i.e. "...").  And yes, it's the intended behavior.


        Stefan