From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: Last steps for pretesting (font-lock-extend-region-function) Date: Tue, 25 Apr 2006 13:14:52 +0000 (GMT) Message-ID: References: <87mze9dfx2.fsf-monnier+emacs@gnu.org> Reply-To: Alan Mackenzie NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Trace: sea.gmane.org 1145971201 31403 80.91.229.2 (25 Apr 2006 13:20:01 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 25 Apr 2006 13:20:01 +0000 (UTC) Cc: Richard Stallman , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 25 15:19:57 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FYNSA-0003ds-K4 for ged-emacs-devel@m.gmane.org; Tue, 25 Apr 2006 15:19:43 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FYNSA-0007G2-0D for ged-emacs-devel@m.gmane.org; Tue, 25 Apr 2006 09:19:42 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FYNRu-0007Ey-2k for emacs-devel@gnu.org; Tue, 25 Apr 2006 09:19:26 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FYNRt-0007E7-6B for emacs-devel@gnu.org; Tue, 25 Apr 2006 09:19:25 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FYNRs-0007E4-Vv for emacs-devel@gnu.org; Tue, 25 Apr 2006 09:19:25 -0400 Original-Received: from [193.149.49.134] (helo=acm.acm) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FYNUG-00025f-RR; Tue, 25 Apr 2006 09:21:54 -0400 Original-Received: from localhost (root@localhost) by acm.acm (8.8.8/8.8.8) with SMTP id NAA00889; Tue, 25 Apr 2006 13:14:53 GMT X-Sender: root@acm.acm Original-To: Stefan Monnier In-Reply-To: <87mze9dfx2.fsf-monnier+emacs@gnu.org> X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:53380 Archived-At: Good afternoon, Stefan! On Tue, 25 Apr 2006, Stefan Monnier wrote: >>> you talk as if I wanted to remove a well-established hook in favor of >>> some new fangled feature, whereas the font-lock-multiline property is >>> the one that's been in Emacs since 21.1, whereas your hook is the one >>> that's new and that you want to add to Emacs-22. >> It has already been added. >It hasn't been added in released code yet. >> I'm desperately trying to stop you from taking it away again, because >> that would make my (Emacs) life much more difficult. >Actually no: as I've shown with my sample alternative solution, it would >only force you to make you life simpler. You have shown nothing of the kind. You're in no better position to decide what is objectively simpler than I am, since neither of is is unbiassed in this debate. I'm in a better position than you to know what makes MY life simpler. Please respect that. >>> I think in order to justify this new hook you need to show that the >>> pre-existing font-lock-multiline solution is not good enough in some >>> cases. >> I don't. I merely need to point out that Richard specifically asked for >> this hook to be installed. >No: he agreed to install it after you claimed it was needed. As a >matter of fact, it was needed in font-lock-default-fontify-region (where >you didn't add it) but not in font-lock-after-change-function. He requested it. Subject: Re: [sigra@home.se: C++-mode: Syntax highlighting: wrong color for function identifier depending on the kind of whitespace that follows]. RMS, 2005-02-12: >Here's the change I was talking about. Would someone please adapt this >_now_ to the current sources, and install it? Then please rename >before-font-lock-after-change-function to >font-lock-extend-region-function, and rename >font-lock-run-before-after-change-hook to font-lock-extend-region? That was a positive request, not an acquiescence. In fact, a year earlier in the same thread: RMS, 2005-03-11: >I think we should add that hook now. >It is simple and easy to understand. >Even if in some cases it is not a good solution, >it is a good solution part of the time. >That is enough reason. It seems clear that Richard totally understood my patch. However, he is the best person to say what actually meant. At the time, you saw its purpose as being subtlely different from my intention, and we spent some time at loggerheads because of this. As a result of that discussion, it became clear to me that we need a similar hook to adjust the 500-byte chunks produced by jit. >> When he did so, he was aware that it was called from an after-change >> function. >It seemed clear to him that an "extend-region" hook was a good idea and >we all agree that it is. But I highly doubt it that he took the time to >understand enough to be able to judge whether placing it in >font-lock-after-change-function was a good choice or not. RMS: "It is simple and easy to understand." I think he can speak for himself on this matter, and we should let him. > Stefan -- Alan.