From: Alan Mackenzie <acm@muc.de>
Cc: bug-cc-mode@gnu.org, martin rudalics <rudalics@gmx.at>,
Ralf Angeli <angeli@iwi.uni-sb.de>,
"Richard M. Stallman" <rms@gnu.org>,
emacs-devel@gnu.org
Subject: Re: font-lock-extend-region (was: [sigra@home.se: C++-mode: Syntax highlighting: wrong color for function identifier depending on the kind of whitespace that follows])
Date: Mon, 20 Mar 2006 13:01:00 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.3.96.1060320110347.318B-100000@acm.acm> (raw)
In-Reply-To: <87wteph7kg.fsf-monnier+emacs@gnu.org>
Hi, Stefan!
Before I get going, I'd like to say I've spent some time getting to grips
with jit-lock, and I think I now understand some of the things you were
telling me. I also apologize for getting a bit grumpy about it last
week.
Here is a diagram of the sequence of functions that a piece of text is
processed by:
#########################################################################
"*" means that the routine adjusts the region to whole lines.
DEMAND (called by display code) <----------------------------|
[fontification-functions] (hook) |
jit-lock-function ->-| |
|-------------<------------+ <is defer-fontif. enabled?> |
| | |
| v ^
| |-----------<------------| |
| | |
| |->* jit-lock-fontify-now <----------------------------| |
| [jit-lock-functions] (hook) | |
v font-lock-fontify-region <------------------------+---+----|
| [font-lock-fontify-region-function] (hook) | | |
| * font-lock-default-fontify-region | | |
| | | |
|DEFERRED (invoked by jit-lock-defer-timer) | | |
|--> jit-lock-deferred-fontify ------------------>-----+---| |
This sets 'fontified to nil, and calls sit-for, | | |
causing immediate display (by DEMAND). | | |
| | |
STEALTH (invoked by jit-lock-stealth-timer) | | |
jit-lock-stealth-fontify | ^ |
jit-lock-fontify-now ----------------->-------------| | |
| |
CONTEXT (invoked by jit-lock-context-timer) | |
jit-lock-context-fontify (from timer) -------->---------+ |
This sets 'fontified to nil on the (extended) | |
region. | |
| |
JIT AFTER CHANGE (called from the after-change hook) | ^
* jit-lock-after-change --------------->------------------| |
This sets 'fontified to nil, and relies on DEMAND |
to refontify the changed bit during display. |
|
ORDINARY AFTER CHANGE (without jit, called from after-change) |
* font-lock-after-change-function |
font-lock-fontify-region ---------------->-------------------|
|
COMMANDS |
font-lock-fontify-block |
font-lock-fontify-region ---------------->-------------------|
|
font-lock-fontify-buffer |
[font-lock-fontify-buffer-function] (hook) |
font-lock-default-fontify-buffer |
font-lock-fontify-region ---------------->-------------------|
#########################################################################
On Mon, 20 Mar 2006, Stefan Monnier wrote:
>OK, having thought some more about it, I'm really convinced doing it
>[extending the fontification region with
>font-lock-extend-region-function] in after-change-function is the wrong
>way: your jit-lock code won't always do the right thing, because even
>though you mark the whole extended region for refontification, jit-lock
>may refontify it in chunks (and maybe not even in the intended order).
OK, I see what you're saying, now, I think - if you insert a large chunk
of text with C-y, font-lock-extend-region will calculate a starting
position off the top of the screen. The display engine will then,
however, call jit-lock-function with the screen beginning as the place to
start, and this won't work properly. I agree with you now.
>So I will move the font-lock-extend-region code to
>font-lock-default-fontify-region where it belongs (which is why that's
>also the place where font-lock-extra-lines was handled and where
>font-lock-multiline is handled).
I think there are two distinct issues here that we're confusing, and this
is why we've found it so hard to agree:
(i) calculating the region which needs refontifying.
(ii) finding a safe place to start fontifying a single chunk.
font-lock-extend-region-function is intended to do (i). The
functionality you're suggesting for f-l-default-fontify-region is for
doing (ii).
>Now IIUC that means it'll break some/all of your uses of that variable.
>Clearly you won't be pleased, but think about it this way: it'll save
>you bug reports from users seeing odd behavior in conjunction with
>jit-lock.
OK, I understand this now.
>Anyway, as I said, for your use case what you should be using is an
>after-change-functions hook that puts a font-lock-multiline property.
>But as you noted, this will only work if your hook happens to be placed
>in after-change-functions before font-lock's own (or jit-lock's, though
>that one is much less serious).
I think the essence of the font-lock-multiline property is that it marks
a chunk of text to be fontified atomically. Please confirm this
impression or correct it for me.
Here's why I think the font-lock-muliline way is wrong. Taking my AWK
example again:
1. "string \
2. over \
3. several \ <=========
4. #lines."
Suppose the user replaces the backslash on L3 with 20k of code from the
kill ring with M-y. The region to fontify now extends from L1 to EOL4
(actually, it's now L1073). The display engine is going to request
fontification from L1034. If I mark this entire region with
font-lock-multiline, these 1073 lines will be (unnecessarily) fontified
atomically, defeating the aims of jit-lock in this case. What I think we
need is a function called from f-l-default-f-region which will get a safe
starting position at or before L1034.
>Also as I mentioned elsewhere, another solution is to change your
>requirement such that some of the responsibility of the refontification
>is passed on to contextual refontification: I would tend to prefer this
>solution myself (it moves work away from the time-critical path). But
>admittedly, setting jit-lock-context-time to 0 is believed to be a bit
>too costly right now (not enough optimizations), so if you really want
>the refontification to be immediate (rather than delayed by 0.5 idle
>seconds), it's not a good solution.
I do, and it's not. :-)
>So what I offer you is to introduce a new
>`font-lock-before-after-change-functions' which is just like
>after-change-functions except it's run by font-lock's (or jit-lock's)
>after-change-function and before it does anything else. You can then
>use this hook to place a function that computes the extended region and
>places a font-lock-multiline property on it.
For the reasons I've given above, I don't think this is the right thing
to do. What I think we should do is to put a hook into
f-l-default-f-region to calculate a safe starting position (and probably
also a safe stopping position).
>Do we have a deal?
Not quite. But I'm sure we'll soon be there. :-)
Incidentally, referring to my diagram above, the region gets extended to
whole lines more than once. For demand fontification, it is done first
in jit-lock-fontify-now then in font-lock-default-fontify-region. For
after-change fontification, it is done yet a third time in
jit-lock-after-change.
How about doing this only in f-l-default-f-r? This would make it easier
for a mode maintainer to switch off this action, since he would then just
have to put a modified function into the hook
font-lock-fontify-region-function.
> Stefan
--
Alan.
next prev parent reply other threads:[~2006-03-20 13:01 UTC|newest]
Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1D94Wo-0006AP-W2@fencepost.gnu.org>
2005-03-09 21:18 ` [sigra@home.se: C++-mode: Syntax highlighting: wrong color for function identifier depending on the kind of whitespace that follows] Alan Mackenzie
2005-03-09 22:35 ` Stefan Monnier
2005-03-10 8:00 ` Alan Mackenzie
2005-03-10 13:01 ` Stefan Monnier
2005-03-10 15:16 ` D. R. E. Moonfire
2005-03-10 17:01 ` Stefan Monnier
2005-03-10 20:09 ` Alan Mackenzie
2005-03-10 20:53 ` Stefan Monnier
2005-03-10 22:42 ` Alan Mackenzie
2005-03-11 20:28 ` Richard Stallman
2005-03-11 1:48 ` Richard Stallman
2005-03-11 19:43 ` Alan Mackenzie
2005-03-10 22:13 ` Martin Stjernholm
2005-03-10 22:59 ` Stefan Monnier
2005-03-11 20:27 ` Richard Stallman
2005-03-13 16:19 ` Martin Stjernholm
2005-03-14 1:07 ` Stefan Monnier
2005-03-19 22:23 ` Martin Stjernholm
2005-03-19 22:30 ` Stefan Monnier
2005-03-11 1:47 ` Richard Stallman
2005-03-11 4:47 ` Stefan Monnier
2005-03-12 0:56 ` Richard Stallman
2005-03-12 1:00 ` Stefan Monnier
2005-03-13 15:30 ` Richard Stallman
2005-03-11 1:46 ` Richard Stallman
2005-03-11 1:46 ` Richard Stallman
2006-02-12 13:06 ` Ralf Angeli
2006-02-12 16:20 ` Stefan Monnier
2006-02-12 22:58 ` Ralf Angeli
2006-02-13 22:10 ` Stefan Monnier
2006-02-14 7:53 ` martin rudalics
2006-02-14 19:00 ` Stefan Monnier
2006-02-14 20:13 ` martin rudalics
2006-02-14 21:08 ` Stefan Monnier
2006-02-15 10:17 ` martin rudalics
2006-02-15 10:38 ` Ralf Angeli
2006-02-15 14:20 ` martin rudalics
2006-02-15 14:56 ` Ralf Angeli
2006-02-15 16:40 ` martin rudalics
2006-02-15 17:03 ` Ralf Angeli
2006-02-16 11:10 ` Alan Mackenzie
2006-02-16 11:54 ` Vivek Dasmohapatra
2006-02-16 15:21 ` Stefan Monnier
2006-02-16 23:28 ` David Kastrup
2006-02-17 14:19 ` Stefan Monnier
2006-02-16 17:21 ` martin rudalics
2006-02-15 20:44 ` Alan Mackenzie
2006-02-16 0:40 ` Stefan Monnier
2006-02-15 20:56 ` Alan Mackenzie
2006-02-16 8:56 ` martin rudalics
2006-02-15 20:13 ` Alan Mackenzie
2006-02-16 9:02 ` martin rudalics
2006-02-14 8:18 ` Werner LEMBERG
2006-02-14 8:49 ` Ralf Angeli
2006-02-14 19:05 ` Stefan Monnier
2006-02-14 21:12 ` Ralf Angeli
2006-02-15 13:35 ` Stefan Monnier
2006-02-15 14:05 ` Ralf Angeli
2006-02-15 14:21 ` Ralf Angeli
2006-02-15 20:33 ` Alan Mackenzie
2006-02-15 21:13 ` Stefan Monnier
2006-02-15 21:59 ` Alan Mackenzie
2006-02-16 14:59 ` Kim F. Storm
2006-02-16 16:37 ` Stefan Monnier
2006-02-15 19:07 ` Alan Mackenzie
2006-02-15 21:42 ` Ralf Angeli
2006-02-16 11:20 ` Alan Mackenzie
2006-02-16 11:54 ` Ralf Angeli
2006-02-16 15:12 ` Alan Mackenzie
2006-02-17 7:56 ` martin rudalics
2006-02-17 11:32 ` Ralf Angeli
2006-02-17 13:22 ` martin rudalics
2006-02-17 13:33 ` Ralf Angeli
2006-02-16 16:32 ` Stefan Monnier
2006-02-16 0:38 ` Stefan Monnier
2006-02-16 9:51 ` Alan Mackenzie
2006-02-16 16:27 ` Stefan Monnier
2006-02-17 7:48 ` martin rudalics
2006-02-17 14:36 ` Stefan Monnier
2006-02-16 18:46 ` martin rudalics
2006-02-16 9:09 ` martin rudalics
2006-02-13 4:40 ` Richard M. Stallman
2006-02-13 5:25 ` Stefan Monnier
2006-02-14 0:39 ` Richard M. Stallman
2006-03-14 19:23 ` Alan Mackenzie
2006-03-14 22:11 ` Stefan Monnier
2006-03-15 8:52 ` martin rudalics
2006-03-15 9:02 ` Ralf Angeli
2006-03-15 10:22 ` Stefan Monnier
2006-03-15 11:40 ` Alan Mackenzie
2006-03-15 16:16 ` Stefan Monnier
2006-03-15 20:20 ` Richard Stallman
2006-03-20 8:16 ` font-lock-extend-region (was: [sigra@home.se: C++-mode: Syntax highlighting: wrong color for function identifier depending on the kind of whitespace that follows]) Stefan Monnier
2006-03-20 13:01 ` Alan Mackenzie [this message]
2006-03-20 17:18 ` font-lock-extend-region Stefan Monnier
2006-03-21 16:05 ` font-lock-extend-region Alan Mackenzie
2006-03-21 21:32 ` font-lock-extend-region Stefan Monnier
2006-03-23 15:23 ` font-lock-extend-region Alan Mackenzie
2006-03-23 16:18 ` font-lock-extend-region Stefan Monnier
2006-02-15 19:34 ` [sigra@home.se: C++-mode: Syntax highlighting: wrong color for function identifier depending on the kind of whitespace that follows] Alan Mackenzie
2006-02-16 9:07 ` Ralf Angeli
2006-02-16 9:07 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.3.96.1060320110347.318B-100000@acm.acm \
--to=acm@muc.de \
--cc=angeli@iwi.uni-sb.de \
--cc=bug-cc-mode@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=rms@gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.