From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Davis Herring Newsgroups: gmane.emacs.bugs Subject: Minor comint.el patch Date: Thu, 25 Sep 2003 07:40:31 -0500 (CDT) Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Message-ID: References: NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="-559023410-1903590565-1064493569=:383" X-Trace: sea.gmane.org 1064494125 29085 80.91.224.253 (25 Sep 2003 12:48:45 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 25 Sep 2003 12:48:45 +0000 (UTC) Cc: Richard Stallman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Sep 25 14:48:42 2003 Return-path: Original-Received: from monty-python.gnu.org ([199.232.76.173]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1A2VY2-0001c2-00 for ; Thu, 25 Sep 2003 14:48:42 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.22) id 1A2VUD-0000F2-6u for geb-bug-gnu-emacs@m.gmane.org; Thu, 25 Sep 2003 08:44:45 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.22) id 1A2VTx-0000Bq-10 for bug-gnu-emacs@gnu.org; Thu, 25 Sep 2003 08:44:29 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.22) id 1A2VTt-0000BN-UJ for bug-gnu-emacs@gnu.org; Thu, 25 Sep 2003 08:44:27 -0400 Original-Received: from [130.18.80.10] (helo=Ra.MsState.Edu) by monty-python.gnu.org with esmtp (Exim 4.22) id 1A2VQC-00086D-6V; Thu, 25 Sep 2003 08:40:36 -0400 Original-Received: from ra.msstate.edu (localhost [127.0.0.1]); by Ra.MsState.Edu (8.12.9/8.12.8/ra_1.2) with ESMTP; id h8PCeWwx011456; Thu, 25 Sep 2003 07:40:32 -0500 (CDT) Original-Received: from localhost (sdh6@localhost) by ra.msstate.edu (8.12.9/8.12.7/Submit) with ESMTP id h8PCeVq7011453; Thu, 25 Sep 2003 07:40:32 -0500 (CDT) Original-To: "'Emacs Bug'" In-Reply-To: Content-ID: X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.2 Precedence: list List-Id: Bug reports for GNU Emacs, the Swiss army knife of text editors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.bugs:5854 X-Report-Spam: http://spam.gmane.org/gmane.emacs.bugs:5854 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. Send mail to mime@docserver.cac.washington.edu for more info. ---559023410-1903590565-1064493569=:383 Content-Type: TEXT/PLAIN; CHARSET=US-ASCII Content-ID: Quoting Richard Stallman's mail of Tue, 23 Sep 2003 19:13:18 -0400: > David's suggestion seems right to me. > I will get it installed. Thanks. I'm assuming that you're referring either to my comment about (and pw (send-invisible pw)), or else to Kevin Rodgers' suggestion of (send-invisible (or pw "")) ... Unfortunately, neither one of these is particularly useful; neither one of them prints any sort of message (not even 'Quit') to indicate that the password is no longer being read invisibly, and the latter actually sends something (even if it's just a newline) when the user tries to abort the command -- Bad Thing. I believe what we want is a slight reorganization of those functions; unless they get heavy Lisp usage, it shouldn't cause much incompatibility damage. The attached patch (versus 21.3.1) causes there to be no further prompt but rather the proper warning when the user quits. I also added references to 'clear-this-command-keys' in the docstrings; would it make sense to make that function interactive? Davis Herring -- Ship Quantum Express -- the honest company that admits to having no idea when your shipment will get there or where it will be when it does! ---559023410-1903590565-1064493569=:383 Content-Type: TEXT/PLAIN; CHARSET=US-ASCII; NAME="comint.diff" Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: New vs. 21.3.1 Content-Disposition: ATTACHMENT; FILENAME="comint.diff" KioqIGNvbWludC0yMS4zLmVsCVRodSBTZXAgMjUgMDc6MTM6MzIgMjAwMw0K LS0tIGNvbWludC5lbAlUaHUgU2VwIDI1IDA3OjMzOjI2IDIwMDMNCioqKioq KioqKioqKioqKg0KKioqIDE4NzQsMTg4MCAqKioqDQogIGZpbHRlciBhbmQg Qy1nIGlzIHByZXNzZWQsIHRoaXMgZnVuY3Rpb24gcmV0dXJucyBuaWwgcmF0 aGVyIHRoYW4gYSBzdHJpbmcpLg0KICANCiAgTm90ZSB0aGF0IHRoZSBrZXlz dHJva2VzIGNvbXByaXNpbmcgdGhlIHRleHQgY2FuIHN0aWxsIGJlIHJlY292 ZXJlZA0KISBcKHRlbXBvcmFyaWx5KSB3aXRoIFxcW3ZpZXctbG9zc2FnZV0u ICBTb21lIHBlb3BsZSBmaW5kIHRoaXMgd29ycnlzb21lLg0KICBPbmNlIHRo ZSBjYWxsZXIgdXNlcyB0aGUgcGFzc3dvcmQsIGl0IGNhbiBlcmFzZSB0aGUg cGFzc3dvcmQNCiAgYnkgZG9pbmcgKGZpbGxhcnJheSBTVFJJTkcgMCkuIg0K ICAgIChsZXQgKChhbnMgIiIpDQotLS0gMTg3NCwxODgxIC0tLS0NCiAgZmls dGVyIGFuZCBDLWcgaXMgcHJlc3NlZCwgdGhpcyBmdW5jdGlvbiByZXR1cm5z IG5pbCByYXRoZXIgdGhhbiBhIHN0cmluZykuDQogIA0KICBOb3RlIHRoYXQg dGhlIGtleXN0cm9rZXMgY29tcHJpc2luZyB0aGUgdGV4dCBjYW4gc3RpbGwg YmUgcmVjb3ZlcmVkDQohIFwodGVtcG9yYXJpbHkpIHdpdGggXFxbdmlldy1s b3NzYWdlXS4gIFNvbWUgcGVvcGxlIGZpbmQgdGhpcyB3b3JyeXNvbWUgKHNl ZSwNCiEgaG93ZXZlciwgYGNsZWFyLXRoaXMtY29tbWFuZC1rZXlzJykuDQog IE9uY2UgdGhlIGNhbGxlciB1c2VzIHRoZSBwYXNzd29yZCwgaXQgY2FuIGVy YXNlIHRoZSBwYXNzd29yZA0KICBieSBkb2luZyAoZmlsbGFycmF5IFNUUklO RyAwKS4iDQogICAgKGxldCAoKGFucyAiIikNCioqKioqKioqKioqKioqKg0K KioqIDE5MjEsMTk0NCAqKioqDQogICAgICAgIChtZXNzYWdlICIiKQ0KICAg ICAgICBhbnMpKSkNCiAgDQohIChkZWZ1biBzZW5kLWludmlzaWJsZSAoc3Ry KQ0KICAgICJSZWFkIGEgc3RyaW5nIHdpdGhvdXQgZWNob2luZy4NCiAgVGhl biBzZW5kIGl0IHRvIHRoZSBwcm9jZXNzIHJ1bm5pbmcgaW4gdGhlIGN1cnJl bnQgYnVmZmVyLg0KICBUaGUgc3RyaW5nIGlzIHNlbnQgdXNpbmcgYGNvbWlu dC1pbnB1dC1zZW5kZXInLg0KICBTZWN1cml0eSBidWc6IHlvdXIgc3RyaW5n IGNhbiBzdGlsbCBiZSB0ZW1wb3JhcmlseSByZWNvdmVyZWQgd2l0aA0KISBc XFt2aWV3LWxvc3NhZ2VdLiINCiAgICAoaW50ZXJhY3RpdmUgIlAiKQkJCTsg RGVmZWF0IHNub29waW5nIHZpYSBDLXggRVNDIEVTQw0KICAgIChsZXQgKChw cm9jIChnZXQtYnVmZmVyLXByb2Nlc3MgKGN1cnJlbnQtYnVmZmVyKSkpKQ0K ISAgICAgKGNvbmQgKChub3QgcHJvYykNCiEgCSAgIChlcnJvciAiQ3VycmVu dCBidWZmZXIgaGFzIG5vIHByb2Nlc3MiKSkNCiEgCSAgKChzdHJpbmdwIHN0 cikNCiEgCSAgIChjb21pbnQtc25hcHNob3QtbGFzdC1wcm9tcHQpDQohIAkg ICAoZnVuY2FsbCBjb21pbnQtaW5wdXQtc2VuZGVyIHByb2Mgc3RyKSkNCiEg CSAgKHQNCiEgCSAgIChsZXQgKChzdHIgKGNvbWludC1yZWFkLW5vZWNobyAi Tm9uLWVjaG9lZCB0ZXh0OiAiIHQpKSkNCiEgCSAgICAgKGlmIChzdHJpbmdw IHN0cikNCiEgCQkgKHNlbmQtaW52aXNpYmxlIHN0cikNCiEgCSAgICAgICAo bWVzc2FnZSAiV2FybmluZzogdGV4dCB3aWxsIGJlIGVjaG9lZCIpKSkpKSkp DQogIA0KICAoZGVmdW4gY29taW50LXdhdGNoLWZvci1wYXNzd29yZC1wcm9t cHQgKHN0cmluZykNCiAgICAiUHJvbXB0IGluIHRoZSBtaW5pYnVmZmVyIGZv ciBwYXNzd29yZCBhbmQgc2VuZCB3aXRob3V0IGVjaG9pbmcuDQotLS0gMTky MiwxOTQzIC0tLS0NCiAgICAgICAgKG1lc3NhZ2UgIiIpDQogICAgICAgIGFu cykpKQ0KICANCiEgKGRlZnVuIHNlbmQtaW52aXNpYmxlICgmb3B0aW9uYWwg cHJvbXB0KQ0KICAgICJSZWFkIGEgc3RyaW5nIHdpdGhvdXQgZWNob2luZy4N CiAgVGhlbiBzZW5kIGl0IHRvIHRoZSBwcm9jZXNzIHJ1bm5pbmcgaW4gdGhl IGN1cnJlbnQgYnVmZmVyLg0KICBUaGUgc3RyaW5nIGlzIHNlbnQgdXNpbmcg YGNvbWludC1pbnB1dC1zZW5kZXInLg0KICBTZWN1cml0eSBidWc6IHlvdXIg c3RyaW5nIGNhbiBzdGlsbCBiZSB0ZW1wb3JhcmlseSByZWNvdmVyZWQgd2l0 aA0KISBcXFt2aWV3LWxvc3NhZ2VdOyBgY2xlYXItdGhpcy1jb21tYW5kLWtl eXMnIGNhbiBmaXggdGhhdC4iDQogICAgKGludGVyYWN0aXZlICJQIikJCQk7 IERlZmVhdCBzbm9vcGluZyB2aWEgQy14IEVTQyBFU0MNCiAgICAobGV0ICgo cHJvYyAoZ2V0LWJ1ZmZlci1wcm9jZXNzIChjdXJyZW50LWJ1ZmZlcikpKSkN CiEgICAgIChpZiBwcm9jDQohIAkobGV0ICgoc3RyIChjb21pbnQtcmVhZC1u b2VjaG8gKG9yIHByb21wdCAiTm9uLWVjaG9lZCB0ZXh0OiAiKSB0KSkpDQoh IAkgIChpZiAoc3RyaW5ncCBzdHIpDQohIAkgICAgICAocHJvZ24NCiEgCQko Y29taW50LXNuYXBzaG90LWxhc3QtcHJvbXB0KQ0KISAJCShmdW5jYWxsIGNv bWludC1pbnB1dC1zZW5kZXIgcHJvYyBzdHIpKQ0KISAJICAgIChtZXNzYWdl ICJXYXJuaW5nOiB0ZXh0IHdpbGwgYmUgZWNob2VkIikpKQ0KISAgICAgICAo ZXJyb3IgIkN1cnJlbnQgYnVmZmVyIGhhcyBubyBwcm9jZXNzIikpKSkNCiAg DQogIChkZWZ1biBjb21pbnQtd2F0Y2gtZm9yLXBhc3N3b3JkLXByb21wdCAo c3RyaW5nKQ0KICAgICJQcm9tcHQgaW4gdGhlIG1pbmlidWZmZXIgZm9yIHBh c3N3b3JkIGFuZCBzZW5kIHdpdGhvdXQgZWNob2luZy4NCioqKioqKioqKioq KioqKg0KKioqIDE5NDgsMTk1NSAqKioqDQogIA0KICBUaGlzIGZ1bmN0aW9u IGNvdWxkIGJlIGluIHRoZSBsaXN0IGBjb21pbnQtb3V0cHV0LWZpbHRlci1m dW5jdGlvbnMnLiINCiAgICAod2hlbiAoc3RyaW5nLW1hdGNoIGNvbWludC1w YXNzd29yZC1wcm9tcHQtcmVnZXhwIHN0cmluZykNCiEgICAgIChsZXQgKChw dyAoY29taW50LXJlYWQtbm9lY2hvIHN0cmluZyB0KSkpDQohICAgICAgIChz ZW5kLWludmlzaWJsZSBwdykpKSkNCiAgDA0KICA7OyBMb3ctbGV2ZWwgcHJv Y2VzcyBjb21tdW5pY2F0aW9uDQogIA0KLS0tIDE5NDcsMTk1MyAtLS0tDQog IA0KICBUaGlzIGZ1bmN0aW9uIGNvdWxkIGJlIGluIHRoZSBsaXN0IGBjb21p bnQtb3V0cHV0LWZpbHRlci1mdW5jdGlvbnMnLiINCiAgICAod2hlbiAoc3Ry aW5nLW1hdGNoIGNvbWludC1wYXNzd29yZC1wcm9tcHQtcmVnZXhwIHN0cmlu ZykNCiEgICAgIChzZW5kLWludmlzaWJsZSBzdHJpbmcpKSkNCiAgDA0KICA7 OyBMb3ctbGV2ZWwgcHJvY2VzcyBjb21tdW5pY2F0aW9uDQogIA0K ---559023410-1903590565-1064493569=:383 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Bug-gnu-emacs mailing list Bug-gnu-emacs@gnu.org http://mail.gnu.org/mailman/listinfo/bug-gnu-emacs ---559023410-1903590565-1064493569=:383--