Re: How to let hl-line-mode ignore text with non-default background color?

Re: How to let hl-line-mode ignore text with non-default background color?

[zhang cc]

[-- Attachment #1: Type: text/plain, Size: 115 bytes --]

Problem like this: https://stackoverflow.com/questions/6562424/emacs-hl-line-mode-conflicts-with-highlight-phrase

[-- Attachment #2: Type: text/html, Size: 527 bytes --]

How to let hl-line-mode ignore text with non-default background color?

[zhang cc]

[-- Attachment #1: Type: text/plain, Size: 240 bytes --]

Text with face custom background color or with inverse-video be set.

These text usually is important ones like TODO in org-mode or matched words in search result. But hl-line-mode makes them can’t be seen clearly which is annoying.


[-- Attachment #2: Type: text/html, Size: 712 bytes --]

Re: How to let hl-line-mode ignore text with non-default background color?

[Eli Zaretskii]

> From: zhang cc <ccsmile2008@outlook.com>
> Date: Tue, 9 Jan 2018 02:25:10 +0000
> 
> Text with face custom background color or with inverse-video be set. 
> 
> These text usually is important ones like TODO in org-mode or matched words in search result. But
> hl-line-mode makes them can’t be seen clearly which is annoying.

Please show an example of this.  I don't see a problem with the
default face definitions, at least not with display of search matches.
(I've read the stack-overflow question, and I still am not sure what
is the problem, since hl-line's background is rather light, and should
be very different from any reasonable foreground.)  Maybe you use some
theme that is a factor here, or maybe your face customizations are
involved.

IOW, please show a complete recipe for reproducing the problem (it is
also advisable to post that with "M-x report-emacs-bug RET", so the
issue is recorded by the Emacs issue tracker).

Thanks.

Re: How to let hl-line-mode ignore text with non-default background color?

[zhang cc]

[-- Attachment #1: Type: text/plain, Size: 1724 bytes --]


On 9 Jan 2018, 11:46 AM +0800, Eli Zaretskii <eliz@gnu.org>, wrote:
From: zhang cc <ccsmile2008@outlook.com
Date: Tue, 9 Jan 2018 02:25:10 +0000

Text with face custom background color or with inverse-video be set.

These text usually is important ones like TODO in org-mode or matched words in search result. But
hl-line-mode makes them can’t be seen clearly which is annoying.

Please show an example of this. I don't see a problem with the
default face definitions, at least not with display of search matches.
(I've read the stack-overflow question, and I still am not sure what
is the problem, since hl-line's background is rather light, and should
be very different from any reasonable foreground.) Maybe you use some
theme that is a factor here, or maybe your face customizations are
involved.

IOW, please show a complete recipe for reproducing the problem (it is
also advisable to post that with "M-x report-emacs-bug RET", so the
issue is recorded by the Emacs issue tracker).

Thanks.


Yes, it is face related. And hl-line can dim good faces (often for highlight use).

1. Open emacs with “-Q” arg
2. In the scratch buffer, eval the following form:

(progn
  (text-mode)
  (hl-line-mode)
  (defface test-face
'((((class color) (background light))
       :foreground "darkseagreen2" :background "black")
      (((class color) (background dark))
       :foreground "darkolivegreen" :background "white")
      (t :inverse-video t))
"test face")
  (set-text-properties (point-min) (point-max) `(face test-face)))

3. Then move cursor across lines in buffer. Foreground color of text is the same as background color set by hl-line-mode, and text can’t be seen.



[-- Attachment #2: Type: text/html, Size: 2930 bytes --]

Re: How to let hl-line-mode ignore text with non-default background color?

[Eli Zaretskii]

> From: zhang cc <ccsmile2008@outlook.com>
> CC: "emacs-devel@gnu.org" <emacs-devel@gnu.org>
> Date: Tue, 9 Jan 2018 06:21:47 +0000
> 1. Open emacs with “-Q” arg
> 2. In the scratch buffer, eval the following form:
> 
> (progn
>   (text-mode)
>   (hl-line-mode)
>   (defface test-face
> '((((class color) (background light))
>        :foreground "darkseagreen2" :background "black")
>       (((class color) (background dark))
>        :foreground "darkolivegreen" :background "white")
>       (t :inverse-video t))
> "test face")
>   (set-text-properties (point-min) (point-max) `(face test-face)))
> 
> 3. Then move cursor across lines in buffer. Foreground color of text is the same as background color set by hl-line-mode, and text can’t be seen.

If you must set the foreground of the text the same as the background
of the hl-line face, then customize the hl-line face to define the
"distant foreground" color for it.  E.g., I defined the "distant
foreground" to be black, and the problem went away.

Re: How to let hl-line-mode ignore text with non-default background color?

[zhang cc]

[-- Attachment #1.1: Type: text/plain, Size: 600 bytes --]


On 10 Jan 2018, 3:12 AM +0800, Eli Zaretskii <eliz@gnu.org>, wrote:

If you must set the foreground of the text the same as the background
of the hl-line face, then customize the hl-line face to define the
"distant foreground" color for it. E.g., I defined the "distant
foreground" to be black, and the problem went away.


Tried with some colors. It didn’t always work well. For example, in the following picture, the left is the test code, the right is the details of the face hl-line, the highlighted one line in the left window is the result.
[cid:5EBA4A6DE49D4C27A93FF932987C8227]

[-- Attachment #1.2: Type: text/html, Size: 1268 bytes --]

[-- Attachment #2: distant_foreground-1.png --]
[-- Type: image/png, Size: 601715 bytes --]

Re: How to let hl-line-mode ignore text with non-default background color?

[Eli Zaretskii]

> From: zhang cc <ccsmile2008@outlook.com>
> CC: "emacs-devel@gnu.org" <emacs-devel@gnu.org>
> Date: Wed, 10 Jan 2018 09:23:46 +0000
> 
> On 10 Jan 2018, 3:12 AM +0800, Eli Zaretskii <eliz@gnu.org>, wrote: 
> 
>  If you must set the foreground of the text the same as the background
>  of the hl-line face, then customize the hl-line face to define the
>  "distant foreground" color for it. E.g., I defined the "distant
>  foreground" to be black, and the problem went away. 
> 
> Tried with some colors. It didn’t always work well. For example, in the following picture, the left is the test
> code, the right is the details of the face hl-line, the highlighted one line in the left window is the result.

That's because you've chosen the distant foreground poorly.

Look, you can always shoot yourself in the foot if you intentionally
arrange your colors to produce bad contrast.  That doesn't prove
anything, certainly not that there's a bug or a missing feature.  If
you play with colors, you need to choose them carefully, that's all.

Re: How to let hl-line-mode ignore text with non-default background color?

[zhang cc]

[-- Attachment #1: Type: text/plain, Size: 582 bytes --]


On 10 Jan 2018, 11:38 PM +0800, Eli Zaretskii <eliz@gnu.org>, wrote:

That's because you've chosen the distant foreground poorly.

Look, you can always shoot yourself in the foot if you intentionally
arrange your colors to produce bad contrast. That doesn't prove
anything, certainly not that there's a bug or a missing feature. If
you play with colors, you need to choose them carefully, that's all.

Even it works, it is not a perfect solution. I think let hl-line ignoring text with non-default background color will be better. I will file a bug for it.

Thanks.


[-- Attachment #2: Type: text/html, Size: 1127 bytes --]