From: HaiJun Zhang <netjune@outlook.com>
To: Michael Albinus <michael.albinus@gmx.de>, Eli Zaretskii <eliz@gnu.org>
Cc: "38287@debbugs.gnu.org" <38287@debbugs.gnu.org>
Subject: bug#38287: 26.3.50; filenotify.el: the Chinese file name in the event is messy code
Date: Thu, 21 Nov 2019 02:33:42 +0000 [thread overview]
Message-ID: <PS1PR03MB3606C0FEFD4A8D0CE74C07FFB74E0@PS1PR03MB3606.apcprd03.prod.outlook.com> (raw)
In-Reply-To: <83imnez9q9.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1827 bytes --]
在 2019年11月21日 +0800 AM2:24,Eli Zaretskii <eliz@gnu.org>,写道:
From: Michael Albinus <michael.albinus@gmx.de>
Cc: netjune@outlook.com, 38287@debbugs.gnu.org
Date: Wed, 20 Nov 2019 18:49:34 +0100
The strings shown in the image are UTF-8 encoded.
Hmm. kqueue.c is very lazy in using ENCODE_FILE, it uses it only in
kqueue-add-watch. Maybe it is missing somewhere else?
I see one potential problem: in kqueue-add-watch, you encode the file
name, but then pass it to APIs that generally expect multibyte
(i.e. un-encoded) strings, although they will also work with encoded
unibyte strings. Moreover, you put the unibyte encoded file name into
the watch object. Not sure if this is related to the issue at hand,
but it would be cleaner to make this change:
diff --git a/src/kqueue.c b/src/kqueue.c
index 76d7fc1..1383d7d 100644
--- a/src/kqueue.c
+++ b/src/kqueue.c
@@ -414,7 +414,7 @@ DEFUN ("kqueue-add-watch", Fkqueue_add_watch, Skqueue_add_watch, 3, 3, 0,
}
/* Open file. */
- file = ENCODE_FILE (file);
+ Lisp_Object encoded_file = ENCODE_FILE (file);
oflags = O_NONBLOCK;
#if O_EVTONLY
oflags |= O_EVTONLY;
@@ -426,7 +426,7 @@ DEFUN ("kqueue-add-watch", Fkqueue_add_watch, Skqueue_add_watch, 3, 3, 0,
#else
oflags |= O_NOFOLLOW;
#endif
- fd = emacs_open (SSDATA (file), oflags, 0);
+ fd = emacs_open (SSDATA (encoded_file), oflags, 0);
if (fd == -1)
report_file_error ("File cannot be opened", file);
It is fixed by your patch. Thanks.
A question:
I print the value of file and encoded_file with safe_debug_print in kqueue.c. The former is normal string. The latter is messy code. What is the encoding of encoded_file? The value of file-name-coding-system is utf-8-hfs. How much does utf-8-hfs diff with utf-8-unix? Is utf-8-hfs not really utf-8?
[-- Attachment #2: Type: text/html, Size: 2962 bytes --]
next prev parent reply other threads:[~2019-11-21 2:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <aeef7181-2c14-4b93-90fd-dd71993ed3c8@Spark>
2019-11-20 3:50 ` bug#38287: 26.3.50; filenotify.el: the Chinese file name in the event is messy code HaiJun Zhang
2019-11-20 16:32 ` Michael Albinus
2019-11-20 17:35 ` Eli Zaretskii
2019-11-20 17:49 ` Michael Albinus
2019-11-20 18:25 ` Eli Zaretskii
2019-11-20 18:45 ` Michael Albinus
2019-11-21 0:35 ` HaiJun Zhang
2019-11-21 2:33 ` HaiJun Zhang [this message]
2019-11-21 14:42 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PS1PR03MB3606C0FEFD4A8D0CE74C07FFB74E0@PS1PR03MB3606.apcprd03.prod.outlook.com \
--to=netjune@outlook.com \
--cc=38287@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.