From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: HaiJun Zhang Newsgroups: gmane.emacs.bugs Subject: bug#38731: [PATCH] Calculate first glyph to be redrawn when exposing (bug#38731) Date: Mon, 30 Dec 2019 12:55:09 +0800 Message-ID: References: <20191227143500.GA75733@breton.holly.idiocy.org> <20191227162620.GA92799@breton.holly.idiocy.org> <83a77dpu28.fsf@gnu.org> <20191227190652.GA92850@breton.holly.idiocy.org> <83v9q0omn9.fsf@gnu.org> <20191228112013.GA93177@breton.holly.idiocy.org> <83imm0nw4o.fsf@gnu.org> <20191229104629.GA94094@breton.holly.idiocy.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="5e098332_6590700b_4379" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="168489"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 38731-done@debbugs.gnu.org To: Eli Zaretskii , Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 30 05:56:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iln6D-000heo-21 for geb-bug-gnu-emacs@m.gmane.org; Mon, 30 Dec 2019 05:56:13 +0100 Original-Received: from localhost ([::1]:58446 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iln6B-0007Rh-Bz for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 Dec 2019 23:56:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37674) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iln63-0007RF-PM for bug-gnu-emacs@gnu.org; Sun, 29 Dec 2019 23:56:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iln62-0003eH-Ie for bug-gnu-emacs@gnu.org; Sun, 29 Dec 2019 23:56:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54469) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iln62-0003eC-FS for bug-gnu-emacs@gnu.org; Sun, 29 Dec 2019 23:56:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iln62-0000YW-DQ for bug-gnu-emacs@gnu.org; Sun, 29 Dec 2019 23:56:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: HaiJun Zhang Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Dec 2019 04:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38731 X-GNU-PR-Package: emacs Original-Received: via spool by 38731-done@debbugs.gnu.org id=D38731.15776817302097 (code D ref 38731); Mon, 30 Dec 2019 04:56:02 +0000 Original-Received: (at 38731-done) by debbugs.gnu.org; 30 Dec 2019 04:55:30 +0000 Original-Received: from localhost ([127.0.0.1]:60442 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iln5V-0000Xl-MN for submit@debbugs.gnu.org; Sun, 29 Dec 2019 23:55:29 -0500 Original-Received: from mail-oln040092254017.outbound.protection.outlook.com ([40.92.254.17]:4666 helo=APC01-PU1-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iln5T-0000XW-Fw for 38731-done@debbugs.gnu.org; Sun, 29 Dec 2019 23:55:29 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ltmynsBicM+QKkpO886lAHhxCK/xN8ZgvL8pjWQbMd8RCqRi9Dspz1TxlH8V8yfPx3DVGvuiC3/y2Z3tWb3gK0H2JrxQysrUJXLmcjCOMk+MUyWEDRxZvA7YP823Cue4/Y/HZj7CASCIs6ZD0clZWAAFn9acxnfjUyBKUGuAlCa6cYoPdla/FMXihOtlWX0ODuakB0pmXjouHDHVQJpqMv48ep3kaH/xdr0034Is/gjtb7uyg9TgQfoBtyBRfOsy4/4i1LTsC1cP93qOdzagyS8n0A6dOmsPVmSlDZnlYN/IYnC1o6Yope4NEY1niJdF8FFLEdZhyapegIr3Hxu2VA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FI41N5T+YF4iqCYmLwShEGvf/TzTiJT/k1K7RYJfy2I=; b=Kx00Y1Tg5QOjmiA/6CzcxIrvocymD8YUpUdQu8lW2soqy0DDINin7Smnj0wIVD3+UZ9alkOw9iYjCqT0/16Xh390apk89zIm8b9C3QOsiTYr0BnTkKEtaex7fgI44rcwTHGk0suuTnHgWcSVrh9ZoZ1ubOG1muHVIdBN6FUBIcUa6tCsmfzlISO6c68qWALbmoKAYniJfmCPosWAKGduCeVXT7R4J7Uqa3ZI3/DbYR9HGyE/NrfHa9weRGHaYewtvVxrDpQCKhBSjtd3raIPA0AOSftydCIFInxL/Z/dVcCo5pXXd52SCFfdBcyaU/KhqL2ONYU/V4z/uX17n7N6tA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=outlook.com; dmarc=pass action=none header.from=outlook.com; dkim=pass header.d=outlook.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FI41N5T+YF4iqCYmLwShEGvf/TzTiJT/k1K7RYJfy2I=; b=W04ZFXxKe6WJwHKjGvShIJQMuDYobACgYcVQ0VdYCIoUN6+y+gPtJjFgLpc/g4AeUS65vepSExQuWeGAjBd29mmzhiAdgVN2eL63xKgVepqFyze4ofi4lCzEjWFtxb+yINWriswjwD/90WG6AsreK1DbnNPJcRza+bBh/Mqv4udxWhYK9yAwGZj1PmJIxCsMPL812v+b/tF7A2NWxPBvXEbACFAhh23BGenLI58akBDiNEboa6lszykAkRLAiLLB3FFL6BDZCQCRxOjOdyWEHnNjZ9ChIrv9fhZD9oDsN+tJ+BujS8YJV/f66+g16GmLJhE8LjHrJKzK+MCRFn/11Q== Original-Received: from HK2APC01FT050.eop-APC01.prod.protection.outlook.com (10.152.248.60) by HK2APC01HT246.eop-APC01.prod.protection.outlook.com (10.152.249.159) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2581.11; Mon, 30 Dec 2019 04:55:19 +0000 Original-Received: from PS1PR03MB3606.apcprd03.prod.outlook.com (10.152.248.57) by HK2APC01FT050.mail.protection.outlook.com (10.152.249.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2581.11 via Frontend Transport; Mon, 30 Dec 2019 04:55:19 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:C7F11447BFD01A20B0D8864B0942C958E2EC51A349F709356CBADDC1400BF158; UpperCasedChecksum:AFB85B339C3BE5F47D901DC8B57BD76287E9D18ACC26D926C1F741C6134A6BC9; SizeAsReceived:9072; Count:48 Original-Received: from PS1PR03MB3606.apcprd03.prod.outlook.com ([fe80::b05a:28e4:205a:d7d4]) by PS1PR03MB3606.apcprd03.prod.outlook.com ([fe80::b05a:28e4:205a:d7d4%5]) with mapi id 15.20.2602.009; Mon, 30 Dec 2019 04:55:19 +0000 In-Reply-To: <20191229104629.GA94094@breton.holly.idiocy.org> X-Readdle-Message-ID: 7ea0ddee-0092-4074-bfab-66cf5bf24427@Spark X-ClientProxiedBy: HK2PR06CA0019.apcprd06.prod.outlook.com (2603:1096:202:2e::31) To PS1PR03MB3606.apcprd03.prod.outlook.com (2603:1096:803:4e::17) X-Microsoft-Original-Message-ID: <7ea0ddee-0092-4074-bfab-66cf5bf24427@Spark> Original-Received: from [192.168.1.103] (1.196.187.170) by HK2PR06CA0019.apcprd06.prod.outlook.com (2603:1096:202:2e::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2581.11 via Frontend Transport; Mon, 30 Dec 2019 04:55:17 +0000 X-Readdle-Message-ID: 7ea0ddee-0092-4074-bfab-66cf5bf24427@Spark X-Microsoft-Original-Message-ID: <7ea0ddee-0092-4074-bfab-66cf5bf24427@Spark> X-TMN: [vEtYK6DBe5ZhDsGSLwgLHHqE8L7qHt/L] X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 48 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: fe032d61-9ba9-424a-6611-08d78ce477e3 X-MS-TrafficTypeDiagnostic: HK2APC01HT246: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xyMu53mW99bDjE7fjLCKrih0BbDYBU9x2voOa3Z/Wy+WTg6uIzldQyK79i2yrijsfIeD6GqgI4LDe+fCMXro7D3pCz7iHE3Q0903RmAwC9QSyDwhTHd8Rh/p6OZIRFa4/Zr7e/OSnzacgbQ8RowYBE5oHYiLhrNZoojtqTh/uvrZGi+qfGgwce3P5TKYE/OV X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fe032d61-9ba9-424a-6611-08d78ce477e3 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Dec 2019 04:55:19.1256 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK2APC01HT246 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:173919 Archived-At: --5e098332_6590700b_4379 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline It is fixed. Thanks. Can you see another bug=C2=A0=2338727. It is also=C2=A0Darwin-specific. I= t causes flicker. =E5=9C=A8 2019=E5=B9=B412=E6=9C=8829=E6=97=A5 +0800 PM6:46=EF=BC=8CAlan T= hird =EF=BC=8C=E5=86=99=E9=81=93=EF=BC=9A > On Sat, Dec 28, 2019 at 08:27:35PM +0200, Eli Zaretskii wrote: > > > Date: Sat, 28 Dec 2019 11:20:13 +0000 > > > =46rom: Alan Third > > > Cc: netjune=40outlook.com, 38731=40debbugs.gnu.org > > > > > > A minimal, and possibly correct, fix is: > > > > > > modified src/xdisp.c > > > =40=40 -33491,7 +33491,7 =40=40 expose=5Farea (struct window *w, st= ruct glyph=5Frow *row, const Emacs=5FRectangle *r, > > > > > > if (area =3D=3D TEXT=5FAREA && row->fill=5Fline=5Fp) > > > /* If row extends face to end of line write the whole line. */ > > > - draw=5Fglyphs (w, 0, row, area, > > > + draw=5Fglyphs (w, row->x, row, area, > > > 0, row->used=5Barea=5D, > > > DRAW=5FNORMAL=5FTEXT, 0); > > > else > > > > This change LGTM, thanks. If it solves your problem, then we can > > close this issue. > > Thanks. Pushed to emacs-27. > -- > Alan Third --5e098332_6590700b_4379 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline
It is fixed. Thanks.

Can you see another bug #38727. It is also Darwin-specific. It causes flicker.

=E5=9C=A8 2019=E5=B9=B412=E6=9C=8829=E6= =97=A5 +0800 PM6:46=EF=BC=8CAlan Third <alan@idiocy.org>=EF=BC=8C= =E5=86=99=E9=81=93=EF=BC=9A
On Sat, Dec 28, 2019 a= t 08:27:35PM +0200, Eli Zaretskii wrote:
Date: Sat, 28 Dec 2019= 11:20:13 +0000
From: Alan Third <alan@idiocy.org>
Cc: netjune@outlook.com, 38731@debbugs.gnu.org

A minimal, and possibly correct, fix is:

modified src/xdisp.c
@@ -33491,7 +33491,7 @@ expose_area (struct window *w, struct glyph_row= *row, const Emacs_Rectangle *r,

if (area =3D=3D TEXT_AREA && row->fill_line_p)
/* If row extends face to end of line write the whole line. */
- draw_glyphs (w, 0, row, area,
+ draw_glyphs (w, row->x, row, area,
0, row->used[area],
DRAW_NORMAL_TEXT, 0);
else

This change LGTM, thanks. If it solves your problem, then we can
close this issue.

Thanks. Pushed to emacs-27.
--
Alan Third
--5e098332_6590700b_4379--