From: HaiJun Zhang <netjune@outlook.com>
To: Eli Zaretskii <eliz@gnu.org>, Alan Third <alan@idiocy.org>
Cc: 38731-done@debbugs.gnu.org
Subject: bug#38731: [PATCH] Calculate first glyph to be redrawn when exposing (bug#38731)
Date: Mon, 30 Dec 2019 12:55:09 +0800 [thread overview]
Message-ID: <PS1PR03MB36064A34EF2D938073F04C39B7270@PS1PR03MB3606.apcprd03.prod.outlook.com> (raw)
In-Reply-To: <20191229104629.GA94094@breton.holly.idiocy.org>
[-- Attachment #1: Type: text/plain, Size: 1025 bytes --]
It is fixed. Thanks.
Can you see another bug #38727. It is also Darwin-specific. It causes flicker.
在 2019年12月29日 +0800 PM6:46，Alan Third <alan@idiocy.org>，写道：
> On Sat, Dec 28, 2019 at 08:27:35PM +0200, Eli Zaretskii wrote:
> > > Date: Sat, 28 Dec 2019 11:20:13 +0000
> > > From: Alan Third <alan@idiocy.org>
> > > Cc: netjune@outlook.com, 38731@debbugs.gnu.org
> > >
> > > A minimal, and possibly correct, fix is:
> > >
> > > modified src/xdisp.c
> > > @@ -33491,7 +33491,7 @@ expose_area (struct window *w, struct glyph_row *row, const Emacs_Rectangle *r,
> > >
> > > if (area == TEXT_AREA && row->fill_line_p)
> > > /* If row extends face to end of line write the whole line. */
> > > - draw_glyphs (w, 0, row, area,
> > > + draw_glyphs (w, row->x, row, area,
> > > 0, row->used[area],
> > > DRAW_NORMAL_TEXT, 0);
> > > else
> >
> > This change LGTM, thanks. If it solves your problem, then we can
> > close this issue.
>
> Thanks. Pushed to emacs-27.
> --
> Alan Third
[-- Attachment #2: Type: text/html, Size: 2146 bytes --]
prev parent reply other threads:[~2019-12-30 4:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <a0dc5800-db7e-4091-b385-e2c888f9472b@Spark>
2019-12-24 10:43 ` bug#38731: 27.0.50; Unexpected redisplay behaviour. Cursor can’t be moved to end of line HaiJun Zhang
2019-12-24 15:50 ` Eli Zaretskii
2019-12-24 16:42 ` HaiJun Zhang
2019-12-26 12:59 ` Alan Third
2019-12-26 13:24 ` HaiJun Zhang
2019-12-26 17:29 ` Eli Zaretskii
2019-12-27 14:35 ` Alan Third
2019-12-27 16:26 ` bug#38731: [PATCH] Calculate first glyph to be redrawn when exposing (bug#38731) Alan Third
2019-12-27 17:17 ` Eli Zaretskii
2019-12-27 19:06 ` Alan Third
2019-12-28 8:54 ` Eli Zaretskii
2019-12-28 11:20 ` Alan Third
2019-12-28 18:27 ` Eli Zaretskii
2019-12-29 10:46 ` Alan Third
2019-12-30 4:55 ` HaiJun Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PS1PR03MB36064A34EF2D938073F04C39B7270@PS1PR03MB3606.apcprd03.prod.outlook.com \
--to=netjune@outlook.com \
--cc=38731-done@debbugs.gnu.org \
--cc=alan@idiocy.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.