all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Christopher M. Miles" <numbchild@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: help-gnu-emacs@gnu.org
Subject: Re: [QUESTION] I have problem on my org-contacts capf function source code
Date: Mon, 15 Nov 2021 23:43:59 +0800	[thread overview]
Message-ID: <PAXPR08MB6640C2EE9E74A1990EE25971A3989@PAXPR08MB6640.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <jwvlf1psfa4.fsf-monnier+emacs@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 4026 bytes --]


Stefan Monnier via Users list for the GNU Emacs text editor <help-gnu-emacs@gnu.org> writes:

>> (add-hook 'completion-at-point-functions 'org-contacts-org-complete-function nil 'local)
>
> I assume you're careful to run this `add-hook` in the appropriate buffer
> (otherwise, of course it won't do anything useful ;-)
>

I test this `add-hook` in org-mode buffer and elisp-mode buffer.

>> When I evaluated upper code, and test by typing in "@Chri", I have not seen org-contacts related
>> complete popup candidates.
>
> Try `M-x trace-function RET org-contacts-org-complete-function RET`.
> Also you may prefer to first just try
>
>     M-: (org-contacts-org-complete-function) RET
>
> and make sure that what it returns makes sense.
> Then
>
>     M-: (all-completions "Chr" (nth 2 (org-contacts-org-complete-function))) RET
>
> Maybe try also
>
>     M-: (all-completions "@Chr" (nth 2 (org-contacts-org-complete-function))) RET
>
> then check whether the BEG..END area returned by
> `org-contacts-org-complete-function` contains "@Chr" or "Chr".

I followed your steps. Got following trace output:

#+begin_example
======================================================================
1 -> (org-contacts-org-complete-function)
1 <- org-contacts-org-complete-function: nil
======================================================================
1 -> (org-contacts-org-complete-function)
1 <- org-contacts-org-complete-function: nil
======================================================================
1 -> (org-contacts-org-complete-function)
1 <- org-contacts-org-complete-function: nil
#+end_example

I found ~org-contacts-org-complete-function~ returned a special value:

#+begin_example
#f(compiled-function (string pred action) #<bytecode -0x9e1a398d61d3acb>)
#+end_example


And this code,

#+begin_src emacs-lisp
(completion-table-dynamic
             (lambda (_)
               (mapcar
                (lambda (contact) (plist-get contact :name))
                (org-contacts--all-contacts))))
#+end_src

returned following:

#+begin_example
#[771 "....." [(lambda (_) (mapcar ... ...)) nil boundaries metadata minibuffer-selected-window window-live-p window-buffer complete-with-action] 8 "

(fn STRING PRED ACTION)"]
#+end_example

Don't know whether this is correct.

I can confirm the bellowing basic completion with ~try-completion~ code works fine:

#+begin_src emacs-lisp
(try-completion
 "tri"
 (mapcar
  (lambda (contact) (plist-get contact :name))
  (org-contacts--all-contacts)))
#+end_src

# ==================================================================================================

At last, I paste my latest simple code version:

#+begin_src emacs-lisp
(defun org-contacts-org-complete-function ()
  "Function used in `completion-at-point-functions' in `org-mode' to complete @name."
  (when-let* ((bounds (bounds-of-thing-at-point 'symbol))
              (begin (1- (car bounds)))
              (end (cdr bounds))
              (symbol (buffer-substring-no-properties begin end))
              (org-contacts-prefix-p (string-prefix-p "@" symbol))
              ;; (prefix (substring-no-properties symbol 1 nil))
              )
    (when org-contacts-prefix-p
      (list begin
            end
            (completion-table-dynamic
             (lambda (_)
               (mapcar
                (lambda (contact) (plist-get contact :name))
                (org-contacts--all-contacts))))))))
#+end_src

And test with execute following ~add-hook~ in org-mode buffer or emacs-lisp-mode buffer:

#+begin_src emacs-lisp
(add-hook 'completion-at-point-functions 'org-contacts-org-complete-function nil 'local)
#+end_src



-- 
[ stardiviner ]
       I try to make every word tell the meaning that I want to express.

       Blog: https://stardiviner.github.io/
       IRC(freenode): stardiviner, Matrix: stardiviner
       GPG: F09F650D7D674819892591401B5DF1C95AE89AC3

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2021-11-15 15:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-14  9:59 [QUESTION] I have problem on my org-contacts capf function source code Christopher M. Miles
2021-11-14 23:10 ` Stefan Monnier via Users list for the GNU Emacs text editor
2021-11-15  9:05   ` Christopher M. Miles
2021-11-15 13:50     ` Stefan Monnier via Users list for the GNU Emacs text editor
2021-11-15 15:43       ` Christopher M. Miles [this message]
2021-11-15 21:30         ` Stefan Monnier
2021-11-18  6:56           ` [SOLVED] " Christopher M. Miles

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PAXPR08MB6640C2EE9E74A1990EE25971A3989@PAXPR08MB6640.eurprd08.prod.outlook.com \
    --to=numbchild@gmail.com \
    --cc=help-gnu-emacs@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.