Bug in vhdl-mode.el version 3.29 for emacs 21.2-windows.

Bug in vhdl-mode.el version 3.29 for emacs 21.2-windows.

[Rob Kaut]

emacs version: 21.2 windows
vhdl-mode.el version: 3.29

In emacs 20.4 the function 'vhdl-comment-uncomment-region' works
properly in vhdl-mode, but in the 21.2 version it does not. This
seems to be due to the modification of the 'comment-region'
function from version 20.4 to 21.2. In 20.4 'comment-region' is
in simple.el and in 21.2 it seems to have moved to newcomment.el
and had its operation changed.

The fix that I have used right now is to modify the function
'vhdl-comment-uncomment-region' in my vhdl-mode.el to remove two
comment characters at the start of the line instead of one. A
diff of the original and modified would show:

7570c7570
<	(comment-region beg end -1)
--
>	(comment-region beg end -2)

Anyways, I hope this helps. If you need more info, please let me
know.

Rob Kaut

----------------------------------------------------------
Rob Kaut
Digital IC Designer

SiWorks Inc.                phone: (403) 282-1650 Ext. 224
253, 3553-31 Street NW        fax: (403) 260-8619
Calgary, Alberta,           email: rob@siworks.com
Canada T2L 2K7            website: http://www.siworks.com/
----------------------------------------------------------

Re: Bug in vhdl-mode.el version 3.29 for emacs 21.2-windows.

[Richard Stallman]

Thanks for this fix.  We will install it.

In the future, would you please use diff -c to make diffs to send?
Installing a "normal" diff is not reliable in many cases,
and it is harder to understand.

RE: Bug in vhdl-mode.el version 3.29 for emacs 21.2-windows.

[Rob Kaut]

Will do. I apologize if the info in my earlier email was
incomprehensible - I hope you were able to use it to incorporate
the fix.

r

> -----Original Message-----
> From: Richard Stallman [mailto:rms@gnu.org]
> Sent: Saturday, March 01, 2003 2:45 PM
> To: Rob Kaut
> Cc: bug-gnu-emacs@gnu.org
> Subject: Re: Bug in vhdl-mode.el version 3.29 for emacs
> 21.2-windows.
>
> Thanks for this fix.  We will install it.
>
> In the future, would you please use diff -c to make
> diffs to send?  Installing a "normal" diff is not
> reliable in many cases, and it is harder to understand.

Re: Bug in vhdl-mode.el version 3.29 for emacs 21.2-windows.

[Reto Zimmermann]

Rob Kaut wrote:
> emacs version: 21.2 windows
> vhdl-mode.el version: 3.29
> 
> In emacs 20.4 the function 'vhdl-comment-uncomment-region' works
> properly in vhdl-mode, but in the 21.2 version it does not. This
> seems to be due to the modification of the 'comment-region'
> function from version 20.4 to 21.2. In 20.4 'comment-region' is
> in simple.el and in 21.2 it seems to have moved to newcomment.el
> and had its operation changed.

The vhdl-mode patches 3.32.6 and 3.31.25 fixed various Emacs 21 related 
issues, including this one.  You can upgrade to the latest patches of 
vhdl-mode 3.31 and 3.32 at http://opensource.ethz.ch/emacs/vhdl-mode.html.

I will make sure that the latest patch also makes it into the Emacs 21 
distribution.

Thanks for the hint,
Reto